adsligh_rsslib.php ➔ RSS_Display() - Code Metrics - Inspection of "2.2 Beta 3" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 923121...f83415 )

by Michael

created 2016-09-28 07:08 UTC

adsligh_rsslib.php ➔ RSS_Display() C

↳ Parent: Project

Complexity

Conditions	10
Paths	136

Size

Total Lines	48
Code Lines	31

Duplication

Lines	12
Ratio	25 %

Importance

Changes

Metric	Value
cc	10
eloc	31
nc	136
nop	3
dl	12
loc	48
rs	5.0666
c	0
b	0
f	0

How to fix Complexity

<?php

/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

$RSS_Content = array();

/**
 * @param $item
 * @param $type
 *
 * @return array
 */
function RSS_Tags($item, $type)
{
    $y     = array();
    $tnl   = $item->getElementsByTagName('title');
    $tnl   = $tnl->item(0);
    $title = $tnl->firstChild->textContent;

    $tnl  = $item->getElementsByTagName('link');
    $tnl  = $tnl->item(0);
    $link = $tnl->firstChild->textContent;

    $tnl  = $item->getElementsByTagName('pubDate');
    $tnl  = $tnl->item(0);
    $date = $tnl->firstChild->textContent;

    $tnl         = $item->getElementsByTagName('description');
    $tnl         = $tnl->item(0);
    $description = $tnl->firstChild->textContent;

    $y['title']       = $title;
    $y['link']        = $link;
    $y['date']        = $date;
    $y['description'] = $description;
    $y['type']        = $type;

    return $y;
}

/**
 * @param $channel
 */
function RSS_Channel($channel)
{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $items = $channel->getElementsByTagName('item');

    // Processing channel

    $y = RSS_Tags($channel, 0);        // get description of channel, type 0
    array_push($RSS_Content, $y);

    // Processing articles

    foreach ($items as $item) {
        $y = RSS_Tags($item, 1);    // get description of article, type 1
        array_push($RSS_Content, $y);
    }
}

/**
 * @param $url
 */
function RSS_Retrieve($url)
{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $doc = new DOMDocument();
    $doc->load($url);

    $channels = $doc->getElementsByTagName('channel');

    $RSS_Content = array();

    foreach ($channels as $channel) {
        RSS_Channel($channel);
    }
}

/**
 * @param $url
 */
function RSS_RetrieveLinks($url)
{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $doc = new DOMDocument();
    $doc->load($url);

    $channels = $doc->getElementsByTagName('channel');

    $RSS_Content = array();

    foreach ($channels as $channel) {
        $items = $channel->getElementsByTagName('item');
        foreach ($items as $item) {
            $y = RSS_Tags($item, 1);    // get description of article, type 1
            array_push($RSS_Content, $y);
        }
    }
}

/**
 * @param     $url
 * @param int $size
 *
 * @return string
 */
function RSS_Links($url, $size = 15)
{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $page = '<ul>';

    RSS_RetrieveLinks($url);
    if ($size > 0) {
        $recents = array_slice($RSS_Content, 0, $size + 1);
    }

    foreach ($recents as $article) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $type = $article['type'];
        if ($type == 0) {
            continue;
        }
        $title = $article['title'];
        $link  = $article['link'];
        $page .= "<li><a href=\"$link\">$title</a></li>\n";
    }

    $page .= "</ul>\n";

    return $page;
}

/**
 * @param     $url
 * @param int $size
 * @param int $site
 *
 * @return string
 */
function RSS_Display($url, $size = 15, $site = 0)
{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $opened = false;
    $page   = '';
    $site   = ((int)$site == 0) ? 1 : 0;

    RSS_Retrieve($url);
    if ($size > 0) {
        $recents = array_slice($RSS_Content, $site, $size + 1 - $site);
    }

    foreach ($recents as $article) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $type = $article['type'];
        if ($type == 0) {

            if ($opened == true) {

                $page .= '</ul>';
                $opened = false;
            }
            $page .= '<b>';
        } else {
            if ($opened == false) {

                $page .= '<ul>';
                $opened = true;
            }
        }
        $title = $article['title'];
        $link  = $article['link'];
        $page .= "<tr class=\"even\"><td width=\"300\"><img src=\"../assets/images/admin/info_button.png\" border=0 /> <a href=\"$link\">$title</a><br>";

        $description = $article['description'];
        if ($description != false) {
            $page .= "$description<br><br></td></tr>";
        }
        $page .= '';

        if ($type == 0) {
            $page .= '</b>';
        }
    }

    if ($opened == true) {

        $page .= '</ul>';
    }

    return $page . '';
}

/**
 * @param     $url
 * @param int $size
 * @param int $site
 * @param int $withdate
 *
 * @return string
 */
function RSS_DisplayForum($url, $size = 15, $site = 0, $withdate = 0)

{
    global $RSS_Content;
function myFunction($a, $b) {
    // Do something
}

    $opened = false;
    $page   = '';
    $site   = ((int)$site == 0) ? 1 : 0;

    RSS_Retrieve($url);
    if ($size > 0) {
        $recents = array_slice($RSS_Content, $site, $size + 1 - $site);
    }

    foreach ($recents as $article) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $type = $article['type'];
        if ($type == 0) {

            if ($opened == true) {

                $page .= '</ul>';
                $opened = false;
            }
            $page .= '<b>';
        } else {
            if ($opened == false) {

                $page .= '<ul>';
                $opened = true;
            }
        }

        $title = $article['title'];
        $link  = $article['link'];

        $page .= "<img src=\"../assets/images/admin/comment.png\" border=0 />&nbsp;&nbsp;&nbsp;<a href=\"$link\">$title</a><br><br>";

        if ($type == 0) {
            $page .= '</b>';
        }
    }

    if ($opened == true) {

        $page .= '</ul>';
    }

    return $page . '';
}


Push — master ( 923121...f83415 )

adsligh_rsslib.php ➔ RSS_Display() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		-------------------------------------------------------------------------
4		ADSLIGHT 2 : Module for Xoops
5
6		Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7		Started with the Classifieds module and made MANY changes
8		Website : http://www.luc-bizet.fr
9		Contact : [email protected]
10		-------------------------------------------------------------------------
11		Original credits below Version History
12		##########################################################################
13		# Classified Module for Xoops #
14		# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15		# Started with the MyAds module and made MANY changes #
16		##########################################################################
17		Original Author: Pascal Le Boustouller
18		Author Website : [email protected]
19		Licence Type : GPL
20		-------------------------------------------------------------------------
21		*/
22
23		$RSS_Content = array();
24
25		/**
26		* @param $item
27		* @param $type
28		*
29		* @return array
30		*/
31		function RSS_Tags($item, $type)
32		{
33		$y = array();
34		$tnl = $item->getElementsByTagName('title');
35		$tnl = $tnl->item(0);
36		$title = $tnl->firstChild->textContent;
37
38		$tnl = $item->getElementsByTagName('link');
39		$tnl = $tnl->item(0);
40		$link = $tnl->firstChild->textContent;
41
42		$tnl = $item->getElementsByTagName('pubDate');
43		$tnl = $tnl->item(0);
44		$date = $tnl->firstChild->textContent;
45
46		$tnl = $item->getElementsByTagName('description');
47		$tnl = $tnl->item(0);
48		$description = $tnl->firstChild->textContent;
49
50		$y['title'] = $title;
51		$y['link'] = $link;
52		$y['date'] = $date;
53		$y['description'] = $description;
54		$y['type'] = $type;
55
56		return $y;
57		}
58
59		/**
60		* @param $channel
61		*/
62		function RSS_Channel($channel)
63		{
64		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
65
66		$items = $channel->getElementsByTagName('item');
67
68		// Processing channel
69
70		$y = RSS_Tags($channel, 0); // get description of channel, type 0
71		array_push($RSS_Content, $y);
72
73		// Processing articles
74
75		foreach ($items as $item) {
76		$y = RSS_Tags($item, 1); // get description of article, type 1
77		array_push($RSS_Content, $y);
78		}
79		}
80
81		/**
82		* @param $url
83		*/
84		function RSS_Retrieve($url)
85		{
86		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
87
88		$doc = new DOMDocument();
89		$doc->load($url);
90
91		$channels = $doc->getElementsByTagName('channel');
92
93		$RSS_Content = array();
94
95		foreach ($channels as $channel) {
96		RSS_Channel($channel);
97		}
98		}
99
100		/**
101		* @param $url
102		*/
103		function RSS_RetrieveLinks($url)
104		{
105		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
106
107		$doc = new DOMDocument();
108		$doc->load($url);
109
110		$channels = $doc->getElementsByTagName('channel');
111
112		$RSS_Content = array();
113
114		foreach ($channels as $channel) {
115		$items = $channel->getElementsByTagName('item');
116		foreach ($items as $item) {
117		$y = RSS_Tags($item, 1); // get description of article, type 1
118		array_push($RSS_Content, $y);
119		}
120		}
121		}
122
123		/**
124		* @param $url
125		* @param int $size
126		*
127		* @return string
128		*/
129		function RSS_Links($url, $size = 15)
130		{
131		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
132
133		$page = '<ul>';
134
135		RSS_RetrieveLinks($url);
136		if ($size > 0) {
137		$recents = array_slice($RSS_Content, 0, $size + 1);
138		}
139
140		foreach ($recents as $article) {
		0 ignored issues – show Bug introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report The variable `$recents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
141		$type = $article['type'];
142		if ($type == 0) {
143		continue;
144		}
145		$title = $article['title'];
146		$link = $article['link'];
147		$page .= "<li><a href=\"$link\">$title</a></li>\n";
148		}
149
150		$page .= "</ul>\n";
151
152		return $page;
153		}
154
155		/**
156		* @param $url
157		* @param int $size
158		* @param int $site
159		*
160		* @return string
161		*/
162		function RSS_Display($url, $size = 15, $site = 0)
163		{
164		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
165
166		$opened = false;
167		$page = '';
168		$site = ((int)$site == 0) ? 1 : 0;
169
170		RSS_Retrieve($url);
171		if ($size > 0) {
172		$recents = array_slice($RSS_Content, $site, $size + 1 - $site);
173		}
174
175		foreach ($recents as $article) {
		0 ignored issues – show Bug introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report The variable `$recents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
176		$type = $article['type'];
177	View Code Duplication	if ($type == 0) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
178		if ($opened == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
179		$page .= '</ul>';
180		$opened = false;
181		}
182		$page .= '<b>';
183		} else {
184		if ($opened == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
185		$page .= '<ul>';
186		$opened = true;
187		}
188		}
189		$title = $article['title'];
190		$link = $article['link'];
191		$page .= "<tr class=\"even\"><td width=\"300\"><img src=\"../assets/images/admin/info_button.png\" border=0 /> <a href=\"$link\">$title</a><br>";
192
193		$description = $article['description'];
194		if ($description != false) {
195		$page .= "$description<br><br></td></tr>";
196		}
197		$page .= '';
198
199		if ($type == 0) {
200		$page .= '</b>';
201		}
202		}
203
204		if ($opened == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
205		$page .= '</ul>';
206		}
207
208		return $page . '';
209		}
210
211		/**
212		* @param $url
213		* @param int $size
214		* @param int $site
215		* @param int $withdate
216		*
217		* @return string
218		*/
219		function RSS_DisplayForum($url, $size = 15, $site = 0, $withdate = 0)
		0 ignored issues – show Unused Code introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report The parameter `$withdate` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
220		{
221		global $RSS_Content;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
222
223		$opened = false;
224		$page = '';
225		$site = ((int)$site == 0) ? 1 : 0;
226
227		RSS_Retrieve($url);
228		if ($size > 0) {
229		$recents = array_slice($RSS_Content, $site, $size + 1 - $site);
230		}
231
232		foreach ($recents as $article) {
		0 ignored issues – show Bug introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report The variable `$recents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
233		$type = $article['type'];
234	View Code Duplication	if ($type == 0) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
235		if ($opened == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
236		$page .= '</ul>';
237		$opened = false;
238		}
239		$page .= '<b>';
240		} else {
241		if ($opened == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
242		$page .= '<ul>';
243		$opened = true;
244		}
245		}
246
247		$title = $article['title'];
248		$link = $article['link'];
249
250		$page .= "<img src=\"../assets/images/admin/comment.png\" border=0 />   <a href=\"$link\">$title</a><br><br>";
251
252		if ($type == 0) {
253		$page .= '</b>';
254		}
255		}
256
257		if ($opened == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
258		$page .= '</ul>';
259		}
260
261		return $page . '';
262		}
263

mambax7 / adslight

Push — master ( 923121...f83415 )

adsligh_rsslib.php ➔ RSS_Display() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like