Completed
Push — master ( 975d00...38bf19 )
by Michael
03:21
created

viewads.php ➔ viewAds()   F

Complexity

Conditions 46
Paths > 20000

Size

Total Lines 458
Code Lines 336

Duplication

Lines 34
Ratio 7.42 %

Importance

Changes 0
Metric Value
cc 46
eloc 336
nc 4294967295
nop 1
dl 34
loc 458
rs 2
c 0
b 0
f 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 60 and the first side effect is on line 23.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
/*
3
-------------------------------------------------------------------------
4
                     ADSLIGHT 2 : Module for Xoops
5
6
        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7
        Started with the Classifieds module and made MANY changes
8
        Website : http://www.luc-bizet.fr
9
        Contact : [email protected]
10
-------------------------------------------------------------------------
11
             Original credits below Version History
12
##########################################################################
13
#                    Classified Module for Xoops                         #
14
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
15
#      Started with the MyAds module and made MANY changes               #
16
##########################################################################
17
 Original Author: Pascal Le Boustouller
18
 Author Website : [email protected]
19
 Licence Type   : GPL
20
-------------------------------------------------------------------------
21
*/
22
23
include_once __DIR__ . '/header.php';
24
require_once XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';
25
xoops_load('XoopsLocal');
26
$tempXoopsLocal = new XoopsLocal;
27
$myts      = MyTextSanitizer::getInstance();
28
$module_id = $xoopsModule->getVar('mid');
29
30
if (is_object($xoopsUser)) {
31
    $groups = $xoopsUser->getGroups();
32
} else {
33
    $groups = XOOPS_GROUP_ANONYMOUS;
34
}
35
$gperm_handler = xoops_getHandler('groupperm');
36
if (isset($_POST['item_id'])) {
37
    $perm_itemid = (int)$_POST['item_id'];
38
} else {
39
    $perm_itemid = 0;
40
}
41
//If no access
42 View Code Duplication
if (!$gperm_handler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
43
    redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
44
}
45
if (!$gperm_handler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
46
    $prem_perm = '0';
47
} else {
48
    $prem_perm = '1';
49
}
50
51
include XOOPS_ROOT_PATH . '/modules/adslight/class/classifiedstree.php';
52
include XOOPS_ROOT_PATH . '/modules/adslight/include/functions.php';
53
$mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
54
55
#  function viewads
56
#####################################################
57
/**
58
 * @param int $lid
59
 */
60
function viewAds($lid = 0)
1 ignored issue
show
Coding Style introduced by
viewAds uses the super-global variable $GLOBALS which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
61
{
62
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsTpl, $xoopsUser, $myts, $meta, $moduleDirName, $main_lang, $prem_perm, $xoopsModule;
1 ignored issue
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
63
    $pathIcon16 = $xoopsModule->getInfo('icons16');
64
65
    $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';
66
    include XOOPS_ROOT_PATH . '/header.php';
67
    include XOOPS_ROOT_PATH . '/include/comment_view.php';
68
    $lid  = ((int)$lid > 0) ? (int)$lid : 0;
69
    $rate = ($xoopsModuleConfig['adslight_rate_item'] == '1') ? '1' : '0';
70
    $xoopsTpl->assign('rate', $rate);
71
    $xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
72
    $xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);
73
74
    // Hack redirection erreur 404  si lid=null
75 View Code Duplication
    if ($lid == '') {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
76
        header('Status: 301 Moved Permanently', false, 301);
77
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
0 ignored issues
show
Unused Code Comprehensibility introduced by
50% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
78
        //        exit();
79
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
80
    }
81
82
    $xoopsTpl->assign('adslight_active_bookmark', $xoopsModuleConfig['adslight_active_bookmark']);
83
    $xoopsTpl->assign('adslight_style_bookmark', $xoopsModuleConfig['adslight_style_bookmark']);
84
    $xoopsTpl->assign('adslight_active_xpayement', $xoopsModuleConfig['adslight_active_xpayment']);
85
86
    // adslight 2
87
    $xoopsTpl->assign('adslight_active_menu', $xoopsModuleConfig['adslight_active_menu']);
88
    $xoopsTpl->assign('adslight_active_rss', $xoopsModuleConfig['adslight_active_rss']);
89
90
    if ($xoopsUser) {
91
        $member_usid = $xoopsUser->getVar('uid');
92
        if ($usid = $member_usid) {
93
            $xoopsTpl->assign('istheirs', true);
94
95
            if (strlen($xoopsUser->getVar('name'))) {
96
                $xoopsTpl->assign('user_name', $xoopsUser->getVar('name') . ' (' . $xoopsUser->getVar('uname') . ')');
97
            } else {
98
                $xoopsTpl->assign('user_name', $xoopsUser->getVar('uname'));
99
            }
100
101
            $xoopsTpl->assign('user_email', $xoopsUser->getVar('email'));
102
103
            list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE usid=$member_usid"));
104
105
            $xoopsTpl->assign('show_user', $show_user);
106
            $xoopsTpl->assign('show_user_link', 'members.php?usid=' . $member_usid . '');
107
        }
108
    }
109
110
    if ($xoopsUser) {
111
        $currentid = $xoopsUser->getVar('uid', 'E');
0 ignored issues
show
Unused Code introduced by
$currentid is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
112
    }
113
114
    $cat_perms  = '';
115
    $categories = adslight_MygetItemIds('adslight_view');
116
    if (is_array($categories) && count($categories) > 0) {
117
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
118
    }
119
120
    $result      = $xoopsDB->query('SELECT l.lid, l.cid, l.title, l.status, l.expire, l.type, l.desctext, l.tel, l.price, l.typeprice, l.typeusure, l.date, l.email, l.submitter, l.usid, l.town, l.country, l.contactby, l.premium, l.valid, l.photo, l.hits, l.item_rating, l.item_votes, l.user_rating, l.user_votes, l.comments, p.cod_img, p.lid, p.uid_owner, p.url FROM '
121
                                   . $xoopsDB->prefix('adslight_listing')
122
                                   . ' l LEFT JOIN '
123
                                   . $xoopsDB->prefix('adslight_pictures')
124
                                   . " p ON l.lid=p.lid  WHERE l.valid='Yes' AND l.lid = "
125
                                   . $xoopsDB->escape($lid)
126
                                   . " and l.status!='1' $cat_perms");
127
    $recordexist = $xoopsDB->getRowsNum($result);
128
129
    // Hack redirection erreur 404  si recordexist=null
130 View Code Duplication
    if ($recordexist == '') {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
131
        header('Status: 301 Moved Permanently', false, 301);
132
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
0 ignored issues
show
Unused Code Comprehensibility introduced by
50% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
133
        //        exit();
134
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
135
    }
136
137
    if ($recordexist) {
138
        list($lid, $cid, $title, $status, $expire, $type, $desctext, $tel, $price, $typeprice, $typeusure, $date, $email, $submitter, $usid, $town, $country, $contactby, $premium, $valid, $photo, $hits, $item_rating, $item_votes, $user_rating, $user_votes, $comments, $cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($result);
0 ignored issues
show
Unused Code introduced by
The assignment to $email is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $valid is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $user_rating is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $user_votes is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $comments is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $cod_img is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $url is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
139
140
        $newcount  = $xoopsModuleConfig['adslight_countday'];
141
        $startdate = (time() - (86400 * $newcount));
142
        if ($startdate < $date) {
143
            $newitem = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
144
            $xoopsTpl->assign('new', $newitem);
145
        }
146
147
        $updir = $xoopsModuleConfig['adslight_link_upload'];
0 ignored issues
show
Unused Code introduced by
$updir is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
148
        $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
149
        $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
150
        $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
151
        $xoopsTpl->assign('ad_exists', $recordexist);
152
        $xoopsTpl->assign('mydirname', $moduleDirName);
153
154
        $count = 0;
0 ignored issues
show
Unused Code introduced by
$count is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
155
        $x     = 0;
156
        $i     = 0;
0 ignored issues
show
Unused Code introduced by
$i is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
157
158
        $result3 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE  cid=' . $xoopsDB->escape($cid) . '');
159
        list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result3);
160
161
        $xoopsTpl->assign('category_title', $ctitle);
162
163
        $module_id = $xoopsModule->getVar('mid');
164
        if (is_object($xoopsUser)) {
165
            $groups = $xoopsUser->getGroups();
166
        } else {
167
            $groups = XOOPS_GROUP_ANONYMOUS;
168
        }
169
        $gperm_handler = xoops_getHandler('groupperm');
170
        $xoopsTpl->assign('purchasable', $gperm_handler->checkRight('adslight_purchase', $cid, $groups, $module_id));
171
172
        $ctitle     = $myts->htmlSpecialChars($ctitle);
173
        $varid[$x]  = $ccid;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$varid was never initialized. Although not strictly required by PHP, it is generally a good practice to add $varid = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
174
        $varnom[$x] = $ctitle;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$varnom was never initialized. Although not strictly required by PHP, it is generally a good practice to add $varnom = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
175
176
        list($nbe) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE valid="Yes" AND cid=' . $xoopsDB->escape($cid) . ' AND status!="1"'));
177
178
        if ($pid != 0) {
179
            $x = 1;
180
            while ($pid != 0) {
181
                $result4 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($pid) . '');
182
                list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result4);
183
184
                $ctitle     = $myts->htmlSpecialChars($ctitle);
185
                $varid[$x]  = $ccid;
186
                $varnom[$x] = $ctitle;
187
                ++$x;
188
            }
189
            --$x;
190
        }
191
        $subcats = '';
192
        $arrow   = '&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/arrow.gif" alt="&raquo;" />';
193
        while ($x != -1) {
194
            $subcats .= ' ' . $arrow . ' <a href="viewcats.php?cid=' . $varid[$x] . '">' . $varnom[$x] . '</a>';
195
            --$x;
196
        }
197
        $xoopsTpl->assign('nav_main', '<a href="index.php">' . _ADSLIGHT_MAIN . '</a>');
198
        $xoopsTpl->assign('nav_sub', $subcats);
199
        $xoopsTpl->assign('nav_subcount', $nbe);
200
        $viewcount_judge = true;
201
        $useroffset      = '';
202
        if ($xoopsUser) {
203
            $timezone = $xoopsUser->timezone();
204
            if (isset($timezone)) {
205
                $useroffset = $xoopsUser->timezone();
206
            } else {
207
                $useroffset = $xoopsConfig['default_TZ'];
208
            }
209
            if ($xoopsUser->isAdmin()) {
210
                $adslight_admin = true;
0 ignored issues
show
Unused Code introduced by
$adslight_admin is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
211
            } else {
212
                $adslight_admin = false;
0 ignored issues
show
Unused Code introduced by
$adslight_admin is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
213
            }
214
215
            if (($adslight_admin = true) || ($xoopsUser->getVar('uid') == $usid)) {
216
                $viewcount_judge = false;
217
            }
218
219
            $contact_pm = '<a href="' . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . addslashes($usid) . '">&nbsp;' . _ADSLIGHT_CONTACT_BY_PM . '</a>';
220
        }
221
        if (true === $viewcount_judge) {
222
            $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_listing') . ' SET hits=hits+1 WHERE lid = ' . $xoopsDB->escape($lid) . '');
223
        }
224
        if ($item_votes == 1) {
225
            $votestring = _ADSLIGHT_ONEVOTE;
226
        } else {
227
            $votestring = sprintf(_ADSLIGHT_NUMVOTES, $item_votes);
228
        }
229
        $date     = ($useroffset * 3600) + $date;
230
        $date2    = $date + ($expire * 86400);
231
        $date     = formatTimestamp($date, 's');
232
        $date2    = formatTimestamp($date2, 's');
233
        $title    = $myts->htmlSpecialChars($title);
234
        $status   = $myts->htmlSpecialChars($status);
235
        $expire   = $myts->htmlSpecialChars($expire);
0 ignored issues
show
Unused Code introduced by
$expire is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
236
        $type     = $myts->htmlSpecialChars($type);
237
        $desctext = $myts->displayTarea($desctext, 1, 1, 1);
238
        $tel      = $myts->htmlSpecialChars($tel);
239
        //      $price = XoopsLocal::number_format($price, 2, ',', ' ');
0 ignored issues
show
Unused Code Comprehensibility introduced by
58% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
240
        $typeprice = $myts->htmlSpecialChars($typeprice);
241
        $typeusure = $myts->htmlSpecialChars($typeusure);
242
        $submitter = $myts->htmlSpecialChars($submitter);
243
        $usid      = $myts->htmlSpecialChars($usid);
244
        $town      = $myts->htmlSpecialChars($town);
245
        $country   = $myts->htmlSpecialChars($country);
246
        $contactby = $myts->htmlSpecialChars($contactby);
247
        $premium   = $myts->htmlSpecialChars($premium);
248
249
        if ($status == 2) {
250
            $sold = _ADSLIGHT_RESERVED;
251
        } else {
252
            $sold = '';
253
        }
254
255
        $xoopsTpl->assign('printA', '<a href="print.php?op=PrintAd&amp;lid=' . $lid . '" ><img src="assets/images/print.gif" border=0 alt="' . _ADSLIGHT_PRINT . '" /></a>&nbsp;');
256
257
        if ($usid > 0) {
258
            $xoopsTpl->assign('submitter', '<img src="assets/images/lesannonces.png" border="0" alt="'
259
                                           . _ADSLIGHT_VIEW_MY_ADS
260
                                           . '" />&nbsp;&nbsp;<a href="members.php?usid='
261
                                           . addslashes($usid)
262
                                           . '" />'
263
                                           . _ADSLIGHT_VIEW_MY_ADS
264
                                           . ' '
265
                                           . $submitter
266
                                           . '</a>');
267
        } else {
268
            $xoopsTpl->assign('submitter', _ADSLIGHT_VIEW_MY_ADS . ' $submitter');
269
        }
270
        $xoopsTpl->assign('lid', $lid);
271
        $xoopsTpl->assign('read', "$hits " . _ADSLIGHT_VIEW2);
272
        $xoopsTpl->assign('rating', $tempXoopsLocal->number_format($item_rating, 2));
0 ignored issues
show
Bug introduced by
The variable $tempXoopsLocal does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
273
        $xoopsTpl->assign('votes', $votestring);
274
        $xoopsTpl->assign('lang_rating', _ADSLIGHT_RATINGC);
275
        $xoopsTpl->assign('lang_ratethisitem', _ADSLIGHT_RATETHISITEM);
276
        $xoopsTpl->assign('xoop_user', false);
277
        $isOwner = '';
0 ignored issues
show
Unused Code introduced by
$isOwner is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
278
        if ($xoopsUser) {
279
            $xoopsTpl->assign('xoop_user', true);
280
            $currentid = $xoopsUser->getVar('uid', 'E');
281
            if ($usid == $currentid) {
282
                $xoopsTpl->assign('modifyads', '<img src='
283
                                               . $pathIcon16
284
                                               . '/edit.png border="0" alt="'
285
                                               . _ADSLIGHT_MODIFANN
286
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ModAd&amp;lid='
287
                                               . $lid
288
                                               . '">'
289
                                               . _ADSLIGHT_MODIFANN
290
                                               . '</a>');
291
                $xoopsTpl->assign('deleteads', '<img src='
292
                                               . $pathIcon16
293
                                               . '/delete.png  border="0" alt="'
294
                                               . _ADSLIGHT_SUPPRANN
295
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ListingDel&amp;lid='
296
                                               . $lid
297
                                               . '">'
298
                                               . _ADSLIGHT_SUPPRANN
299
                                               . '</a>');
300
                $xoopsTpl->assign('add_photos', '<img src="assets/images/shape_square_add.png" border="0" alt="'
301
                                                . _ADSLIGHT_SUPPRANN
302
                                                . '" />&nbsp;&nbsp;<a href="view_photos.php?lid='
303
                                                . $lid
304
                                                . '&uid='
305
                                                . $usid
306
                                                . '">'
307
                                                . _ADSLIGHT_ADD_PHOTOS
308
                                                . '</a>');
309
310
                $isOwner = true;
311
                $xoopsTpl->assign('isOwner', $isOwner);
312
            }
313 View Code Duplication
            if ($xoopsUser->isAdmin()) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
314
                $xoopsTpl->assign('admin', '<a href="'
315
                                           . XOOPS_URL
316
                                           . '/modules/adslight/admin/modify_ads.php?op=ModifyAds&amp;lid='
317
                                           . $lid
318
                                           . '"><img src='
319
                                           . $pathIcon16
320
                                           . '/edit.png  border=0 alt="'
321
                                           . _ADSLIGHT_MODADMIN
322
                                           . '" /></a>');
323
            }
324
        }
325
326
        $result7 = $xoopsDB->query('SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . ' WHERE id_type=' . $xoopsDB->escape($type) . '');
327
        list($nom_type) = $xoopsDB->fetchRow($result7);
328
329
        $result8 = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . ' WHERE id_price=' . $xoopsDB->escape($typeprice) . '');
330
        list($nom_price) = $xoopsDB->fetchRow($result8);
331
332
        $result9 = $xoopsDB->query('SELECT nom_usure FROM ' . $xoopsDB->prefix('adslight_usure') . ' WHERE id_usure=' . $xoopsDB->escape($typeusure) . '');
333
        list($nom_usure) = $xoopsDB->fetchRow($result9);
334
335
        $xoopsTpl->assign('type', $myts->htmlSpecialChars($nom_type));
336
        $xoopsTpl->assign('title', $title);
337
        $xoopsTpl->assign('status', $status);
338
        $xoopsTpl->assign('desctext', $desctext);
339
        $xoopsTpl->assign('xoops_pagetitle', $title . ' - ' . $town . ': ' . $country . ' - ' . $ctitle);
340
341
        // meta description tags for ads
342
        $desctextclean = strip_tags($desctext, '<font><img><strong><i><u>');
343
        $xoTheme->addMeta('meta', 'description', "$title - " . substr($desctextclean, 0, 150));
0 ignored issues
show
Bug introduced by
The variable $xoTheme does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
344
345
        if ($price > 0) {
346
            $xoopsTpl->assign('price', '<strong>' . _ADSLIGHT_PRICE2 . '</strong>' . $price . ' ' . $xoopsModuleConfig['adslight_money'] . ' - ' . $typeprice);
347
            $xoopsTpl->assign('price_head', _ADSLIGHT_PRICE2);
348
            //      $xoopsTpl->assign('price_price', $price.' '.$xoopsModuleConfig['adslight_money'].' ');
0 ignored issues
show
Unused Code Comprehensibility introduced by
70% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
349
350
            $xoopsTpl->assign('price_price', $tempXoopsLocal->money_format('%.2n', $price));
351
352
            $xoopsTpl->assign('price_typeprice', $myts->htmlSpecialChars($nom_price));
353
            $xoopsTpl->assign('price_currency', $xoopsModuleConfig['adslight_currency']);
354
            $xoopsTpl->assign('price_amount', $price);
355
        }
356
357
        $xoopsTpl->assign('usure_typeusure', $nom_usure);
358
        $xoopsTpl->assign('premium', $premium);
359
360
        // $xoopsTpl->assign('mustlogin', _ADSLIGHT_MUSTLOGIN);
0 ignored issues
show
Unused Code Comprehensibility introduced by
64% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
361
        $xoopsTpl->assign('redirect', '' . '?xoops_redirect=/modules/adslight/index.php');
362
363
        if ($town) {
364
            $xoopsTpl->assign('local_town', $town);
365
        }
366
        if ($xoopsModuleConfig['adslight_use_country'] == 1) {
367
            if ($country) {
368
                $xoopsTpl->assign('local_country', $country);
369
                $xoopsTpl->assign('country_head', '<img src="assets/images/world_go.png" border="0" alt="country" />&nbsp;&nbsp;' . _ADSLIGHT_COUNTRY);
370
            }
371
        }
372
373
        $tphon = '';
374
        if ($tel) {
375
            $tphon = '<br>' . _ADSLIGHT_ORBY . '&nbsp;<strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
376
        }
377
378
        if ($contactby == 1) {
379
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '';
380
        }
381
        if ($contactby == 2) {
382
            $contact = $contact_pm . '' . $tphon;
0 ignored issues
show
Bug introduced by
The variable $contact_pm does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
383
        }
384
        if ($contactby == 3) {
385
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '<br>' . _ADSLIGHT_ORBY . '' . $contact_pm;
386
        }
387
        if ($contactby == 4) {
388
            $contact = '<br><strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
389
        }
390
        // $xoopsTpl->assign('contact', $contact);
0 ignored issues
show
Unused Code Comprehensibility introduced by
73% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
391
        $xoopsTpl->assign('local_head', '<img src="assets/images/house.png" border="0" alt="local_head" />&nbsp;&nbsp;' . _ADSLIGHT_LOCAL);
392
393
        if ($lid) {
394
            if ($sold) {
395
                $xoopsTpl->assign('bullinfotext', $sold);
396
            } else {
397
                if ($xoopsUser) {
398
                    $xoopsTpl->assign('bullinfotext', _ADSLIGHT_CONTACT_SUBMITTER . ' ' . $submitter . ' ' . _ADSLIGHT_CONTACTBY2 . ' ' . $contact);
0 ignored issues
show
Bug introduced by
The variable $contact does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
399
                } else {
400
                    $xoopsTpl->assign('bullinfotext', '<span style="color: #de090e"><b>' . _ADSLIGHT_MUSTLOGIN . '</b></span>');
401
                }
402
            }
403
        }
404
405
        $user_profile = XoopsUser::getUnameFromId($usid);
406
        $xoopsTpl->assign('user_profile', '<img src="assets/images/profil.png" border="0" alt="'
407
                                          . _ADSLIGHT_PROFILE
408
                                          . '" />&nbsp;&nbsp;<a rel="nofollow" href="'
409
                                          . XOOPS_URL
410
                                          . '/user.php?usid='
411
                                          . addslashes($usid)
412
                                          . '">'
413
                                          . _ADSLIGHT_PROFILE
414
                                          . ' '
415
                                          . $user_profile
416
                                          . '</a>');
417
418
        if ($photo != '') {
419
            include_once __DIR__ . '/class/pictures.php';
420
421
            $criteria_lid          = new criteria('lid', $lid);
422
            $criteria_uid          = new criteria('uid', $usid);
423
            $album_factory         = new Xoopsjlm_picturesHandler($xoopsDB);
424
            $pictures_object_array =& $album_factory->getObjects($criteria_lid, $criteria_uid);
425
            $pictures_number       = $album_factory->getCount($criteria_lid, $criteria_uid);
426 View Code Duplication
            if ($pictures_number == 0) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
427
                $nopicturesyet = _ADSLIGHT_NOTHINGYET;
428
                $xoopsTpl->assign('lang_nopicyet', $nopicturesyet);
429
            } else {
430
431
                /**
432
                 * Lets populate an array with the data from the pictures
433
                 */
434
                $i = 0;
435
                foreach ($pictures_object_array as $picture) {
436
                    $pictures_array[$i]['url']     = $picture->getVar('url', 's');
0 ignored issues
show
Coding Style Comprehensibility introduced by
$pictures_array was never initialized. Although not strictly required by PHP, it is generally a good practice to add $pictures_array = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
437
                    $pictures_array[$i]['desc']    = $picture->getVar('title', 's');
0 ignored issues
show
Bug introduced by
The variable $pictures_array does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
438
                    $pictures_array[$i]['cod_img'] = $picture->getVar('cod_img', 's');
439
                    $pictures_array[$i]['lid']     = $picture->getVar('lid', 's');
440
                    $xoopsTpl->assign('pics_array', $pictures_array);
441
442
                    ++$i;
443
                }
444
            }
445
            $owner      = new XoopsUser();
446
            $identifier = $owner->getUnameFromId($usid);
0 ignored issues
show
Unused Code introduced by
$identifier is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
447
            if ($xoopsModuleConfig['adslight_lightbox'] == 1) {
448
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/style/adslight.css" type="text/css" media="all" />
449
<script type="text/javascript" src="assets/lightbox/js/jquery-1.7.2.min.js"></script>
450
<script type="text/javascript" src="assets/lightbox/js/jquery-ui-1.8.18.custom.min"></script>
451
<script type="text/javascript" src="assets/lightbox/js/jquery.smooth-scroll.min.js"></script>
452
<script type="text/javascript" src="assets/lightbox/js/lightbox.js"></script>
453
<link rel="stylesheet" href="style/galery.css" type="text/css" media="screen" />
454
<link rel="stylesheet" type="text/css" media="screen" href="assets/lightbox/css/lightbox.css"></link>';
455
            } else {
456
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/style/adslight.css" type="text/css" media="all" />
457
<link rel="stylesheet" href="style/galery.css" type="text/css" media="screen" />';
458
            }
459
460
            $xoopsTpl->assign('path_uploads', $xoopsModuleConfig['adslight_link_upload']);
461
462
            $xoopsTpl->assign('permit', $prem_perm);
463
464
            if ($xoopsModuleConfig['active_rewriteurl'] > 0) {
465
                /*  ici le meta Canonicale pour le Rewrite */
466
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
467
            } else {
468
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
469
            }
470
            $xoopsTpl->assign('photo', $photo);
471
            $xoopsTpl->assign('pic_lid', $pic_lid);
472
            $xoopsTpl->assign('pic_owner', $uid_owner);
473
        } else {
474
            $xoopsTpl->assign('photo', '');
475
        }
476
        $xoopsTpl->assign('date', '<img alt="date" border="0" src="assets/images/date.png" />&nbsp;&nbsp;<strong>'
477
                                  . _ADSLIGHT_DATE2
478
                                  . ':</strong> '
479
                                  . $date
480
                                  . '<br><img alt="date_error" border="0" src="assets/images/date_error.png" />&nbsp;&nbsp;<strong>'
481
                                  . _ADSLIGHT_DISPO
482
                                  . ':</strong> '
483
                                  . $date2
484
                                  . '');
485
    } else {
486
        $xoopsTpl->assign('no_ad', _ADSLIGHT_NOCLAS);
487
    }
488
    $result8 = $xoopsDB->query('SELECT title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($cid) . '');
0 ignored issues
show
Bug introduced by
The variable $cid does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
489
490
    list($ctitle) = $xoopsDB->fetchRow($result8);
491
    $xoopsTpl->assign('friend', '<img src="assets/images/friend.gif" border="0" alt="'
492
                                . _ADSLIGHT_SENDFRIENDS
493
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="sendfriend.php?op=SendFriend&amp;lid='
494
                                . $lid
495
                                . '">'
496
                                . _ADSLIGHT_SENDFRIENDS
497
                                . '</a>');
498
499
    $xoopsTpl->assign('alerteabus', '<img src="assets/images/error.png" border="0" alt="'
500
                                    . _ADSLIGHT_ALERTEABUS
501
                                    . '" />&nbsp;&nbsp;<a rel="nofollow" href="report-abuse.php?op=ReportAbuse&amp;lid='
502
                                    . $lid
503
                                    . '">'
504
                                    . _ADSLIGHT_ALERTEABUS
505
                                    . '</a>');
506
507
    $xoopsTpl->assign('link_main', '<a href="../adslight/">' . _ADSLIGHT_MAIN . '</a>');
508
    $xoopsTpl->assign('link_cat', '<a href="viewcats.php?cid=' . addslashes($cid) . '">' . _ADSLIGHT_GORUB . ' ' . $ctitle . '</a>');
509
510
    $xoopsTpl->assign('printA', '<img src="assets/images/print.gif" border="0" alt="'
511
                                . _ADSLIGHT_PRINT
512
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="print.php?op=PrintAd&amp;lid='
513
                                . $lid
514
                                . '">'
515
                                . _ADSLIGHT_PRINT
516
                                . '</a>');
517
}
518
519
#  function categorynewgraphic
520
#####################################################
521
/**
522
 * @param $cid
523
 *
524
 * @return string
0 ignored issues
show
Documentation introduced by
Should the return type not be null?

This check compares the return type specified in the @return annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.

Loading history...
525
 */
526
function categorynewgraphic($cid)
0 ignored issues
show
Best Practice introduced by
The function categorynewgraphic() has been defined more than once; this definition is ignored, only the first definition in index.php (L375-378) is considered.

This check looks for functions that have already been defined in other files.

Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the @ignore annotation.

/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}

See also the PhpDoc documentation for @ignore.

Loading history...
527
{
528
    global $xoopsDB, $xoopsModuleConfig;
1 ignored issue
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
529
530
    $cat_perms  = '';
531
    $categories = adslight_MygetItemIds('adslight_view');
532
    if (is_array($categories) && count($categories) > 0) {
533
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
534
    }
535
536
    $newresult = $xoopsDB->query('SELECT date FROM '
537
                                 . $xoopsDB->prefix('adslight_listing')
538
                                 . ' WHERE cid='
539
                                 . $xoopsDB->escape($cid)
540
                                 . ' AND valid = "Yes" '
541
                                 . $cat_perms
542
                                 . ' ORDER BY date desc limit 1');
543
    list($date) = $xoopsDB->fetchRow($newresult);
544
545
    $newcount  = $xoopsModuleConfig['adslight_countday'];
546
    $startdate = (time() - (86400 * $newcount));
547
    if ($startdate < $date) {
548
        return '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
549
    }
550
}
551
552
######################################################
553
554
$pa      = !isset($_GET['pa']) ? null : $_GET['pa'];
555
$lid     = !isset($_GET['lid']) ? null : $_GET['lid'];
556
$cid     = !isset($_GET['cid']) ? null : $_GET['cid'];
557
$usid    = isset($_GET['usid']) ? $_GET['usid'] : '';
558
$min     = !isset($_GET['min']) ? null : $_GET['min'];
559
$show    = !isset($_GET['show']) ? null : $_GET['show'];
560
$orderby = !isset($_GET['orderby']) ? null : $_GET['orderby'];
561
562
switch ($pa) {
563
564
    default:
565
        $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';
566
567
        viewAds($lid);
568
        break;
569
}
570
include XOOPS_ROOT_PATH . '/footer.php';
571