Issues in viewcats.php - Fixed Issues - Inspection of "updates" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 67bb37...e20777 )

by Michael
created 2016-10-01 22:34 UTC
viewcats.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';
require XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';
xoops_load('XoopsLocal');
$tempXoopsLocal = new XoopsLocal;
$myts           = MyTextSanitizer::getInstance();
$module_id      = $xoopsModule->getVar('mid');

if (is_object($GLOBALS['xoopsUser'])) {
    $groups = $GLOBALS['xoopsUser']->getGroups();
} else {
    $groups = XOOPS_GROUP_ANONYMOUS;
}
$gpermHandler = xoops_getHandler('groupperm');

$perm_itemid = XoopsRequest::getInt('item_id', 0, 'POST');

if (!$gpermHandler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {
    redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
}
if (!$gpermHandler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
    $prem_perm = '0';
} else {
    $prem_perm = '1';
}

include XOOPS_ROOT_PATH . '/modules/adslight/class/classifiedstree.php';
//include XOOPS_ROOT_PATH . '/modules/adslight/class/utilities.php';
$mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

#  function view (categories)
#####################################################
/**
 * @param int $cid
 * @param int $min
 * @param     $orderby
 * @param int $show
 */
function adsView($cid = 0, $min = 0, $orderby, $show = 0)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB, $xoopsTpl, $xoopsConfig, $myts, $mytree, $imagecat, $meta, $moduleDirName, $main_lang, $mid, $prem_perm, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
    $pathIcon16 = $xoopsModule->getInfo('icons16');

    $GLOBALS['xoopsOption']['template_main'] = 'adslight_category.tpl';
    include XOOPS_ROOT_PATH . '/header.php';

    $xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
    $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
    $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
    $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
    $xoopsTpl->assign('only_pix', _ADSLIGHT_ONLYPIX);
    $xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);
    $xoopsTpl->assign('permit', $prem_perm);

    $xoopsTpl->assign('xoops_module_header', '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" />');

    // $adslight_use_catscode = $GLOBALS['xoopsModuleConfig']['adslight_use_catscode'];
    // $adslight_cats_code = $GLOBALS['xoopsModuleConfig']['adslight_cats_code'];

    $xoopsTpl->assign('adslight_use_catscode', $GLOBALS['xoopsModuleConfig']['adslight_use_catscode']);
    $xoopsTpl->assign('adslight_cats_code', $GLOBALS['xoopsModuleConfig']['adslight_cats_code']);

    $banner = xoops_getbanner();
    $xoopsTpl->assign('banner', $banner);
    // $index_code_place = $GLOBALS['xoopsModuleConfig']['adslight_index_code_place'];
    // $use_extra_code = $GLOBALS['xoopsModuleConfig']['adslight_use_index_code'];
    // $adslight_use_banner = $GLOBALS['xoopsModuleConfig']['adslight_use_banner'];
    // $index_extra_code = $GLOBALS['xoopsModuleConfig']['adslight_index_code'];

    $xoopsTpl->assign('use_extra_code', $GLOBALS['xoopsModuleConfig']['adslight_use_index_code']);
    $xoopsTpl->assign('adslight_use_banner', $GLOBALS['xoopsModuleConfig']['adslight_use_banner']);
    $xoopsTpl->assign('index_extra_code', $GLOBALS['xoopsModuleConfig']['adslight_index_code']);
    $xoopsTpl->assign('index_code_place', $GLOBALS['xoopsModuleConfig']['adslight_index_code_place']);

    // adslight 2
    $xoopsTpl->assign('adslight_active_menu', $GLOBALS['xoopsModuleConfig']['adslight_active_menu']);
    $xoopsTpl->assign('adslight_active_rss', $GLOBALS['xoopsModuleConfig']['adslight_active_rss']);

    /// No Adds in this Cat ///
    $submit_perms = AdslightUtilities::getMyItemIds('adslight_submit');

    if ($GLOBALS['xoopsUser'] && is_array($submit_perms) && count($submit_perms) > 0) {
        $xoopsTpl->assign('not_adds_in_this_cat',
                          '' . _ADSLIGHT_ADD_LISTING_NOTADDSINTHISCAT . '<a href="addlisting.php?cid=' . addslashes($cid) . '">' . _ADSLIGHT_ADD_LISTING_NOTADDSSUBMIT . '</a>');
    } else {
        $xoopsTpl->assign('not_adds_in_this_cat',
                          '' . _ADSLIGHT_ADD_LISTING_NOTADDSINTHISCAT . '<br>' . _ADSLIGHT_ADD_LISTING_BULL . '<a href="' . XOOPS_URL . '/register.php">' . _ADSLIGHT_ADD_LISTING_SUB . '</a>.');
    }

    $xoopsTpl->assign('Feed_RSS_cat', '&nbsp;&nbsp;&nbsp;<a href="rss.php?cid=' . addslashes($cid) . '"><img border="0" alt="Feed RSS" src="assets/images/rssfeed_buttons.png" /></a>');

    if ($GLOBALS['xoopsUser']) {
        $member_usid = $GLOBALS['xoopsUser']->getVar('uid');
        if ($usid = $member_usid) {
            $xoopsTpl->assign('istheirs', true);

            list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE usid=' . $member_usid . ''));

            $xoopsTpl->assign('show_user', $show_user);
            $xoopsTpl->assign('show_user_link', 'members.php?usid=' . $member_usid);
        }
    }

    $default_sort = $GLOBALS['xoopsModuleConfig']['adslight_lsort_order'];

    $cid     = ((int)$cid > 0) ? (int)$cid : 0;
    $min     = ((int)$min > 0) ? (int)$min : 0;
    $show    = ((int)$show > 0) ? (int)$show : $GLOBALS['xoopsModuleConfig']['adslight_perpage'];
    $max     = $min + $show;
    $orderby = isset($orderby) ? AdslightUtilities::convertOrderByIn($orderby) : $default_sort;

    $updir = $GLOBALS['xoopsModuleConfig']['adslight_link_upload'];
    $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
    $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
    $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
    $xoopsTpl->assign('subcat_title2', _ADSLIGHT_ANNONCES);

    $categories = AdslightUtilities::getMyItemIds('adslight_view');
    if (is_array($categories) && count($categories) > 0) {
        if (!in_array($cid, $categories)) {
            redirect_header(XOOPS_URL . '/modules/adslight/index.php', 3, _NOPERM);
        }
    } else {    // User can't see any category
        redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
    }

    $arrow = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/arrow.gif" alt="&raquo;" />';

    $pathstring = '<a href="index.php">' . _ADSLIGHT_MAIN . '</a>';
    $pathstring .= $mytree->getNicePathFromId($cid, 'title', 'viewcats.php?');
    $xoopsTpl->assign('module_name', $xoopsModule->getVar('name'));
    $xoopsTpl->assign('category_path', $pathstring);
    $xoopsTpl->assign('category_id', $cid);

    $countresult = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE  cid=' . $xoopsDB->escape($cid) . ' AND valid="Yes" AND status!="1"');
    list($trow) = $xoopsDB->fetchRow($countresult);
    $trows = $trow;

    $cat_perms = '';
    if (is_array($categories) && count($categories) > 0) {
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
    }

    $result = $xoopsDB->query('SELECT cid, pid, title, cat_desc, cat_keywords FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($cid) . ' ' . $cat_perms);
    list($cid, $pid, $title, $cat_desc, $cat_keywords) = $xoopsDB->fetchRow($result);

    $xoopsTpl->assign('cat_desc', $cat_desc);
    $xoopsTpl->assign('cat_title', _ADSLIGHT_ANNONCES . ' ' . $title);
    $xoopsTpl->assign('cat_keywords', $cat_keywords);
    $xoopsTpl->assign('xoops_pagetitle', $title);

    if ($cat_desc > '0') {
        // meta description & keywords tags for categories
        $cat_desc_clean     = strip_tags($cat_desc, '<font><img><strong><i><u>');
        $cat_keywords_clean = strip_tags($cat_keywords, '<font><img><strong><i><u><br><li>');

        $xoTheme->addMeta('meta', 'description', '' . substr($cat_desc_clean, 0, 200));

        $xoTheme->addMeta('meta', 'keywords', '' . substr($cat_keywords_clean, 0, 1000));
    }

    $submit_perms = AdslightUtilities::getMyItemIds('adslight_submit');
    if ($GLOBALS['xoopsUser'] && is_array($submit_perms) && count($submit_perms) > 0) {
        $add_listing = '' . _ADSLIGHT_ADD_LISTING_BULLCATS . '<a href="addlisting.php?cid=' . addslashes($cid) . '">' . _ADSLIGHT_ADD_LISTING_SUBOK . '</a>
';
    } else {    // User can't see any category
        $add_listing = '' . _ADSLIGHT_ADD_LISTING_BULLCATSOK . '<a href="' . XOOPS_URL . '/register.php">' . _ADSLIGHT_ADD_LISTING_SUB . '</a>.
';
    }

    if ($GLOBALS['xoopsModuleConfig']['adslight_main_cat'] == 1 || $pid != 0) {
        $xoopsTpl->assign('bullinfotext', $add_listing);
    }

    $arr = array();
    $arr = $mytree->getFirstChild($cid, 'title');

    if (count($arr) > 0) {
        $scount = 1;
        foreach ($arr as $ele) {
            if (in_array($ele['cid'], $categories)) {
                $sub_arr         = array();
                $sub_arr         = $mytree->getFirstChild($ele['cid'], 'title');
                $space           = 0;
                $chcount         = 0;
                $infercategories = '';
                $totallisting    = AdslightUtilities::getTotalItems($ele['cid'], 1);
                foreach ($sub_arr as $sub_ele) {
                    if (in_array($sub_ele['cid'], $categories)) {
                        $chtitle = $myts->htmlSpecialChars($sub_ele['title']);

                        if ($chcount > 5) {
                            $infercategories .= '...';
                            break;
                        }
                        if ($space > 0) {
                            $infercategories .= ', ';
                        }
                        $infercategories .= '<a href="' . XOOPS_URL . '/modules/adslight/viewcats.php?cid=' . $sub_ele['cid'] . '">' . $chtitle . '</a>';

                        $infercategories .= '&nbsp;(' . AdslightUtilities::getTotalItems($sub_ele['cid']) . ')';
                        $infercategories .= '&nbsp;' . categorynewgraphic($sub_ele['cid']) . '';
                        ++$space;
                        ++$chcount;
                    }
                }

                $xoopsTpl->append('subcategories', array(
                    'title'           => $myts->htmlSpecialChars($ele['title']),
                    'id'              => $ele['cid'],
                    'infercategories' => $infercategories,
                    'totallisting'    => $totallisting,
                    ''
                ));

                ++$scount;
                $xoopsTpl->assign('lang_subcat', _ADSLIGHT_AVAILAB);
            }
        }
    }

    $pagenav = '';
    if ($trows > '0') {
        $xoopsTpl->assign('last_head', _ADSLIGHT_THE . ' ' . $GLOBALS['xoopsModuleConfig']['adslight_newcount'] . ' ' . _ADSLIGHT_LASTADD);
        $xoopsTpl->assign('last_head_title', _ADSLIGHT_TITLE);
        $xoopsTpl->assign('last_head_price', _ADSLIGHT_PRICE);
        $xoopsTpl->assign('last_head_date', _ADSLIGHT_DATE);
        $xoopsTpl->assign('last_head_local', _ADSLIGHT_LOCAL2);
        $xoopsTpl->assign('last_head_hits', _ADSLIGHT_VIEW);
        $xoopsTpl->assign('last_head_photo', _ADSLIGHT_PHOTO);
        $xoopsTpl->assign('cat', $cid);
        $xoopsTpl->assign('min', $min);
        $rank = 1;

        $cat_perms = '';
        if (is_array($categories) && count($categories) > 0) {
            $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
        }

        $sql     = 'SELECT lid, title, status, type, price, typeprice, date, town, country, contactby, usid, premium, valid, photo, hits FROM '
                   . $xoopsDB->prefix('adslight_listing')
                   . ' WHERE valid="Yes" and cid='
                   . $xoopsDB->escape($cid)
                   . ' AND status!="1" '
                   . $cat_perms
                   . ' ORDER BY '
                   . $orderby
                   . '';
        $result1 = $xoopsDB->query($sql, $show, $min);
        if ($trows > '1') {
            $xoopsTpl->assign('show_nav', true);
            $orderbyTrans = AdslightUtilities::convertOrderByTrans($orderby);
            $xoopsTpl->assign('lang_sortby', _ADSLIGHT_SORTBY);
            $xoopsTpl->assign('lang_title', _ADSLIGHT_TITLE);
            $xoopsTpl->assign('lang_titleatoz', _ADSLIGHT_TITLEATOZ);
            $xoopsTpl->assign('lang_titleztoa', _ADSLIGHT_TITLEZTOA);
            $xoopsTpl->assign('lang_date', _ADSLIGHT_DATE);
            $xoopsTpl->assign('lang_dateold', _ADSLIGHT_DATEOLD);
            $xoopsTpl->assign('lang_datenew', _ADSLIGHT_DATENEW);
            $xoopsTpl->assign('lang_price', _ADSLIGHT_PRICE);
            $xoopsTpl->assign('lang_priceltoh', _ADSLIGHT_PRICELTOH);
            $xoopsTpl->assign('lang_pricehtol', _ADSLIGHT_PRICEHTOL);
            $xoopsTpl->assign('lang_popularity', _ADSLIGHT_POPULARITY);
            $xoopsTpl->assign('lang_popularityleast', _ADSLIGHT_POPULARITYLTOM);
            $xoopsTpl->assign('lang_popularitymost', _ADSLIGHT_POPULARITYMTOL);
            $xoopsTpl->assign('lang_cursortedby', sprintf(_ADSLIGHT_CURSORTEDBY, AdslightUtilities::convertOrderByTrans($orderby)));
        }

        while (list($lid, $title, $status, $type, $price, $typeprice, $date, $town, $country, $contactby, $usid, $premium, $valid, $photo, $hits) = $xoopsDB->fetchRow($result1)) {
            $a_item = array();
            $title  = $myts->htmlSpecialChars($title);
            $type   = $myts->htmlSpecialChars($type);
            //      $price = number_format($price, 2, ',', ' ');
            $town       = $myts->htmlSpecialChars($town);
            $country    = $myts->htmlSpecialChars($country);
            $contactby  = $myts->htmlSpecialChars($contactby);
            $useroffset = '';

            $newcount  = $GLOBALS['xoopsModuleConfig']['adslight_countday'];
            $startdate = (time() - (86400 * $newcount));
            if ($startdate < $date) {
                $newitem       = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" />';
                $a_item['new'] = $newitem;
            }
            if ($GLOBALS['xoopsUser']) {
                $timezone = $GLOBALS['xoopsUser']->timezone();
                if (isset($timezone)) {
                    $useroffset = $GLOBALS['xoopsUser']->timezone();
                } else {
                    $useroffset = $xoopsConfig['default_TZ'];
                }
            }
            $date = ($useroffset * 3600) + $date;
            $date = formatTimestamp($date, 's');
            if ($GLOBALS['xoopsUser']) {
                if ($GLOBALS['xoopsUser']->isAdmin()) {
                    $a_item['admin'] = '<a href="'
                                       . XOOPS_URL
                                       . '/modules/adslight/admin/validate_ads.php?op=ModifyAds&amp;lid='
                                       . $lid
                                       . '"><img src="'
                                       . $pathIcon16
                                       . '/edit.png'
                                       . '" border=0 alt="'
                                       . _ADSLIGHT_MODADMIN
                                       . '" title="'
                                       . _ADSLIGHT_MODADMIN
                                       . '"/></a>';
                }
            }

            $result7 = $xoopsDB->query('SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='" . $xoopsDB->escape($type) . "'");
            list($nom_type) = $xoopsDB->fetchRow($result7);

            $result8 = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . " WHERE id_price='" . $xoopsDB->escape($typeprice) . "'");
            list($nom_price) = $xoopsDB->fetchRow($result8);

            $a_item['type']   = $myts->htmlSpecialChars($nom_type);
            $a_item['title']  = '<a href="viewads.php?lid=' . $lid . '"><strong>' . $title . '</strong></a>';
            $a_item['status'] = $status;
            if ($price > 0) {

                //          $a_item['price'] = $price. ' '. $GLOBALS['xoopsModuleConfig']['adslight_money'].'';
                $a_item['price']           = AdslightUtilities::getMoneyFormat('%.2n', $price);
                $a_item['price_typeprice'] = $myts->htmlSpecialChars($nom_price);
            }
            $a_item['date']  = $date;
            $a_item['local'] = '';
            if ($town) {
                $a_item['local'] .= $town;
            }
            $a_item['country'] = '';
            if ($country) {
                $a_item['country'] = $country;
            }

            $cat = addslashes($cid);
            if ($status == 2) {
                $a_item['sold'] = _ADSLIGHT_RESERVEDMEMBER;
            }

            if ($GLOBALS['xoopsModuleConfig']['active_thumbscats'] > 0) {
                $a_item['no_photo'] = '<a href="'
                                      . XOOPS_URL
                                      . '/modules/adslight/viewads.php?lid='
                                      . $lid
                                      . '"><img class="thumb" src="'
                                      . XOOPS_URL
                                      . '/modules/adslight/assets/images/nophoto.jpg" align="left" width="100px" alt="'
                                      . $title
                                      . '" /></a>';

                $updir   = $GLOBALS['xoopsModuleConfig']['adslight_link_upload'];
                $sql     = 'SELECT cod_img, lid, uid_owner, url FROM '
                           . $xoopsDB->prefix('adslight_pictures')
                           . ' WHERE  uid_owner='
                           . $xoopsDB->escape($usid)
                           . ' AND lid='
                           . $xoopsDB->escape($lid)
                           . ' ORDER BY date_added ASC limit 1';
                $resultp = $xoopsDB->query($sql);

                while (list($cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($resultp)) {
                    if ($photo) {
                        $a_item['photo'] = '<a href="'
                                           . XOOPS_URL
                                           . '/modules/adslight/viewads.php?lid='
                                           . $lid
                                           . '"><img class="thumb" src="'
                                           . $updir
                                           . '/thumbs/thumb_'
                                           . $url
                                           . '" align="left" width="100px" alt="'
                                           . $title
                                           . '" /></a>';
                    }
                }
            } else {
                $a_item['no_photo'] = '<p><img src="' . XOOPS_URL . '/modules/adslight/assets/images/camera_nophoto.png" align="left" width="24" alt="' . $title . '" /></p>';
                $updir              = $GLOBALS['xoopsModuleConfig']['adslight_link_upload'];
                $sql                = 'SELECT cod_img, lid, uid_owner, url FROM '
                                      . $xoopsDB->prefix('adslight_pictures')
                                      . ' WHERE  uid_owner='
                                      . $xoopsDB->escape($usid)
                                      . ' AND lid='
                                      . $xoopsDB->escape($lid)
                                      . ' ORDER BY date_added ASC limit 1';
                $resultp            = $xoopsDB->query($sql);
                while (list($cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($resultp)) {
                    if ($photo) {
                        $a_item['photo'] = '<p><img src="' . XOOPS_URL . '/modules/adslight/assets/images/camera_photo.png" align="left" width="24" alt="' . $title . '" /></p>';
                    }
                }
            }

            $a_item['hits'] = $hits;
            ++$rank;
            $xoopsTpl->append('items', $a_item);
        }

        $cid = ((int)$cid > 0) ? (int)$cid : 0;

        $orderby   = AdslightUtilities::convertOrderByOut($orderby);
        $linkpages = ceil($trows / $show);

        //Page Numbering
        if ($linkpages != 1 && $linkpages != 0) {
            $prev = $min - $show;
            if ($prev >= 0) {
                $pagenav .= "<a href='viewcats.php?cid=$cid&min=$prev&orderby=$orderby&show=$show'><strong><u>&laquo;</u></strong></a> ";
            }
            $counter     = 1;
            $currentpage = ($max / $show);
            while ($counter <= $linkpages) {
                $mintemp = ($show * $counter) - $show;
                if ($counter == $currentpage) {
                    $pagenav .= "<strong>($counter)</strong> ";
                } else {
                    $pagenav .= "<a href='viewcats.php?cid=$cid&min=$mintemp&orderby=$orderby&show=$show'>$counter</a> ";
                }
                ++$counter;
            }
            if ($trows > $max) {
                $pagenav .= "<a href='viewcats.php?cid=$cid&min=$max&orderby=$orderby&show=$show'>";
                $pagenav .= '<strong><u>&raquo;</u></strong></a>';
            }
        }
    }

    $xoopsTpl->assign('nav_page', $pagenav);

    if (!$GLOBALS['xoopsUser']) {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $xt   = new XoopsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
        $jump = XOOPS_URL . '/modules/adslight/viewcats.php?cid=';
        ob_start();
        $xt->makeMySelBox('title', 'title', $cid, 1, 'pid', "location=\"" . $jump . "\"+this.options[this.selectedIndex].value");
        $select_go_cats = ob_get_contents();
        ob_end_clean();
        $xoopsTpl->assign('select_go_cats', $select_go_cats);
    }
}

#  function categorynewgraphic
#####################################################
/**
 * @param $cid
 */
function categorynewgraphic($cid)
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
}

######################################################

$pa      = XoopsRequest::getInt('pa', null, 'GET');
$lid     = XoopsRequest::getInt('lid', null, 'GET');
$cid     = XoopsRequest::getInt('cid', null, 'GET');
$usid    = XoopsRequest::getString('usid', '', 'GET');
$min     = XoopsRequest::getInt('min', null, 'GET');
$show    = XoopsRequest::getInt('show', null, 'GET');
$orderby = XoopsRequest::getInt('orderby', null, 'GET');

switch ($pa) {
    default:
        $GLOBALS['xoopsOption']['template_main'] = 'adslight_category.tpl';
        adsView($cid, $min, $orderby, $show);
        break;
}
include XOOPS_ROOT_PATH . '/footer.php';

Push — master ( 67bb37...e20777 )

viewcats.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

mambax7 / adslight

Push — master ( 67bb37...e20777 )

viewcats.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
