Test\WideImage\Mapper\BMPTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testSaveToFile()	0	13	1
A	testLoad()	0	7	1
A	imageProvider()	0	5	1
A	testSaveToString()	0	13	1
A	setup()	0	3	1
A	teardown()	0	3	1

<?php
	/**
    This file is part of WideImage.

    WideImage is free software; you can redistribute it and/or modify
    it under the terms of the GNU Lesser General Public License as published by
    the Free Software Foundation; either version 2.1 of the License, or
    (at your option) any later version.

    WideImage is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public License
    along with WideImage; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA

    * @package Tests
  **/

namespace Test\WideImage\Mapper;

use WideImage\WideImage;
use WideImage\MapperFactory;
use WideImage\vendor\de77;
use Test\WideImage_TestCase;

/**
 * @package Tests
 */
class BMPTest extends WideImage_TestCase
{
	/**
	 * @var WideImage_Mapper_BMP

The type Test\WideImage\Mapper\WideImage_Mapper_BMP was not found. Maybe you did not declare it correctly or list all dependencies?

	 */
	protected $mapper;

	public function setup()
	{
		$this->mapper = MapperFactory::selectMapper(null, 'bmp');

It seems like WideImage\MapperFactory::selectMapper(null, 'bmp') can also be of type false. However, the property $mapper is declared as type Test\WideImage\Mapper\WideImage_Mapper_BMP. Maybe add an additional type check?

	}

	public function teardown()
	{
		$this->mapper = null;
	}

	public function imageProvider()
	{
		return array(
			array(IMG_PATH . 'fgnl.bmp', 174, 287),
			array(IMG_PATH . 'bmp' . DIRECTORY_SEPARATOR . 'favicon.ico', 30, 30)
		);
	}

	/**
	 * @dataProvider imageProvider
	 */
	public function testLoad($image, $width, $height)
	{
		$handle = $this->mapper->load($image);
		$this->assertTrue(WideImage::isValidImageHandle($handle));
		$this->assertEquals($width, imagesx($handle));
		$this->assertEquals($height, imagesy($handle));
		imagedestroy($handle);
	}

	public function testSaveToString()
	{
		$handle = de77\BMP::imagecreatefrombmp(IMG_PATH . 'fgnl.bmp');
		ob_start();
		$this->mapper->save($handle);
		$string = ob_get_clean();
		$this->assertTrue(strlen($string) > 0);
		imagedestroy($handle);

It seems like $handle can also be of type false; however, parameter $image of imagedestroy() does only seem to accept GdImage|resource, maybe add an additional type check?

		// string contains valid image data
		$handle = $this->mapper->loadFromString($string);
		$this->assertTrue(WideImage::isValidImageHandle($handle));
		imagedestroy($handle);
	}

	public function testSaveToFile()
	{
		$handle = imagecreatefromgif(IMG_PATH . '100x100-color-hole.gif');
		$this->mapper->save($handle, IMG_PATH . 'temp' . DIRECTORY_SEPARATOR . 'test.bmp');
		$this->assertTrue(filesize(IMG_PATH . 'temp' . DIRECTORY_SEPARATOR . 'test.bmp') > 0);
		imagedestroy($handle);

		// file is a valid image
		$handle = $this->mapper->load(IMG_PATH . 'temp' . DIRECTORY_SEPARATOR . 'test.bmp');
		$this->assertTrue(WideImage::isValidImageHandle($handle));
		imagedestroy($handle);

		unlink(IMG_PATH . 'temp' . DIRECTORY_SEPARATOR . 'test.bmp');
	}
}