Request

Complexity

Total Complexity

23

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getColor()	0	10	4
A	get()	0	6	2
A	getFloat()	0	7	2
A	getInstance()	0	5	2
A	getInt()	0	7	2
A	set()	0	3	1
A	getRegex()	0	7	3
A	getOption()	0	7	3
A	__construct()	0	3	1
A	getCoordinate()	0	7	3

<?php
	/**
    This file is part of WideImage.
		
    WideImage is free software; you can redistribute it and/or modify
    it under the terms of the GNU Lesser General Public License as published by
    the Free Software Foundation; either version 2.1 of the License, or
    (at your option) any later version.
		
    WideImage is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Lesser General Public License for more details.
		
    You should have received a copy of the GNU Lesser General Public License
    along with WideImage; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  **/
	
	/**
	 * @package Demos
	 */
	class Request
	{
		protected $vars = array();
		
		protected static $instance;
		static function getInstance()
		{
			if (self::$instance === null)
				self::$instance = new Request;
			return self::$instance;
		}
		
		protected function __construct()
		{
			$this->vars = $_GET;
			
			/*
			// have to rely on parsing QUERY_STRING, thanks to PHP
			// http://bugs.php.net/bug.php?id=39078
			// http://bugs.php.net/bug.php?id=45149
			$all_vars = explode('&', $_SERVER['QUERY_STRING']);
			foreach ($all_vars as $keyval)
			{
				if (strlen($keyval) == 0)
					continue;
				
				if (strpos($keyval, '=') === false)
				{
					$key = $keyval;
					$value = true;
				}
				else
				{
					list($key, $value) = explode('=', $keyval);
					#$value = str_replace('%2B', '[[PLUS]]', $value);
					$value = urldecode($value);
					#$value = str_replace('[[PLUS]]', '+', $value);
				}
				$this->vars[$key] = $value;
			}
			*/
		}
		
		function get($key, $default = null)

It is generally recommended to explicitly declare the visibility for methods.

		{
			if (isset($this->vars[$key]))
				return $this->vars[$key];
			else
				return $default;
		}
		
		function set($key, $value)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$this->vars[$key] = $value;
		}
		
		function getInt($key, $default = 0)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$value = self::get($key);

The method Request::get() is not static, but was called statically.

			if (strlen($value) > 0)

It seems like $value can also be of type null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

				return intval($value);
			else
				return $default;
		}
		
		function getFloat($key, $default = 0)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$value = self::get($key);

The method Request::get() is not static, but was called statically.

			if (strlen($value) > 0)

It seems like $value can also be of type null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

				return floatval($value);
			else
				return $default;
		}
		
		function getCoordinate($key, $default = 0)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$v = self::get($key);

The method Request::get() is not static, but was called statically.

			if (strlen($v) > 0 && \WideImage\Coordinate::parse($v) !== null)

It seems like $v can also be of type null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

				return self::get($key);
			else
				return $default;
		}
		
		function getOption($key, $valid = array(), $default = null)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$value = self::get($key);

The method Request::get() is not static, but was called statically.

			if ($value !== null && in_array($value, $valid))
				return strval($value);
			else
				return $default;
		}
		
		function getColor($key, $default = '000000')

It is generally recommended to explicitly declare the visibility for methods.

		{
			$value = self::get($key);

The method Request::get() is not static, but was called statically.

			if (substr($value, 0, 1) == '#')

It seems like $value can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

				$value = substr($value, 1);
			
			if ($value === '' || preg_match('~^[0-9a-f]{1,6}$~i', $value))
				return $value;
			else
				return $default;
		}
		
		function getRegex($key, $regex, $default = null)

It is generally recommended to explicitly declare the visibility for methods.

		{
			$value = self::get($key);

The method Request::get() is not static, but was called statically.

			if ($value !== null && preg_match($regex, $value))
				return $value;
			else
				return $default;
		}
	}