View GitHub Repository XoopsCore25

Schedule Inspection
Subscribe
Passed
Push — master ( 3c6756...8b3b37 )
by Michael
20:43 queued 12:59
created

Demo_resize   A

↳ Parent: Project

Complexity

Total Complexity 2

Size/Duplication

Total Lines 20
Duplicated Lines 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
eloc 11
c 2
b 0
f 0
dl 0
loc 20
rs 10
wmc 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A init() 0 6 1
A execute() 0 8 1
1 
<?php
2 
	/**
3 
	 * @package Demos
4 
	 */
5 
	class Demo_resize extends Demo
6 
	{
7 
		public $order = 900;
8
9 
		function init()
10 
		{
11 
			$this->addField(new CoordinateField('width', 120));
12 
			$this->addField(new CoordinateField('height', null));
13 
			$this->addField(new SelectField('fit', array('inside', 'fill', 'outside')));
14 
			$this->addField(new SelectField('scale', array('any', 'down', 'up')));
15 
		}
16
17 
		function execute($image, $request)
0 ignored issues
– show
Unused Code introduced by
The parameter $request is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

17 
		function execute($image, /** @scrutinizer ignore-unused */ $request)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
18 
		{
19 
			$width = $this->fields['width']->value;
20 
			$height = $this->fields['height']->value;
21 
			$fit = $this->fields['fit']->value;
22 
			$scale = $this->fields['scale']->value;
23
24 
			return $image->resize($width, $height, $fit, $scale);
25 
		}
26 
	}
27