TGA::imagecreatefromstring() - Code Metrics - Inspection of "updates" - mambax7/XoopsCore25 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 247290...01d05f )

by Michael

created 2017-02-02 18:52 UTC

TGA::imagecreatefromstring() D

↳ Parent: TGA

Complexity

Conditions	14
Paths	196

Size

Total Lines	88
Code Lines	52

Duplication

Lines	12
Ratio	13.64 %

Importance

Changes

Metric	Value
cc	14
eloc	52
nc	196
nop	1
dl	12
loc	88
rs	4.6283
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
	/**
##DOC-SIGNATURE##

    This file is part of WideImage.

    WideImage is free software; you can redistribute it and/or modify
    it under the terms of the GNU Lesser General Public License as published by
    the Free Software Foundation; either version 2.1 of the License, or
    (at your option) any later version.

    WideImage is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public License
    along with WideImage; if not, write to the Free Software
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA

    * @package Internal/Mappers
  **/

/**
 * External code for TGA
 *
 * Adapted for use in WideImage. Code used with permission from the original author de77.
 * http://de77.com/php/open-tga-with-php-imagecreatefromtga
 *
 * @author de77
 * @license MIT
 * @version 24.08.2010
 * @url http://de77.com
 *
 * @package Internal/Mappers
 */

namespace WideImage\vendor\de77;

class TGA
{
	public static function rle_decode($data, $datalen)
	{
		$len = strlen($data);

		$out = '';

		$i = 0;
		$k = 0;

		while ($i < $len) {
			static::dec_bits(ord($data[$i]), $type, $value);

			if ($k >= $datalen) {
				break;
			}

			$i++;

			if ($type == 0) { //raw
				for ($j = 0; $j < (3 * $value); $j++) {
					$out .= $data[$j+$i];
					$k++;
				}

				$i += $value * 3;
			} else { //rle
				for ($j = 0; $j < $value; $j++) {
					$out .= $data[$i] . $data[$i+1] . $data[$i+2];
					$k++;
				}

				$i += 3;
			}
		}

		return $out;
	}

	public static function dec_bits($byte, &$type, &$value)
	{
		$type  = ($byte & 0x80) >> 7;
		$value = 1 + ($byte & 0x7F);
	}

	public static function imagecreatefromstring($bin_data)
	{
		if (!trim($bin_data)) {
			return false;
		}

		$bin_pos  = 0;
		$header   = substr($bin_data, $bin_pos, 18);
		$bin_pos += 18;
		$header   = unpack(	"cimage_id_len/ccolor_map_type/cimage_type/vcolor_map_origin/vcolor_map_len/" .
							"ccolor_map_entry_size/vx_origin/vy_origin/vwidth/vheight/" .
							"cpixel_size/cdescriptor", $header);

		switch ($header['image_type']) {
			case 2:		//no palette, uncompressed
			case 10:	//no palette, rle
						break;
			default:	return false;
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}
		}

		if ($header['pixel_size'] != 24) {
			return false;
			//die('Unsupported TGA color depth');
		}

		$bytes = $header['pixel_size'] / 8;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		if ($header['image_id_len'] > 0) {
			$header['image_id'] = substr($bin_data, $bin_pos, $header['image_id_len']);
			$bin_pos += $header['image_id_len'];
		} else {
			$header['image_id'] = '';
		}

		$im = imagecreatetruecolor($header['width'], $header['height']);

		$size = $header['width'] * $header['height'] * 3;

		//-- check whether this is NEW TGA or not
		$pos     = $bin_pos;
		$bin_pos = strlen($bin_data) - 26;
		$newtga  = substr($bin_data, $bin_pos, 26);

		if (substr($newtga, 8, 16) != 'TRUEVISION-XFILE') {
			$newtga = false;
		}

		$bin_pos  = strlen($bin_data);
		$datasize = $bin_pos - $pos;

		if ($newtga) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$datasize -= 26;
		}

		$bin_pos = $pos;

		//-- end of check
		$data     = substr($bin_data, $bin_pos, $datasize);
		$bin_pos += $datasize;

		if ($header['image_type'] == 10) {
			$data = self::rle_decode($data, $size);
		}

		$reverse = self::bit5($header['descriptor']) == 1;
		$pixels  = str_split($data, 3);

		$i = 0;

		//read pixels
		if ($reverse) {
		    for ($y = 0; $y < $header['height']; $y++) {
		    	for ($x = 0; $x < $header['width']; $x++) {
		    		imagesetpixel($im, $x, $y, self::dwordize($pixels[$i]));
		    		$i++;
		    	}
		    }
	    } else {
	        for ($y = $header['height']-1; $y >= 0; $y--) {
		    	for ($x=0; $x<$header['width']; $x++) {
		    		imagesetpixel($im, $x, $y, self::dwordize($pixels[$i]));
		    		$i++;
		    	}
		    }
	    }

		return $im;
	}

	public static function imagecreatefromtga($filename)
	{
		return self::imagecreatefromstring(file_get_contents($filename));
	}

	public static function dwordize($str)
	{
		$a = ord($str[0]);
		$b = ord($str[1]);
		$c = ord($str[2]);

		return $c*256*256 + $b*256 + $a;
	}

	public static function bit5($x)
	{
		return ($x & 32) >> 5;
	}
}


1		<?php
2		/**
3		##DOC-SIGNATURE##
4
5		This file is part of WideImage.
6
7		WideImage is free software; you can redistribute it and/or modify
8		it under the terms of the GNU Lesser General Public License as published by
9		the Free Software Foundation; either version 2.1 of the License, or
10		(at your option) any later version.
11
12		WideImage is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		GNU Lesser General Public License for more details.
16
17		You should have received a copy of the GNU Lesser General Public License
18		along with WideImage; if not, write to the Free Software
19		Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
20
21		* @package Internal/Mappers
22		**/
23
24		/**
25		* External code for TGA
26		*
27		* Adapted for use in WideImage. Code used with permission from the original author de77.
28		* http://de77.com/php/open-tga-with-php-imagecreatefromtga
29		*
30		* @author de77
31		* @license MIT
32		* @version 24.08.2010
33		* @url http://de77.com
34		*
35		* @package Internal/Mappers
36		*/
37
38		namespace WideImage\vendor\de77;
39
40		class TGA
41		{
42		public static function rle_decode($data, $datalen)
43		{
44		$len = strlen($data);
45
46		$out = '';
47
48		$i = 0;
49		$k = 0;
50
51		while ($i < $len) {
52		static::dec_bits(ord($data[$i]), $type, $value);
53
54		if ($k >= $datalen) {
55		break;
56		}
57
58		$i++;
59
60		if ($type == 0) { //raw
61		for ($j = 0; $j < (3 * $value); $j++) {
62		$out .= $data[$j+$i];
63		$k++;
64		}
65
66		$i += $value * 3;
67		} else { //rle
68		for ($j = 0; $j < $value; $j++) {
69		$out .= $data[$i] . $data[$i+1] . $data[$i+2];
70		$k++;
71		}
72
73		$i += 3;
74		}
75		}
76
77		return $out;
78		}
79
80		public static function dec_bits($byte, &$type, &$value)
81		{
82		$type = ($byte & 0x80) >> 7;
83		$value = 1 + ($byte & 0x7F);
84		}
85
86		public static function imagecreatefromstring($bin_data)
87		{
88		if (!trim($bin_data)) {
89		return false;
90		}
91
92		$bin_pos = 0;
93		$header = substr($bin_data, $bin_pos, 18);
94		$bin_pos += 18;
95		$header = unpack( "cimage_id_len/ccolor_map_type/cimage_type/vcolor_map_origin/vcolor_map_len/" .
96		"ccolor_map_entry_size/vx_origin/vy_origin/vwidth/vheight/" .
97		"cpixel_size/cdescriptor", $header);
98
99		switch ($header['image_type']) {
100		case 2: //no palette, uncompressed
101		case 10: //no palette, rle
102		break;
103		default: return false;
		0 ignored issues – show Coding Style introduced 2017-02-02 19:00 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-02-02 19:00 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
104		}
105
106		if ($header['pixel_size'] != 24) {
107		return false;
108		//die('Unsupported TGA color depth');
109		}
110
111		$bytes = $header['pixel_size'] / 8;
		0 ignored issues – show Unused Code introduced 2017-02-02 19:00 UTC by Report Bug Copy Issue Report `$bytes` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
112
113		if ($header['image_id_len'] > 0) {
114		$header['image_id'] = substr($bin_data, $bin_pos, $header['image_id_len']);
115		$bin_pos += $header['image_id_len'];
116		} else {
117		$header['image_id'] = '';
118		}
119
120		$im = imagecreatetruecolor($header['width'], $header['height']);
121
122		$size = $header['width'] * $header['height'] * 3;
123
124		//-- check whether this is NEW TGA or not
125		$pos = $bin_pos;
126		$bin_pos = strlen($bin_data) - 26;
127		$newtga = substr($bin_data, $bin_pos, 26);
128
129		if (substr($newtga, 8, 16) != 'TRUEVISION-XFILE') {
130		$newtga = false;
131		}
132
133		$bin_pos = strlen($bin_data);
134		$datasize = $bin_pos - $pos;
135
136		if ($newtga) {
		0 ignored issues – show Bug Best Practice introduced 2017-02-02 19:00 UTC by Report Bug Copy Issue Report The expression `$newtga` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
137		$datasize -= 26;
138		}
139
140		$bin_pos = $pos;
141
142		//-- end of check
143		$data = substr($bin_data, $bin_pos, $datasize);
144		$bin_pos += $datasize;
145
146		if ($header['image_type'] == 10) {
147		$data = self::rle_decode($data, $size);
148		}
149
150		$reverse = self::bit5($header['descriptor']) == 1;
151		$pixels = str_split($data, 3);
152
153		$i = 0;
154
155		//read pixels
156		if ($reverse) {
157	View Code Duplication	for ($y = 0; $y < $header['height']; $y++) {
158		for ($x = 0; $x < $header['width']; $x++) {
159		imagesetpixel($im, $x, $y, self::dwordize($pixels[$i]));
160		$i++;
161		}
162		}
163		} else {
164	View Code Duplication	for ($y = $header['height']-1; $y >= 0; $y--) {
165		for ($x=0; $x<$header['width']; $x++) {
166		imagesetpixel($im, $x, $y, self::dwordize($pixels[$i]));
167		$i++;
168		}
169		}
170		}
171
172		return $im;
173		}
174
175		public static function imagecreatefromtga($filename)
176		{
177		return self::imagecreatefromstring(file_get_contents($filename));
178		}
179
180		public static function dwordize($str)
181		{
182		$a = ord($str[0]);
183		$b = ord($str[1]);
184		$c = ord($str[2]);
185
186		return $c256256 + $b*256 + $a;
187		}
188
189		public static function bit5($x)
190		{
191		return ($x & 32) >> 5;
192		}
193		}
194

mambax7 / XoopsCore25

Push — master ( 247290...01d05f )

TGA::imagecreatefromstring() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like