mambax7 / XoopsCore25

htdocs/class/logger.php

Spacing +1 added lines, -1 removed lines

@@ -28,4 +28,4 @@
  * Load the new XoopsLogger class
  **/
 require_once $GLOBALS['xoops']->path('class/logger/xoopslogger.php');
-trigger_error('Instance of ' . __FILE__ . " file is deprecated, check 'XoopsLogger' in class/logger/xoopslogger.php");
+trigger_error('Instance of '.__FILE__." file is deprecated, check 'XoopsLogger' in class/logger/xoopslogger.php");

htdocs/class/model/stats.php

Spacing +3 added lines, -3 removed lines

@@ -40,12 +40,12 @@ 
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             if ($criteria->groupby != '') {
                 $groupby = true;
-                $field   = $criteria->groupby . ', ';
+                $field   = $criteria->groupby.', ';
             }
         }
         $sql = "SELECT {$field} COUNT(*) FROM `{$this->handler->table}`";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             $sql .= $criteria->getGroupby();
         }
         $result = $this->handler->db->query($sql);
@@ -87,7 +87,7 @@ 
                 $groupby_key = $groupby;
             }
         }
-        $sql = "SELECT {$groupby_key}, COUNT(*) AS count" . " FROM `{$this->handler->table}`" . " {$sql_where}" . " GROUP BY {$groupby_key}";
+        $sql = "SELECT {$groupby_key}, COUNT(*) AS count"." FROM `{$this->handler->table}`"." {$sql_where}"." GROUP BY {$groupby_key}";
         if (!$result = $this->handler->db->query($sql, $limit, $start)) {
             return $ret;
         }

htdocs/class/model/sync.php

Spacing +3 added lines, -3 removed lines

@@ -58,7 +58,7 @@ 
         }
 
         if (empty($this->handler->field_object) || empty($this->handler->table_link) || empty($this->handler->field_link)) {
-            trigger_error("The link information is not set for '" . get_class($this->handler) . "' yet.", E_USER_WARNING);
+            trigger_error("The link information is not set for '".get_class($this->handler)."' yet.", E_USER_WARNING);
 
             return null;
         }
@@ -67,10 +67,10 @@ 
          * for MySQL 4.1+
          */
         if (version_compare(mysqli_get_server_info($this->handler->db->conn), '4.1.0', 'ge')) {
-            $sql = "DELETE FROM `{$this->handler->table}`" . " WHERE (`{$this->handler->field_object}` NOT IN ( SELECT DISTINCT `{$this->handler->field_link}` FROM `{$this->handler->table_link}`) )";
+            $sql = "DELETE FROM `{$this->handler->table}`"." WHERE (`{$this->handler->field_object}` NOT IN ( SELECT DISTINCT `{$this->handler->field_link}` FROM `{$this->handler->table_link}`) )";
         } else {
             // for 4.0+
-            $sql = "DELETE `{$this->handler->table}` FROM `{$this->handler->table}`" . " LEFT JOIN `{$this->handler->table_link}` AS aa ON `{$this->handler->table}`.`{$this->handler->field_object}` = aa.`{$this->handler->field_link}`" . " WHERE (aa.`{$this->handler->field_link}` IS NULL)";
+            $sql = "DELETE `{$this->handler->table}` FROM `{$this->handler->table}`"." LEFT JOIN `{$this->handler->table_link}` AS aa ON `{$this->handler->table}`.`{$this->handler->field_object}` = aa.`{$this->handler->field_link}`"." WHERE (aa.`{$this->handler->field_link}` IS NULL)";
         }
         if (!$result = $this->handler->db->queryF($sql)) {
             return false;

htdocs/class/model/joint.php

Spacing +14 added lines, -14 removed lines

@@ -80,8 +80,8 @@ 
         }
 
         if (is_array($fields) && count($fields)) {
-            if (!in_array('o.' . $this->handler->keyName, $fields)) {
-                $fields[] = 'o.' . $this->handler->keyName;
+            if (!in_array('o.'.$this->handler->keyName, $fields)) {
+                $fields[] = 'o.'.$this->handler->keyName;
             }
             $select = implode(',', $fields);
         } else {
@@ -90,11 +90,11 @@ 
         $limit = null;
         $start = null;
         // $field_object = empty($field_object) ? $field_link : $field_object;
-        $sql = " SELECT {$select}" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
+        $sql = " SELECT {$select}"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             if ($sort = $criteria->getSort()) {
-                $sql .= " ORDER BY {$sort} " . $criteria->getOrder();
+                $sql .= " ORDER BY {$sort} ".$criteria->getOrder();
                 $orderSet = true;
             }
             $limit = $criteria->getLimit();
@@ -136,9 +136,9 @@ 
             return null;
         }
 
-        $sql = " SELECT COUNT(DISTINCT o.{$this->handler->keyName}) AS count" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
+        $sql = " SELECT COUNT(DISTINCT o.{$this->handler->keyName}) AS count"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
         if (!$result = $this->handler->db->query($sql)) {
             return false;
@@ -159,9 +159,9 @@ 
         if (!$this->validateLinks()) {
             return null;
         }
-        $sql = " SELECT l.{$this->handler->field_link}, COUNT(*)" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
+        $sql = " SELECT l.{$this->handler->field_link}, COUNT(*)"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
         $sql .= " GROUP BY l.{$this->handler->field_link}";
         if (!$result = $this->handler->db->query($sql)) {
@@ -189,11 +189,11 @@ 
         }
         $set = array();
         foreach ($data as $key => $val) {
-            $set[] = "o.{$key}=" . $this->handler->db->quoteString($val);
+            $set[] = "o.{$key}=".$this->handler->db->quoteString($val);
         }
-        $sql = " UPDATE {$this->handler->table} AS o" . ' SET ' . implode(', ', $set) . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
+        $sql = " UPDATE {$this->handler->table} AS o".' SET '.implode(', ', $set)." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
 
         return $this->handler->db->query($sql);
@@ -210,9 +210,9 @@ 
         if (!$this->validateLinks()) {
             return null;
         }
-        $sql = "DELETE FROM {$this->handler->table} AS o " . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
+        $sql = "DELETE FROM {$this->handler->table} AS o "." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
 
         return $this->handler->db->query($sql);

htdocs/class/model/xoopsmodel.php

Spacing +5 added lines, -5 removed lines

@@ -18,7 +18,7 @@ 
  */
 defined('XOOPS_ROOT_PATH') || exit('Restricted access');
 
-include_once XOOPS_ROOT_PATH . '/kernel/object.php';
+include_once XOOPS_ROOT_PATH.'/kernel/object.php';
 
 /**
  * Factory for object handlers
@@ -72,15 +72,15 @@ 
     {
         static $handlers;
         if (!isset($handlers[$name])) {
-            if (file_exists($file = __DIR__ . '/' . $name . '.php')) {
+            if (file_exists($file = __DIR__.'/'.$name.'.php')) {
                 include_once $file;
-                $className = 'XoopsModel' . ucfirst($name);
+                $className = 'XoopsModel'.ucfirst($name);
                 $handler   = new $className();
             } elseif (xoops_load('model', 'framework')) {
                 $handler = XoopsModel::loadHandler($name);
             }
             if (!is_object($handler)) {
-                trigger_error('Handler not found in file ' . __FILE__ . ' at line ' . __LINE__, E_USER_WARNING);
+                trigger_error('Handler not found in file '.__FILE__.' at line '.__LINE__, E_USER_WARNING);
 
                 return null;
             }
@@ -136,7 +136,7 @@ 
     public function setHandler($handler)
     {
         if (is_object($handler) && is_a($handler, 'XoopsPersistableObjectHandler')) {
-            $this->handler =& $handler;
+            $this->handler = & $handler;
 
             return true;
         }

htdocs/class/model/write.php

Spacing +16 added lines, -16 removed lines

@@ -179,7 +179,7 @@ 
                         continue 2;
                     }
                     if ($cleanv != '' && !preg_match("/^http[s]*:\/\//i", $cleanv)) {
-                        $cleanv = XOOPS_PROT . $cleanv;
+                        $cleanv = XOOPS_PROT.$cleanv;
                     }
                     if (!$v['not_gpc']) {
                         $cleanv = $ts->stripSlashesGPC($cleanv);
@@ -193,7 +193,7 @@ 
                         continue 2;
                     }
                     if ($cleanv != '' && !preg_match("/^http[s]*:\/\//i", $cleanv)) {
-                        $cleanv = XOOPS_PROT . $cleanv;
+                        $cleanv = XOOPS_PROT.$cleanv;
                     }
                     if (!$v['not_gpc']) {
                         $cleanv = $ts->stripSlashesGPC($cleanv);
@@ -231,7 +231,7 @@ 
                         $cleanv[$key] = str_replace('\\"', '"', addslashes($cleanv[$key]));
                     }
                     // TODO: Not encoding safe, should try base64_encode -- phppp
-                    $cleanv = "'" . serialize(array_walk($cleanv, 'xoops_aw_encode')) . "'";
+                    $cleanv = "'".serialize(array_walk($cleanv, 'xoops_aw_encode'))."'";
                     break;
 
                 case XOBJ_DTYPE_ARRAY:
@@ -273,25 +273,25 @@ 
     public function insert(&$object, $force = true)
     {
         if (!$object->isDirty()) {
-            trigger_error("Data entry is not inserted - the object '" . get_class($object) . "' is not dirty", E_USER_NOTICE);
+            trigger_error("Data entry is not inserted - the object '".get_class($object)."' is not dirty", E_USER_NOTICE);
 
             return $object->getVar($this->handler->keyName);
         }
         if (!$this->cleanVars($object)) {
-            trigger_error("Insert failed in method 'cleanVars' of object '" . get_class($object) . "'", E_USER_WARNING);
+            trigger_error("Insert failed in method 'cleanVars' of object '".get_class($object)."'", E_USER_WARNING);
 
             return $object->getVar($this->handler->keyName);
         }
         $queryFunc = empty($force) ? 'query' : 'queryF';
 
         if ($object->isNew()) {
-            $sql = 'INSERT INTO `' . $this->handler->table . '`';
+            $sql = 'INSERT INTO `'.$this->handler->table.'`';
             if (!empty($object->cleanVars)) {
                 $keys = array_keys($object->cleanVars);
                 $vals = array_values($object->cleanVars);
-                $sql .= ' (`' . implode('`, `', $keys) . '`) VALUES (' . implode(',', $vals) . ')';
+                $sql .= ' (`'.implode('`, `', $keys).'`) VALUES ('.implode(',', $vals).')';
             } else {
-                trigger_error("Data entry is not inserted - no variable is changed in object of '" . get_class($object) . "'", E_USER_NOTICE);
+                trigger_error("Data entry is not inserted - no variable is changed in object of '".get_class($object)."'", E_USER_NOTICE);
 
                 return $object->getVar($this->handler->keyName);
             }
@@ -306,7 +306,7 @@ 
             foreach ($object->cleanVars as $k => $v) {
                 $keys[] = " `{$k}` = {$v}";
             }
-            $sql = 'UPDATE `' . $this->handler->table . '` SET ' . implode(',', $keys) . ' WHERE `' . $this->handler->keyName . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName));
+            $sql = 'UPDATE `'.$this->handler->table.'` SET '.implode(',', $keys).' WHERE `'.$this->handler->keyName.'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName));
             if (!$result = $this->handler->db->{$queryFunc}($sql)) {
                 return false;
             }
@@ -328,13 +328,13 @@ 
             $clause = array();
             $thishandlerkeyNameCount = count($this->handler->keyName);
             for ($i = 0; $i < $thishandlerkeyNameCount; ++$i) {
-                $clause[] = '`' . $this->handler->keyName[$i] . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName[$i]));
+                $clause[] = '`'.$this->handler->keyName[$i].'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName[$i]));
             }
             $whereclause = implode(' AND ', $clause);
         } else {
-            $whereclause = '`' . $this->handler->keyName . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName));
+            $whereclause = '`'.$this->handler->keyName.'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName));
         }
-        $sql       = 'DELETE FROM `' . $this->handler->table . '` WHERE ' . $whereclause;
+        $sql       = 'DELETE FROM `'.$this->handler->table.'` WHERE '.$whereclause;
         $queryFunc = empty($force) ? 'query' : 'queryF';
         $result    = $this->handler->db->{$queryFunc}($sql);
 
@@ -362,10 +362,10 @@ 
             return $num;
         }
         $queryFunc = empty($force) ? 'query' : 'queryF';
-        $sql       = 'DELETE FROM ' . $this->handler->table;
+        $sql       = 'DELETE FROM '.$this->handler->table;
         if (!empty($criteria)) {
             if (is_subclass_of($criteria, 'criteriaelement')) {
-                $sql .= ' ' . $criteria->renderWhere();
+                $sql .= ' '.$criteria->renderWhere();
             } else {
                 return false;
             }
@@ -396,9 +396,9 @@ 
         } else {
             $set_clause .= $this->handler->db->quote($fieldvalue);
         }
-        $sql = 'UPDATE `' . $this->handler->table . '` SET ' . $set_clause;
+        $sql = 'UPDATE `'.$this->handler->table.'` SET '.$set_clause;
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
         $queryFunc = empty($force) ? 'query' : 'queryF';
         $result    = $this->handler->db->{$queryFunc}($sql);

htdocs/class/model/read.php

Spacing +10 added lines, -10 removed lines

@@ -42,7 +42,7 @@ 
             if (!in_array($this->handler->keyName, $fields)) {
                 $fields[] = $this->handler->keyName;
             }
-            $select = '`' . implode('`, `', $fields) . '`';
+            $select = '`'.implode('`, `', $fields).'`';
         } else {
             $select = '*';
         }
@@ -50,12 +50,12 @@ 
         $start = null;
         $sql   = "SELECT {$select} FROM `{$this->handler->table}`";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             if ($groupby = $criteria->getGroupby()) {
                 $sql .= $groupby;
             }
             if ($sort = $criteria->getSort()) {
-                $sql .= " ORDER BY {$sort} " . $criteria->getOrder();
+                $sql .= " ORDER BY {$sort} ".$criteria->getOrder();
                 $orderSet = true;
             }
             $limit = $criteria->getLimit();
@@ -105,7 +105,7 @@ 
      */
     public function &getObjects(CriteriaElement $criteria = null, $id_as_key = false, $as_object = true)
     {
-        $objects =& $this->getAll($criteria, null, $as_object, $id_as_key);
+        $objects = & $this->getAll($criteria, null, $as_object, $id_as_key);
 
         return $objects;
     }
@@ -131,9 +131,9 @@ 
         }
         $sql .= " FROM `{$this->handler->table}`";
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             if ($sort = $criteria->getSort()) {
-                $sql .= ' ORDER BY ' . $sort . ' ' . $criteria->getOrder();
+                $sql .= ' ORDER BY '.$sort.' '.$criteria->getOrder();
             }
             $limit = $criteria->getLimit();
             $start = $criteria->getStart();
@@ -164,7 +164,7 @@ 
         $sql   = "SELECT `{$this->handler->keyName}` FROM `{$this->handler->table}`";
         $limit = $start = null;
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             $limit = $criteria->getLimit();
             $start = $criteria->getStart();
         }
@@ -192,7 +192,7 @@ 
      */
     public function &getByLimit($limit = 0, $start = 0, CriteriaElement $criteria = null, $fields = null, $asObject = true)
     {
-        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__ . '::' . __FUNCTION__ . '() is deprecated, please use getAll instead.');
+        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__.'::'.__FUNCTION__.'() is deprecated, please use getAll instead.');
         if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
             $criteria->setLimit($limit);
             $criteria->setStart($start);
@@ -216,7 +216,7 @@ 
      */
     public function convertResultSet($result, $id_as_key = false, $as_object = true)
     {
-        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__ . '::' . __FUNCTION__ . '() is deprecated.');
+        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__.'::'.__FUNCTION__.'() is deprecated.');
         $ret = array();
         while (false !== ($myrow = $this->handler->db->fetchArray($result))) {
             $obj = $this->handler->create(false);
@@ -234,7 +234,7 @@ 
                 }
             } else {
                 if ($as_object) {
-                    $ret[$myrow[$this->handler->keyName]] =& $obj;
+                    $ret[$myrow[$this->handler->keyName]] = & $obj;
                 } else {
                     $row  = array();
                     $vars = $obj->getVars();

htdocs/class/xoopseditor/tinymce/formtinymce.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
         $this->configs['area_height'] = isset($this->configs['height']) ? $this->configs['height'] : $this->height;
         $this->configs['fonts']       = $this->getFonts();
 
-        require_once __DIR__ . '/tinymce.php';
+        require_once __DIR__.'/tinymce.php';
         $this->editor = new TinyMCE($this->configs);
     }
 
@@ -137,6 +137,6 @@ 
      */
     public function isActive()
     {
-        return is_readable(XOOPS_ROOT_PATH . $this->rootPath . '/tinymce.php');
+        return is_readable(XOOPS_ROOT_PATH.$this->rootPath.'/tinymce.php');
     }
 }

htdocs/class/xoopseditor/tinymce/tinymce/jscripts/tiny_mce/plugins/xoopsimagemanager/xoopsimagemanager.php

Spacing +6 added lines, -6 removed lines

@@ -18,11 +18,11 @@ 
     $current_path = str_replace(DIRECTORY_SEPARATOR, '/', $current_path);
 }
 $xoops_root_path = substr($current_path, 0, strpos(strtolower($current_path), '/class/xoopseditor/tinymce/'));
-include_once $xoops_root_path . '/mainfile.php';
+include_once $xoops_root_path.'/mainfile.php';
 defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');
 
 // include
-include_once XOOPS_ROOT_PATH . '/modules/system/constants.php';
+include_once XOOPS_ROOT_PATH.'/modules/system/constants.php';
 
 // check user/group
 $admin = false;
@@ -33,13 +33,13 @@ 
 
 // check categories readability/writability by group
 $imgcat_handler = xoops_getHandler('imagecategory');
-$catreadlist    = $imgcat_handler->getList($groups, 'imgcat_read', 1);    // get readable categories
-$catwritelist   = $imgcat_handler->getList($groups, 'imgcat_write', 1);  // get writable categories
+$catreadlist    = $imgcat_handler->getList($groups, 'imgcat_read', 1); // get readable categories
+$catwritelist   = $imgcat_handler->getList($groups, 'imgcat_write', 1); // get writable categories
 
 $canbrowse = ($admin || !empty($catreadlist) || !empty($catwritelist)) ? true : false;
 
 echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">';
-echo '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="' . _LANGCODE . '" lang="' . _LANGCODE . '">';
+echo '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="'._LANGCODE.'" lang="'._LANGCODE.'">';
 ?>
 <head>
     <title>{#xoopsimagemanager_dlg.dialog_title}</title>
@@ -330,7 +330,7 @@ 
     $html = '';
     if ($canbrowse) {
         $html = "<img title=\"{#xoopsimagebrowser.desc}\" class=\"xoopsimagebrowser\" src=\"img/xoopsimagemanager.png\"
-                onclick=\"javascript:XoopsImageBrowser('" . $inputname . "');\" />\n";
+                onclick=\"javascript:XoopsImageBrowser('" . $inputname."');\" />\n";
     }
 
     return $html;