XoopsGuiZetadigme - Code Metrics - Inspection of "Tabs 1.2.7" - mambax7/XoopsCore25 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59d8d3...c14d6b )

by Michael

created 2016-05-29 03:39 UTC

XoopsGuiZetadigme B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	333
Duplicated Lines	22.52 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	75
loc	333
rs	8.3999
c	0
b	0
f	0
wmc	38
lcom	1
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	validate()	0	4	1
A	generateMenu()	0	4	1
F	header()	75	307	35

How to fix Duplicated Code

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.
 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
xoops_load('gui', 'system');

/**
 * Xoops Cpanel Paradigme GUI class
 *
 * @copyright       (c) 2000-2016 XOOPS Project (www.xoops.org)
 * @license             GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package             system
 * @usbpackage          GUI
 * @since               2.4.1
 * @author              Kris <[email protected]>
 */
class XoopsGuiZetadigme extends XoopsSystemGui
{
    /**
     *
     */
    public function __construct()
    {
    }

    /**
     * @return bool
     */
    public static function validate()
    {
        return true;
    }

    /**
     * @return bool
     */
    public function generateMenu()
    {
        return true;
    }

    public function header()
    {
        parent::header();
        global $xoopsConfig, $xoopsUser, $xoopsModule, $xoTheme, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        $tpl =& $this->template;
        $xoTheme->addScript('browse.php?Frameworks/jquery/jquery.js');
        $xoTheme->addScript('', '', '
        startList = function() {
/* currentStyle restricts the Javascript to IE only */
    if (document.all &&
 document.getElementById(nav).currentStyle) {
        var navroot = document.getElementById(nav);
        /* Get all the list items within the menu */
        var lis=navroot.getElementsByTagName("li");
        for (i=0; i<lis.length; i++) {
           /* If the li has another menu level */
            if (lis[i].lastChild.tagName=="ul") {
                /* assign the function to the li */
                 lis[i].onmouseover=function() {
                   /* display the inner menu */
                   this.lastChild.style.display="block";
                }
                lis[i].onmouseout=function() {
                   this.lastChild.style.display="none";
                }
            }
        }
    }
}
window.onload= function(){
    /* pass the function the id of the top level il */
    /* remove one, when only using one menu */
    activateMenu("nav");
    /*activateMenu("vertnav"); */
}
    xoopsOnloadEvent(startList);');
        $tpl->assign('lang_cp', _CPHOME);
        $tpl->assign('system_options', _AD_SYSOPTIONS);
        $tpl->assign('lang_banners', _AM_SYSTEM_BANS);
        $tpl->assign('lang_blocks', _AM_SYSTEM_BLOCKS);
        $tpl->assign('lang_groups', _AM_SYSTEM_ADGS);
        $tpl->assign('lang_images', _AM_SYSTEM_IMAGES);
        $tpl->assign('lang_modules', _AM_SYSTEM_MODULES);
        $tpl->assign('lang_preferences', _AM_SYSTEM_PREF);
        $tpl->assign('lang_smilies', _AM_SYSTEM_SMLS);
        $tpl->assign('lang_ranks', _AM_SYSTEM_RANK);
        $tpl->assign('lang_edituser', _AM_SYSTEM_USER);
        $tpl->assign('lang_mailuser', _AM_SYSTEM_MLUS);
        $tpl->assign('lang_avatars', _AM_SYSTEM_AVATARS);
        $tpl->assign('lang_tpls', _AM_SYSTEM_TPLSETS);
        $tpl->assign('lang_comments', _AM_SYSTEM_COMMENTS);
        $tpl->assign('lang_insmodules', _AD_INSTALLEDMODULES);
        $tpl->assign('xoops_sitename', $xoopsConfig['sitename']);
        //for system overview
        $tpl->assign('lang_overview', _MD_CPANEL_OVERVIEW);
        $tpl->assign('lang_phpextensions', _MD_CPANEL_PHPEXTENSIONS);
        $tpl->assign('lang_about_xoops', _MD_ABOUT);
        $tpl->assign('lang_about_xoops_text', _MD_ABOUT_TEXT);
        $tpl->assign('lang_version', _MD_VERSION);
        $tpl->assign('lang_version_xoops', _MD_VERSION_XOOPS);
        $tpl->assign('lang_version_php', _MD_VERSION_PHP);
        $tpl->assign('lang_version_mysql', _MD_VERSION_MYSQL);
        $tpl->assign('lang_server_api_name', _MD_Server_API);
        $tpl->assign('lang_os', _MD_OS);
        $tpl->assign('lang_xoops_links', _MD_XOOPS_LINKS);
        //start system overview
        $tpl->assign('lang_xoops_version', XOOPS_VERSION);
        $tpl->assign('lang_php_vesion', PHP_VERSION);
        $tpl->assign('lang_mysql_version', mysqli_get_server_info($xoopsDB->conn));
        $tpl->assign('lang_server_api', PHP_SAPI);
        $tpl->assign('lang_os_name', PHP_OS);
//        $tpl->assign('safe_mode', ini_get('safe_mode') ? 'On' : 'Off');
//        $tpl->assign('register_globals', ini_get('register_globals') ? 'On' : 'Off');
//        $tpl->assign('magic_quotes_gpc', ini_get('magic_quotes_gpc') ? 'On' : 'Off');
        $tpl->assign('allow_url_fopen', ini_get('allow_url_fopen') ? 'On' : 'Off');
        $tpl->assign('fsockopen', function_exists('fsockopen') ? 'On' : 'Off');
//        $tpl->assign('allow_call_time_pass_reference', ini_get('allow_call_time_pass_reference') ? 'On' : 'Off');
        $tpl->assign('post_max_size', ini_get('post_max_size'));
        $tpl->assign('max_input_time', ini_get('max_input_time'));
        $tpl->assign('output_buffering', ini_get('output_buffering'));
        $tpl->assign('max_execution_time', ini_get('max_execution_time'));
        $tpl->assign('memory_limit', ini_get('memory_limit'));
        $tpl->assign('file_uploads', ini_get('file_uploads') ? 'On' : 'Off');
        $tpl->assign('upload_max_filesize', ini_get('upload_max_filesize'));
        $tpl->assign('xoops_sitename', $xoopsConfig['sitename']);
        //for xoops links
        $tpl->assign('lang_xoops_xoopsproject', _MD_XOOPSPROJECT);
        $tpl->assign('lang_xoops_localsupport', _MD_LOCALSUPPORT);
        $tpl->assign('lang_xoops_xoopscore', _MD_XOOPSCORE);
        $tpl->assign('lang_xoops_xoopsthems', _MD_XOOPSTHEME);
        $tpl->assign('lang_xoops_xoopswiki', _MD_XOOPSWIKI);
        $tpl->assign('lang_xoops_codesvn', _MD_CODESVN);
        $tpl->assign('lang_xoops_reportbug', _MD_REPORTBUG);
        $tpl->assign('lang_xoops_movetoblue', _MD_MOVETOBLUE);
        $tpl->assign('lang_xoops_movetobluelink', _MD_MOVETOBLUE_LINK);
        // ADD MENU *****************************************
        //Add  CONTROL PANEL  Menu  items
        $menu                = array();
        $menu[0]['link']     = XOOPS_URL;
        $menu[0]['title']    = _YOURHOME;
        $menu[0]['absolute'] = 1;
        $menu[1]['link']     = XOOPS_URL . '/admin.php?xoopsorgnews=1';
        $menu[1]['title']    = 'XOOPS News';
        $menu[1]['absolute'] = 1;
        $menu[1]['icon']     = XOOPS_ADMINTHEME_URL . '/zetadigme/img/xoops.png';
        $menu[2]['link']     = XOOPS_URL . '/user.php?op=logout';
        $menu[2]['title']    = _LOGOUT;
        $menu[2]['absolute'] = 1;
        $menu[2]['icon']     = XOOPS_ADMINTHEME_URL . '/zetadigme/img/logout.png';
        $tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _CPHOME, 'menu' => $menu));
        //add SYSTEM  Menu items
        include __DIR__ . '/menu.php';
        $system_options = $adminmenu;

        foreach (array_keys($adminmenu) as $item) {
            $system_options[$item]['link'] = empty($adminmenu[$item]['absolute']) ? XOOPS_URL . '/modules/system/' . $adminmenu[$item]['link'] : $adminmenu[$item]['link'];
            $system_options[$item]['icon'] = empty($adminmenu[$item]['icon_small']) ? '' : XOOPS_ADMINTHEME_URL . '/zetadigme/' . $adminmenu[$item]['icon_small'];
            unset($system_options[$item]['icon_small']);
        }
        $tpl->append('navitems', array('link' => XOOPS_URL . '/modules/system/admin.php', 'text' => _AD_SYSOPTIONS, 'menu' => $system_options));
        if (empty($xoopsModule) || 'system' === $xoopsModule->getVar('dirname', 'n')) {
            $modpath     = XOOPS_URL . '/admin.php';
            $modname     = _AD_SYSOPTIONS;
            $modid       = 1;
            $moddir      = 'system';
            $mod_options = $adminmenu;
            foreach (array_keys($mod_options) as $item) {
                $mod_options[$item]['link'] = empty($mod_options[$item]['absolute']) ? XOOPS_URL . '/modules/' . $moddir . '/' . $mod_options[$item]['link'] : $mod_options[$item]['link'];
                $mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : XOOPS_ADMINTHEME_URL . '/zetadigme/' . $mod_options[$item]['icon'];
                unset($mod_options[$item]['icon_small']);
            }
        } else {
            $moddir      = $xoopsModule->getVar('dirname', 'n');
            $modpath     = XOOPS_URL . '/modules/' . $moddir;
            $modname     = $xoopsModule->getVar('name');
            $modid       = $xoopsModule->getVar('mid');
            $mod_options = $xoopsModule->getAdminMenu();
            foreach (array_keys($mod_options) as $item) {
                $mod_options[$item]['link'] = empty($mod_options[$item]['absolute']) ? XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['link'] : $mod_options[$item]['link'];
                //$mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['icon'];
                //mb for direct URL access to icons in modules Admin
                $mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : (filter_var($mod_options[$item]['icon'], FILTER_VALIDATE_URL) ? $mod_options[$item]['icon'] : (XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['icon']));
            }
        }
        $tpl->assign('mod_options', $mod_options);
        $tpl->assign('modpath', $modpath);
        $tpl->assign('modname', $modname);
        $tpl->assign('modid', $modid);
        $tpl->assign('moddir', $moddir);
        // add MODULES  Menu items
        $module_handler = xoops_getHandler('module');
        $criteria       = new CriteriaCompo();
        $criteria->add(new Criteria('hasadmin', 1));
        $criteria->add(new Criteria('isactive', 1));
        $criteria->setSort('mid');
        $mods               = $module_handler->getObjects($criteria);
        $menu               = array();
        $moduleperm_handler = xoops_getHandler('groupperm');
        foreach ($mods as $mod) {
            $rtn        = array();
            $modOptions = array();                                                         //add for sub menus
            $sadmin     = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
            if ($sadmin) {
                $info = $mod->getInfo();
                if (!empty($info['adminindex'])) {
                    $rtn['link'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['adminindex'];
                } else {
                    $rtn['link'] = XOOPS_URL . '/modules/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=' . $mod->getVar('mid');
                }
                $rtn['title']    = $mod->name();
                $rtn['absolute'] = 1;
                $rtn['url']      = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/'; //add for sub menus
                $modOptions      = $mod->getAdminMenu();                                        //add for sub menus
                $rtn['options']  = $modOptions;                                             //add for sub menus

                if (isset($info['icon']) && $info['icon'] !== '') {
                    $rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['icon'];
                }
                $menu[] = $rtn;
            }
        }
        $tpl->append('navitems', array(
            'link' => XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin',
            'text' => _AM_SYSTEM_MODULES,
            'dir'  => $mod->getVar('dirname', 'n'),
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            'menu' => $menu));

        // add preferences menu
        $menu   = array();
        $OPT    = array();
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=1',
            'title'    => _THEME_GENERAL,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=2',
            'title'    => _THEME_USERSETTINGS,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=3',
            'title'    => _THEME_METAFOOTER,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=4',
            'title'    => _THEME_CENSOR,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=5',
            'title'    => _THEME_SEARCH,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=6',
            'title'    => _THEME_MAILER,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=show&amp;confcat_id=7',
            'title'    => _THEME_AUTHENTICATION,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $OPT[]  = array(
            'link'     => 'admin.php?fct=preferences&amp;op=showmod&amp;mod=1',
            'title'    => _THEME_MODULESETTINGS,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
        $menu[] = array(
            'link'     => XOOPS_URL . '/modules/system/admin.php?fct=preferences',
            'title'    => _AD_SYSOPTIONS,
            'absolute' => 1,
            'url'      => XOOPS_URL . '/modules/system/',
            'options'  => $OPT);

        foreach ($mods as $mod) {
            $rtn    = array();
            $sadmin = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
            if ($sadmin && ($mod->getVar('hasnotification') || is_array($mod->getInfo('config')) || is_array($mod->getInfo('comments')))) {
                $rtn['link']     = XOOPS_URL . '/modules/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=' . $mod->getVar('mid');
                $rtn['title']    = $mod->name();
                $rtn['absolute'] = 1;
                $menu[]          = $rtn;
            }
            //$menu[] = $rtn;
        }
        $tpl->append('navitems', array(
            'link' => XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin',
            'text' => _THEME_SITEPREF,
            'dir'  => $mod->getVar('dirname', 'n'),
            'menu' => $menu));
        //add OPTIONS/Links Menu Items
        $menu   = array();
        $menu[] = array(
            'link'     => 'http://www.xoops.org',
            'title'    => 'XOOPS',
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/xoops.png');
        $menu[] = array(
            'link'     => 'http://www.xoops.org/modules/library/',
            'title'    => _AD_XOOPSTHEMES,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/tweb.png');
        $menu[] = array(
            'link'     => 'http://www.xoops.org/modules/repository/',
            'title'    => _AD_XOOPSMODULES,
            'absolute' => 1,
            'icon'     => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/xoops.png');
        $menu[] = array(
            'link'     => 'http://xoops.org',
            'title'    => 'XOOPS',
            'absolute' => 1);
        $tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _AD_INTERESTSITES, 'menu' => $menu));
        //add OPTIONS/links for local support
        if (file_exists($file = XOOPS_ADMINTHEME_PATH . '/zetadigme/language/' . $xoopsConfig['language'] . '/localsupport.php')) {
            $links = include XOOPS_ADMINTHEME_PATH . '/zetadigme/language/' . $xoopsConfig['language'] . '/localsupport.php';
            if (count($links) > 0) {
                $tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _AD_LOCALSUPPORT, 'menu' => $links));
            }
        }
        if (is_object($xoopsModule) || !empty($_GET['xoopsorgnews'])) {
            return null;
        }
        foreach ($mods as $mod) {
            $rtn                = array();
            $moduleperm_handler = xoops_getHandler('groupperm');
            $sadmin             = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
            if ($sadmin) {
                $info = $mod->getInfo();
                if (!empty($info['adminindex'])) {
                    $rtn['link'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['adminindex'];
                } else {
                    $rtn['link'] = XOOPS_URL . '/modules/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=' . $mod->getVar('mid');
                }
                $rtn['title']        = $mod->getVar('name');
                $rtn ['description'] = $mod->getInfo('description');
                $rtn['absolute']     = 1;
                if (isset($info['icon_big'])) {
                    $rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['icon_big'];
                } elseif (isset($info['image'])) {
                    $rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['image'];
                }
            }
            $tpl->append('modules', $rtn);
        }
    }
}


Push — master ( 59d8d3...c14d6b )

XoopsGuiZetadigme B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-07 04:50 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 10. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6		This program is distributed in the hope that it will be useful,
7		but WITHOUT ANY WARRANTY; without even the implied warranty of
8		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
9		*/
10		xoops_load('gui', 'system');
11
12		/**
13		* Xoops Cpanel Paradigme GUI class
14		*
15		* @copyright (c) 2000-2016 XOOPS Project (www.xoops.org)
16		* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
17		* @package system
18		* @usbpackage GUI
19		* @since 2.4.1
20		* @author Kris <[email protected]>
21		*/
22		class XoopsGuiZetadigme extends XoopsSystemGui
23		{
24		/**
25		*
26		*/
27		public function __construct()
28		{
29		}
30
31		/**
32		* @return bool
33		*/
34		public static function validate()
35		{
36		return true;
37		}
38
39		/**
40		* @return bool
41		*/
42		public function generateMenu()
43		{
44		return true;
45		}
46
47		public function header()
48		{
49		parent::header();
50		global $xoopsConfig, $xoopsUser, $xoopsModule, $xoTheme, $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-03-07 04:50 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
51		$tpl =& $this->template;
52		$xoTheme->addScript('browse.php?Frameworks/jquery/jquery.js');
53		$xoTheme->addScript('', '', '
54		startList = function() {
55		/* currentStyle restricts the Javascript to IE only */
56		if (document.all &&
57		document.getElementById(nav).currentStyle) {
58		var navroot = document.getElementById(nav);
59		/* Get all the list items within the menu */
60		var lis=navroot.getElementsByTagName("li");
61		for (i=0; i<lis.length; i++) {
62		/* If the li has another menu level */
63		if (lis[i].lastChild.tagName=="ul") {
64		/* assign the function to the li */
65		lis[i].onmouseover=function() {
66		/* display the inner menu */
67		this.lastChild.style.display="block";
68		}
69		lis[i].onmouseout=function() {
70		this.lastChild.style.display="none";
71		}
72		}
73		}
74		}
75		}
76		window.onload= function(){
77		/* pass the function the id of the top level il */
78		/* remove one, when only using one menu */
79		activateMenu("nav");
80		/activateMenu("vertnav"); /
81		}
82		xoopsOnloadEvent(startList);');
83		$tpl->assign('lang_cp', _CPHOME);
84		$tpl->assign('system_options', _AD_SYSOPTIONS);
85		$tpl->assign('lang_banners', _AM_SYSTEM_BANS);
86		$tpl->assign('lang_blocks', _AM_SYSTEM_BLOCKS);
87		$tpl->assign('lang_groups', _AM_SYSTEM_ADGS);
88		$tpl->assign('lang_images', _AM_SYSTEM_IMAGES);
89		$tpl->assign('lang_modules', _AM_SYSTEM_MODULES);
90		$tpl->assign('lang_preferences', _AM_SYSTEM_PREF);
91		$tpl->assign('lang_smilies', _AM_SYSTEM_SMLS);
92		$tpl->assign('lang_ranks', _AM_SYSTEM_RANK);
93		$tpl->assign('lang_edituser', _AM_SYSTEM_USER);
94		$tpl->assign('lang_mailuser', _AM_SYSTEM_MLUS);
95		$tpl->assign('lang_avatars', _AM_SYSTEM_AVATARS);
96		$tpl->assign('lang_tpls', _AM_SYSTEM_TPLSETS);
97		$tpl->assign('lang_comments', _AM_SYSTEM_COMMENTS);
98		$tpl->assign('lang_insmodules', _AD_INSTALLEDMODULES);
99		$tpl->assign('xoops_sitename', $xoopsConfig['sitename']);
100		//for system overview
101		$tpl->assign('lang_overview', _MD_CPANEL_OVERVIEW);
102		$tpl->assign('lang_phpextensions', _MD_CPANEL_PHPEXTENSIONS);
103		$tpl->assign('lang_about_xoops', _MD_ABOUT);
104		$tpl->assign('lang_about_xoops_text', _MD_ABOUT_TEXT);
105		$tpl->assign('lang_version', _MD_VERSION);
106		$tpl->assign('lang_version_xoops', _MD_VERSION_XOOPS);
107		$tpl->assign('lang_version_php', _MD_VERSION_PHP);
108		$tpl->assign('lang_version_mysql', _MD_VERSION_MYSQL);
109		$tpl->assign('lang_server_api_name', _MD_Server_API);
110		$tpl->assign('lang_os', _MD_OS);
111		$tpl->assign('lang_xoops_links', _MD_XOOPS_LINKS);
112		//start system overview
113		$tpl->assign('lang_xoops_version', XOOPS_VERSION);
114		$tpl->assign('lang_php_vesion', PHP_VERSION);
115		$tpl->assign('lang_mysql_version', mysqli_get_server_info($xoopsDB->conn));
116		$tpl->assign('lang_server_api', PHP_SAPI);
117		$tpl->assign('lang_os_name', PHP_OS);
118		// $tpl->assign('safe_mode', ini_get('safe_mode') ? 'On' : 'Off');
119		// $tpl->assign('register_globals', ini_get('register_globals') ? 'On' : 'Off');
120		// $tpl->assign('magic_quotes_gpc', ini_get('magic_quotes_gpc') ? 'On' : 'Off');
121		$tpl->assign('allow_url_fopen', ini_get('allow_url_fopen') ? 'On' : 'Off');
122		$tpl->assign('fsockopen', function_exists('fsockopen') ? 'On' : 'Off');
123		// $tpl->assign('allow_call_time_pass_reference', ini_get('allow_call_time_pass_reference') ? 'On' : 'Off');
124		$tpl->assign('post_max_size', ini_get('post_max_size'));
125		$tpl->assign('max_input_time', ini_get('max_input_time'));
126		$tpl->assign('output_buffering', ini_get('output_buffering'));
127		$tpl->assign('max_execution_time', ini_get('max_execution_time'));
128		$tpl->assign('memory_limit', ini_get('memory_limit'));
129		$tpl->assign('file_uploads', ini_get('file_uploads') ? 'On' : 'Off');
130		$tpl->assign('upload_max_filesize', ini_get('upload_max_filesize'));
131		$tpl->assign('xoops_sitename', $xoopsConfig['sitename']);
132		//for xoops links
133		$tpl->assign('lang_xoops_xoopsproject', _MD_XOOPSPROJECT);
134		$tpl->assign('lang_xoops_localsupport', _MD_LOCALSUPPORT);
135		$tpl->assign('lang_xoops_xoopscore', _MD_XOOPSCORE);
136		$tpl->assign('lang_xoops_xoopsthems', _MD_XOOPSTHEME);
137		$tpl->assign('lang_xoops_xoopswiki', _MD_XOOPSWIKI);
138		$tpl->assign('lang_xoops_codesvn', _MD_CODESVN);
139		$tpl->assign('lang_xoops_reportbug', _MD_REPORTBUG);
140		$tpl->assign('lang_xoops_movetoblue', _MD_MOVETOBLUE);
141		$tpl->assign('lang_xoops_movetobluelink', _MD_MOVETOBLUE_LINK);
142		// ADD MENU *****************************************
143		//Add CONTROL PANEL Menu items
144		$menu = array();
145		$menu[0]['link'] = XOOPS_URL;
146		$menu[0]['title'] = _YOURHOME;
147		$menu[0]['absolute'] = 1;
148		$menu[1]['link'] = XOOPS_URL . '/admin.php?xoopsorgnews=1';
149		$menu[1]['title'] = 'XOOPS News';
150		$menu[1]['absolute'] = 1;
151		$menu[1]['icon'] = XOOPS_ADMINTHEME_URL . '/zetadigme/img/xoops.png';
152		$menu[2]['link'] = XOOPS_URL . '/user.php?op=logout';
153		$menu[2]['title'] = _LOGOUT;
154		$menu[2]['absolute'] = 1;
155		$menu[2]['icon'] = XOOPS_ADMINTHEME_URL . '/zetadigme/img/logout.png';
156		$tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _CPHOME, 'menu' => $menu));
157		//add SYSTEM Menu items
158		include __DIR__ . '/menu.php';
159		$system_options = $adminmenu;
		0 ignored issues – show Bug introduced 2016-03-07 04:50 UTC by Report Bug Copy Issue Report The variable `$adminmenu` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
160		foreach (array_keys($adminmenu) as $item) {
161		$system_options[$item]['link'] = empty($adminmenu[$item]['absolute']) ? XOOPS_URL . '/modules/system/' . $adminmenu[$item]['link'] : $adminmenu[$item]['link'];
162		$system_options[$item]['icon'] = empty($adminmenu[$item]['icon_small']) ? '' : XOOPS_ADMINTHEME_URL . '/zetadigme/' . $adminmenu[$item]['icon_small'];
163		unset($system_options[$item]['icon_small']);
164		}
165		$tpl->append('navitems', array('link' => XOOPS_URL . '/modules/system/admin.php', 'text' => _AD_SYSOPTIONS, 'menu' => $system_options));
166	View Code Duplication	if (empty($xoopsModule) \|\| 'system' === $xoopsModule->getVar('dirname', 'n')) {
167		$modpath = XOOPS_URL . '/admin.php';
168		$modname = _AD_SYSOPTIONS;
169		$modid = 1;
170		$moddir = 'system';
171		$mod_options = $adminmenu;
172		foreach (array_keys($mod_options) as $item) {
173		$mod_options[$item]['link'] = empty($mod_options[$item]['absolute']) ? XOOPS_URL . '/modules/' . $moddir . '/' . $mod_options[$item]['link'] : $mod_options[$item]['link'];
174		$mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : XOOPS_ADMINTHEME_URL . '/zetadigme/' . $mod_options[$item]['icon'];
175		unset($mod_options[$item]['icon_small']);
176		}
177		} else {
178		$moddir = $xoopsModule->getVar('dirname', 'n');
179		$modpath = XOOPS_URL . '/modules/' . $moddir;
180		$modname = $xoopsModule->getVar('name');
181		$modid = $xoopsModule->getVar('mid');
182		$mod_options = $xoopsModule->getAdminMenu();
183		foreach (array_keys($mod_options) as $item) {
184		$mod_options[$item]['link'] = empty($mod_options[$item]['absolute']) ? XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['link'] : $mod_options[$item]['link'];
185		//$mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['icon'];
186		//mb for direct URL access to icons in modules Admin
187		$mod_options[$item]['icon'] = empty($mod_options[$item]['icon']) ? '' : (filter_var($mod_options[$item]['icon'], FILTER_VALIDATE_URL) ? $mod_options[$item]['icon'] : (XOOPS_URL . "/modules/{$moddir}/" . $mod_options[$item]['icon']));
188		}
189		}
190		$tpl->assign('mod_options', $mod_options);
191		$tpl->assign('modpath', $modpath);
192		$tpl->assign('modname', $modname);
193		$tpl->assign('modid', $modid);
194		$tpl->assign('moddir', $moddir);
195		// add MODULES Menu items
196		$module_handler = xoops_getHandler('module');
197		$criteria = new CriteriaCompo();
198		$criteria->add(new Criteria('hasadmin', 1));
199		$criteria->add(new Criteria('isactive', 1));
200		$criteria->setSort('mid');
201		$mods = $module_handler->getObjects($criteria);
202		$menu = array();
203		$moduleperm_handler = xoops_getHandler('groupperm');
204	View Code Duplication	foreach ($mods as $mod) {
205		$rtn = array();
206		$modOptions = array(); //add for sub menus
207		$sadmin = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
208		if ($sadmin) {
209		$info = $mod->getInfo();
210		if (!empty($info['adminindex'])) {
211		$rtn['link'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['adminindex'];
212		} else {
213		$rtn['link'] = XOOPS_URL . '/modules/system/admin.php?fct=preferences&op=showmod&mod=' . $mod->getVar('mid');
214		}
215		$rtn['title'] = $mod->name();
216		$rtn['absolute'] = 1;
217		$rtn['url'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/'; //add for sub menus
218		$modOptions = $mod->getAdminMenu(); //add for sub menus
219		$rtn['options'] = $modOptions; //add for sub menus
220
221		if (isset($info['icon']) && $info['icon'] !== '') {
222		$rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['icon'];
223		}
224		$menu[] = $rtn;
225		}
226		}
227		$tpl->append('navitems', array(
228		'link' => XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin',
229		'text' => _AM_SYSTEM_MODULES,
230		'dir' => $mod->getVar('dirname', 'n'),
		0 ignored issues – show Bug introduced 2016-03-07 04:50 UTC by Report Bug Copy Issue Report The variable `$mod` seems to be defined by a `foreach` iteration on line `204`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
231		'menu' => $menu));
232
233		// add preferences menu
234		$menu = array();
235		$OPT = array();
236		$OPT[] = array(
237		'link' => 'admin.php?fct=preferences&op=show&confcat_id=1',
238		'title' => _THEME_GENERAL,
239		'absolute' => 1,
240		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
241		$OPT[] = array(
242		'link' => 'admin.php?fct=preferences&op=show&confcat_id=2',
243		'title' => _THEME_USERSETTINGS,
244		'absolute' => 1,
245		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
246		$OPT[] = array(
247		'link' => 'admin.php?fct=preferences&op=show&confcat_id=3',
248		'title' => _THEME_METAFOOTER,
249		'absolute' => 1,
250		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
251		$OPT[] = array(
252		'link' => 'admin.php?fct=preferences&op=show&confcat_id=4',
253		'title' => _THEME_CENSOR,
254		'absolute' => 1,
255		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
256		$OPT[] = array(
257		'link' => 'admin.php?fct=preferences&op=show&confcat_id=5',
258		'title' => _THEME_SEARCH,
259		'absolute' => 1,
260		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
261		$OPT[] = array(
262		'link' => 'admin.php?fct=preferences&op=show&confcat_id=6',
263		'title' => _THEME_MAILER,
264		'absolute' => 1,
265		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
266		$OPT[] = array(
267		'link' => 'admin.php?fct=preferences&op=show&confcat_id=7',
268		'title' => _THEME_AUTHENTICATION,
269		'absolute' => 1,
270		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
271		$OPT[] = array(
272		'link' => 'admin.php?fct=preferences&op=showmod&mod=1',
273		'title' => _THEME_MODULESETTINGS,
274		'absolute' => 1,
275		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/prefs_small.png');
276		$menu[] = array(
277		'link' => XOOPS_URL . '/modules/system/admin.php?fct=preferences',
278		'title' => _AD_SYSOPTIONS,
279		'absolute' => 1,
280		'url' => XOOPS_URL . '/modules/system/',
281		'options' => $OPT);
282
283		foreach ($mods as $mod) {
284		$rtn = array();
285		$sadmin = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
286		if ($sadmin && ($mod->getVar('hasnotification') \|\| is_array($mod->getInfo('config')) \|\| is_array($mod->getInfo('comments')))) {
287		$rtn['link'] = XOOPS_URL . '/modules/system/admin.php?fct=preferences&op=showmod&mod=' . $mod->getVar('mid');
288		$rtn['title'] = $mod->name();
289		$rtn['absolute'] = 1;
290		$menu[] = $rtn;
291		}
292		//$menu[] = $rtn;
293		}
294		$tpl->append('navitems', array(
295		'link' => XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin',
296		'text' => _THEME_SITEPREF,
297		'dir' => $mod->getVar('dirname', 'n'),
298		'menu' => $menu));
299		//add OPTIONS/Links Menu Items
300		$menu = array();
301		$menu[] = array(
302		'link' => 'http://www.xoops.org',
303		'title' => 'XOOPS',
304		'absolute' => 1,
305		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/xoops.png');
306		$menu[] = array(
307		'link' => 'http://www.xoops.org/modules/library/',
308		'title' => _AD_XOOPSTHEMES,
309		'absolute' => 1,
310		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/tweb.png');
311		$menu[] = array(
312		'link' => 'http://www.xoops.org/modules/repository/',
313		'title' => _AD_XOOPSMODULES,
314		'absolute' => 1,
315		'icon' => XOOPS_ADMINTHEME_URL . '/zetadigme/icons/xoops.png');
316		$menu[] = array(
317		'link' => 'http://xoops.org',
318		'title' => 'XOOPS',
319		'absolute' => 1);
320		$tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _AD_INTERESTSITES, 'menu' => $menu));
321		//add OPTIONS/links for local support
322	View Code Duplication	if (file_exists($file = XOOPS_ADMINTHEME_PATH . '/zetadigme/language/' . $xoopsConfig['language'] . '/localsupport.php')) {
323		$links = include XOOPS_ADMINTHEME_PATH . '/zetadigme/language/' . $xoopsConfig['language'] . '/localsupport.php';
324		if (count($links) > 0) {
325		$tpl->append('navitems', array('link' => XOOPS_URL . '/admin.php', 'text' => _AD_LOCALSUPPORT, 'menu' => $links));
326		}
327		}
328		if (is_object($xoopsModule) \|\| !empty($_GET['xoopsorgnews'])) {
329		return null;
330		}
331	View Code Duplication	foreach ($mods as $mod) {
332		$rtn = array();
333		$moduleperm_handler = xoops_getHandler('groupperm');
334		$sadmin = $moduleperm_handler->checkRight('module_admin', $mod->getVar('mid'), $xoopsUser->getGroups());
335		if ($sadmin) {
336		$info = $mod->getInfo();
337		if (!empty($info['adminindex'])) {
338		$rtn['link'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['adminindex'];
339		} else {
340		$rtn['link'] = XOOPS_URL . '/modules/system/admin.php?fct=preferences&op=showmod&mod=' . $mod->getVar('mid');
341		}
342		$rtn['title'] = $mod->getVar('name');
343		$rtn ['description'] = $mod->getInfo('description');
344		$rtn['absolute'] = 1;
345		if (isset($info['icon_big'])) {
346		$rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['icon_big'];
347		} elseif (isset($info['image'])) {
348		$rtn['icon'] = XOOPS_URL . '/modules/' . $mod->getVar('dirname', 'n') . '/' . $info['image'];
349		}
350		}
351		$tpl->append('modules', $rtn);
352		}
353		}
354		}
355

mambax7 / XoopsCore25

Push — master ( 59d8d3...c14d6b )

XoopsGuiZetadigme B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like