View GitHub Repository XoopsCore25

Schedule Inspection
Subscribe

Code Duplication    Length = 11-13 lines in 2 locations

htdocs/modules/system/admin/modulesadmin/modulesadmin.php 2 locations

@@ 1323-1333 (lines=11) @@
1320 
    $msgs .= xoops_module_log_header($module, _AM_SYSTEM_MODULES_ACTIVATE);
1321 
    // Change value
1322 
    $module->setVar('isactive', 1);
1323 
    if (!$module_handler->insert($module)) {
1324 
        $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_FAILACT, '<strong>' . $module->getVar('name', 's') . '</strong>') . '&nbsp;' . _AM_SYSTEM_MODULES_ERRORSC . '<br>' . $module->getHtmlErrors() . '</p>';
1325 
    } else {
1326 
        $blocks = XoopsBlock::getByModule($module->getVar('mid'));
1327 
        $bcount = count($blocks);
1328 
        for ($i = 0; $i < $bcount; ++$i) {
1329 
            $blocks[$i]->setVar('isactive', 1);
1330 
            $blocks[$i]->store();
1331 
        }
1332 
        $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_OKACT, '<strong>' . $module->getVar('name', 's') . '</strong>') . '</p></div>';
1333 
    }
1334 
    //$msgs[] = '</div>';
1335 
    $msgs[] = '<div class="center"><a href="admin.php?fct=modulesadmin">' . _AM_SYSTEM_MODULES_BTOMADMIN . '</a></div>';
1336 
    $ret    = implode('<br>', $msgs);
@@ 1364-1376 (lines=13) @@
1361 
        $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_FAILDEACT, '<strong>' . $module->getVar('name') . '</strong>') . '&nbsp;' . _AM_SYSTEM_MODULES_ERRORSC . '<br> - ' . _AM_SYSTEM_MODULES_SYSNO . '</p>';
1362 
    } elseif ($module->getVar('dirname') == $xoopsConfig['startpage']) {
1363 
        $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_FAILDEACT, '<strong>' . $module->getVar('name') . '</strong>') . '&nbsp;' . _AM_SYSTEM_MODULES_ERRORSC . '<br> - ' . _AM_SYSTEM_MODULES_STRTNO . '</p>';
1364 
    } else {
1365 
        if (!$module_handler->insert($module)) {
1366 
            $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_FAILDEACT, '<strong>' . $module->getVar('name') . '</strong>') . '&nbsp;' . _AM_SYSTEM_MODULES_ERRORSC . '<br>' . $module->getHtmlErrors() . '</p>';
1367 
        } else {
1368 
            $blocks = XoopsBlock::getByModule($module->getVar('mid'));
1369 
            $bcount = count($blocks);
1370 
            for ($i = 0; $i < $bcount; ++$i) {
1371 
                $blocks[$i]->setVar('isactive', 0);
1372 
                $blocks[$i]->store();
1373 
            }
1374 
            $msgs[] = '<p>' . sprintf(_AM_SYSTEM_MODULES_OKDEACT, '<strong>' . $module->getVar('name') . '</strong>') . '</p>';
1375 
        }
1376 
    }
1377 
    $msgs[] = '<div class="center"><a href="admin.php?fct=modulesadmin">' . _AM_SYSTEM_MODULES_BTOMADMIN . '</a></div>';
1378 
    $ret    = implode('<br>', $msgs);
1379