mambax7 /
XoopsCore25
| Conditions | 45 |
| Paths | > 20000 |
| Total Lines | 250 |
| Code Lines | 191 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | function profile_getFieldForm(ProfileField $field, $action = false) |
||
| 31 | { |
||
| 32 | if ($action === false) { |
||
| 33 | $action = $_SERVER['REQUEST_URI']; |
||
| 34 | } |
||
| 35 | $title = $field->isNew() ? sprintf(_PROFILE_AM_ADD, _PROFILE_AM_FIELD) : sprintf(_PROFILE_AM_EDIT, _PROFILE_AM_FIELD); |
||
| 36 | |||
| 37 | include_once $GLOBALS['xoops']->path('class/xoopsformloader.php'); |
||
| 38 | $form = new XoopsThemeForm($title, 'form', $action, 'post', true); |
||
| 39 | |||
| 40 | $form->addElement(new XoopsFormText(_PROFILE_AM_TITLE, 'field_title', 35, 255, $field->getVar('field_title', 'e'))); |
||
| 41 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DESCRIPTION, 'field_description', $field->getVar('field_description', 'e'))); |
||
| 42 | |||
| 43 | $fieldcat_id = 0; |
||
| 44 | if (!$field->isNew()) { |
||
| 45 | $fieldcat_id = $field->getVar('cat_id'); |
||
| 46 | } |
||
| 47 | $category_handler = xoops_getModuleHandler('category'); |
||
| 48 | $cat_select = new XoopsFormSelect(_PROFILE_AM_CATEGORY, 'field_category', $fieldcat_id); |
||
| 49 | $cat_select->addOption(0, _PROFILE_AM_DEFAULT); |
||
| 50 | $cat_select->addOptionArray($category_handler->getList()); |
||
|
Bug
introduced
by
|
|||
| 51 | $form->addElement($cat_select); |
||
| 52 | $form->addElement(new XoopsFormText(_PROFILE_AM_WEIGHT, 'field_weight', 10, 10, $field->getVar('field_weight', 'e'))); |
||
| 53 | if ($field->getVar('field_config') || $field->isNew()) { |
||
| 54 | if (!$field->isNew()) { |
||
| 55 | $form->addElement(new XoopsFormLabel(_PROFILE_AM_NAME, $field->getVar('field_name'))); |
||
| 56 | $form->addElement(new XoopsFormHidden('id', $field->getVar('field_id'))); |
||
| 57 | } else { |
||
| 58 | $form->addElement(new XoopsFormText(_PROFILE_AM_NAME, 'field_name', 35, 255, $field->getVar('field_name', 'e'))); |
||
| 59 | } |
||
| 60 | |||
| 61 | //autotext and theme left out of this one as fields of that type should never be changed (valid assumption, I think) |
||
| 62 | $fieldtypes = [ |
||
| 63 | 'checkbox' => _PROFILE_AM_CHECKBOX, |
||
| 64 | 'date' => _PROFILE_AM_DATE, |
||
| 65 | 'datetime' => _PROFILE_AM_DATETIME, |
||
| 66 | 'longdate' => _PROFILE_AM_LONGDATE, |
||
| 67 | 'group' => _PROFILE_AM_GROUP, |
||
| 68 | 'group_multi' => _PROFILE_AM_GROUPMULTI, |
||
| 69 | 'language' => _PROFILE_AM_LANGUAGE, |
||
| 70 | 'radio' => _PROFILE_AM_RADIO, |
||
| 71 | 'select' => _PROFILE_AM_SELECT, |
||
| 72 | 'select_multi' => _PROFILE_AM_SELECTMULTI, |
||
| 73 | 'textarea' => _PROFILE_AM_TEXTAREA, |
||
| 74 | 'dhtml' => _PROFILE_AM_DHTMLTEXTAREA, |
||
| 75 | 'textbox' => _PROFILE_AM_TEXTBOX, |
||
| 76 | 'timezone' => _PROFILE_AM_TIMEZONE, |
||
| 77 | 'yesno' => _PROFILE_AM_YESNO, |
||
| 78 | ]; |
||
| 79 | |||
| 80 | $element_select = new XoopsFormSelect(_PROFILE_AM_TYPE, 'field_type', $field->getVar('field_type', 'e')); |
||
| 81 | $element_select->addOptionArray($fieldtypes); |
||
| 82 | |||
| 83 | $form->addElement($element_select); |
||
| 84 | |||
| 85 | switch ($field->getVar('field_type')) { |
||
| 86 | case 'textbox': |
||
| 87 | $valuetypes = [ |
||
| 88 | XOBJ_DTYPE_TXTBOX => _PROFILE_AM_TXTBOX, |
||
| 89 | XOBJ_DTYPE_EMAIL => _PROFILE_AM_EMAIL, |
||
| 90 | XOBJ_DTYPE_INT => _PROFILE_AM_INT, |
||
| 91 | XOBJ_DTYPE_FLOAT => _PROFILE_AM_FLOAT, |
||
| 92 | XOBJ_DTYPE_DECIMAL => _PROFILE_AM_DECIMAL, |
||
| 93 | XOBJ_DTYPE_TXTAREA => _PROFILE_AM_TXTAREA, |
||
| 94 | XOBJ_DTYPE_URL => _PROFILE_AM_URL, |
||
| 95 | XOBJ_DTYPE_OTHER => _PROFILE_AM_OTHER, |
||
| 96 | XOBJ_DTYPE_ARRAY => _PROFILE_AM_ARRAY, |
||
| 97 | XOBJ_DTYPE_UNICODE_ARRAY => _PROFILE_AM_UNICODE_ARRAY, |
||
| 98 | XOBJ_DTYPE_UNICODE_TXTBOX => _PROFILE_AM_UNICODE_TXTBOX, |
||
| 99 | XOBJ_DTYPE_UNICODE_TXTAREA => _PROFILE_AM_UNICODE_TXTAREA, |
||
| 100 | XOBJ_DTYPE_UNICODE_EMAIL => _PROFILE_AM_UNICODE_EMAIL, |
||
| 101 | XOBJ_DTYPE_UNICODE_URL => _PROFILE_AM_UNICODE_URL, |
||
| 102 | ]; |
||
| 103 | |||
| 104 | $type_select = new XoopsFormSelect(_PROFILE_AM_VALUETYPE, 'field_valuetype', $field->getVar('field_valuetype', 'e')); |
||
| 105 | $type_select->addOptionArray($valuetypes); |
||
| 106 | $form->addElement($type_select); |
||
| 107 | break; |
||
| 108 | |||
| 109 | case 'select': |
||
| 110 | case 'radio': |
||
| 111 | $valuetypes = [ |
||
| 112 | XOBJ_DTYPE_TXTBOX => _PROFILE_AM_TXTBOX, |
||
| 113 | XOBJ_DTYPE_EMAIL => _PROFILE_AM_EMAIL, |
||
| 114 | XOBJ_DTYPE_INT => _PROFILE_AM_INT, |
||
| 115 | XOBJ_DTYPE_FLOAT => _PROFILE_AM_FLOAT, |
||
| 116 | XOBJ_DTYPE_DECIMAL => _PROFILE_AM_DECIMAL, |
||
| 117 | XOBJ_DTYPE_TXTAREA => _PROFILE_AM_TXTAREA, |
||
| 118 | XOBJ_DTYPE_URL => _PROFILE_AM_URL, |
||
| 119 | XOBJ_DTYPE_OTHER => _PROFILE_AM_OTHER, |
||
| 120 | XOBJ_DTYPE_ARRAY => _PROFILE_AM_ARRAY, |
||
| 121 | XOBJ_DTYPE_UNICODE_ARRAY => _PROFILE_AM_UNICODE_ARRAY, |
||
| 122 | XOBJ_DTYPE_UNICODE_TXTBOX => _PROFILE_AM_UNICODE_TXTBOX, |
||
| 123 | XOBJ_DTYPE_UNICODE_TXTAREA => _PROFILE_AM_UNICODE_TXTAREA, |
||
| 124 | XOBJ_DTYPE_UNICODE_EMAIL => _PROFILE_AM_UNICODE_EMAIL, |
||
| 125 | XOBJ_DTYPE_UNICODE_URL => _PROFILE_AM_UNICODE_URL, |
||
| 126 | ]; |
||
| 127 | |||
| 128 | $type_select = new XoopsFormSelect(_PROFILE_AM_VALUETYPE, 'field_valuetype', $field->getVar('field_valuetype', 'e')); |
||
| 129 | $type_select->addOptionArray($valuetypes); |
||
| 130 | $form->addElement($type_select); |
||
| 131 | break; |
||
| 132 | } |
||
| 133 | |||
| 134 | //$form->addElement(new XoopsFormRadioYN(_PROFILE_AM_NOTNULL, 'field_notnull', $field->getVar('field_notnull', 'e') )); |
||
| 135 | |||
| 136 | if ($field->getVar('field_type') === 'select' || $field->getVar('field_type') === 'select_multi' || $field->getVar('field_type') === 'radio' || $field->getVar('field_type') === 'checkbox') { |
||
| 137 | $options = $field->getVar('field_options'); |
||
| 138 | if (count($options) > 0) { |
||
| 139 | $remove_options = new XoopsFormCheckBox(_PROFILE_AM_REMOVEOPTIONS, 'removeOptions'); |
||
| 140 | $remove_options->columns = 3; |
||
| 141 | asort($options); |
||
| 142 | foreach (array_keys($options) as $key) { |
||
| 143 | $options[$key] .= "[{$key}]"; |
||
| 144 | } |
||
| 145 | $remove_options->addOptionArray($options); |
||
| 146 | $form->addElement($remove_options); |
||
| 147 | } |
||
| 148 | |||
| 149 | $option_text = "<table cellspacing='1'><tr><td class='width20'>" . _PROFILE_AM_KEY . '</td><td>' . _PROFILE_AM_VALUE . '</td></tr>'; |
||
| 150 | for ($i = 0; $i < 3; ++$i) { |
||
| 151 | $option_text .= "<tr><td><input type='text' name='addOption[{$i}][key]' id='addOption[{$i}][key]' size='15' /></td><td><input type='text' name='addOption[{$i}][value]' id='addOption[{$i}][value]' size='35' /></td></tr>"; |
||
| 152 | $option_text .= "<tr height='3px'><td colspan='2'> </td></tr>"; |
||
| 153 | } |
||
| 154 | $option_text .= '</table>'; |
||
| 155 | $form->addElement(new XoopsFormLabel(_PROFILE_AM_ADDOPTION, $option_text)); |
||
| 156 | } |
||
| 157 | } |
||
| 158 | |||
| 159 | if ($field->getVar('field_edit')) { |
||
| 160 | switch ($field->getVar('field_type')) { |
||
| 161 | case 'textbox': |
||
| 162 | case 'textarea': |
||
| 163 | case 'dhtml': |
||
| 164 | $form->addElement(new XoopsFormText(_PROFILE_AM_MAXLENGTH, 'field_maxlength', 35, 35, $field->getVar('field_maxlength', 'e'))); |
||
| 165 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 166 | break; |
||
| 167 | |||
| 168 | case 'checkbox': |
||
| 169 | case 'select_multi': |
||
| 170 | $def_value = $field->getVar('field_default', 'e') != null ? unserialize($field->getVar('field_default', 'n')) : null; |
||
| 171 | $element = new XoopsFormSelect(_PROFILE_AM_DEFAULT, 'field_default', $def_value, 8, true); |
||
| 172 | $options = $field->getVar('field_options'); |
||
| 173 | asort($options); |
||
| 174 | // If options do not include an empty element, then add a blank option to prevent any default selection |
||
| 175 | // if (!in_array('', array_keys($options))) { |
||
| 176 | if (!array_key_exists('', $options)) { |
||
| 177 | $element->addOption('', _NONE); |
||
| 178 | } |
||
| 179 | $element->addOptionArray($options); |
||
| 180 | $form->addElement($element); |
||
| 181 | break; |
||
| 182 | |||
| 183 | case 'select': |
||
| 184 | case 'radio': |
||
| 185 | $def_value = $field->getVar('field_default', 'e') != null ? $field->getVar('field_default') : null; |
||
| 186 | $element = new XoopsFormSelect(_PROFILE_AM_DEFAULT, 'field_default', $def_value); |
||
| 187 | $options = $field->getVar('field_options'); |
||
| 188 | asort($options); |
||
| 189 | // If options do not include an empty element, then add a blank option to prevent any default selection |
||
| 190 | // if (!in_array('', array_keys($options))) { |
||
| 191 | if (!array_key_exists('', $options)) { |
||
| 192 | $element->addOption('', _NONE); |
||
| 193 | } |
||
| 194 | $element->addOptionArray($options); |
||
| 195 | $form->addElement($element); |
||
| 196 | break; |
||
| 197 | |||
| 198 | case 'date': |
||
| 199 | $form->addElement(new XoopsFormTextDateSelect(_PROFILE_AM_DEFAULT, 'field_default', 15, $field->getVar('field_default', 'e'))); |
||
| 200 | break; |
||
| 201 | |||
| 202 | case 'longdate': |
||
| 203 | $form->addElement(new XoopsFormTextDateSelect(_PROFILE_AM_DEFAULT, 'field_default', 15, strtotime($field->getVar('field_default', 'e')))); |
||
| 204 | break; |
||
| 205 | |||
| 206 | case 'datetime': |
||
| 207 | $form->addElement(new XoopsFormDateTime(_PROFILE_AM_DEFAULT, 'field_default', 15, $field->getVar('field_default', 'e'))); |
||
| 208 | break; |
||
| 209 | |||
| 210 | case 'yesno': |
||
| 211 | $form->addElement(new XoopsFormRadioYN(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 212 | break; |
||
| 213 | |||
| 214 | case 'timezone': |
||
| 215 | $form->addElement(new XoopsFormSelectTimezone(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 216 | break; |
||
| 217 | |||
| 218 | case 'language': |
||
| 219 | $form->addElement(new XoopsFormSelectLang(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 220 | break; |
||
| 221 | |||
| 222 | case 'group': |
||
| 223 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_DEFAULT, 'field_default', true, $field->getVar('field_default', 'e'))); |
||
| 224 | break; |
||
| 225 | |||
| 226 | case 'group_multi': |
||
| 227 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_DEFAULT, 'field_default', true, unserialize($field->getVar('field_default', 'n')), 5, true)); |
||
| 228 | break; |
||
| 229 | |||
| 230 | case 'theme': |
||
| 231 | $form->addElement(new XoopsFormSelectTheme(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 232 | break; |
||
| 233 | |||
| 234 | case 'autotext': |
||
| 235 | $form->addElement(new XoopsFormTextArea(_PROFILE_AM_DEFAULT, 'field_default', $field->getVar('field_default', 'e'))); |
||
| 236 | break; |
||
| 237 | } |
||
| 238 | } |
||
| 239 | /** @var XoopsGroupPermHandler $groupperm_handler */ |
||
| 240 | $groupperm_handler = xoops_getHandler('groupperm'); |
||
| 241 | $searchable_types = [ |
||
| 242 | 'textbox', |
||
| 243 | 'select', |
||
| 244 | 'radio', |
||
| 245 | 'yesno', |
||
| 246 | 'date', |
||
| 247 | 'datetime', |
||
| 248 | 'timezone', |
||
| 249 | 'language', |
||
| 250 | ]; |
||
| 251 | if (in_array($field->getVar('field_type'), $searchable_types)) { |
||
| 252 | $search_groups = $groupperm_handler->getGroupIds('profile_search', $field->getVar('field_id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 253 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_PROF_SEARCH, 'profile_search', true, $search_groups, 5, true)); |
||
| 254 | } |
||
| 255 | if ($field->getVar('field_edit') || $field->isNew()) { |
||
| 256 | $editable_groups = []; |
||
| 257 | if (!$field->isNew()) { |
||
| 258 | //Load groups |
||
| 259 | $editable_groups = $groupperm_handler->getGroupIds('profile_edit', $field->getVar('field_id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 260 | } |
||
| 261 | $form->addElement(new XoopsFormSelectGroup(_PROFILE_AM_PROF_EDITABLE, 'profile_edit', false, $editable_groups, 5, true)); |
||
| 262 | $form->addElement(new XoopsFormRadioYN(_PROFILE_AM_REQUIRED, 'field_required', $field->getVar('field_required', 'e'))); |
||
| 263 | $regstep_select = new XoopsFormSelect(_PROFILE_AM_PROF_REGISTER, 'step_id', $field->getVar('step_id', 'e')); |
||
| 264 | $regstep_select->addOption(0, _NO); |
||
| 265 | $regstep_handler = xoops_getModuleHandler('regstep'); |
||
| 266 | $regstep_select->addOptionArray($regstep_handler->getList()); |
||
| 267 | $form->addElement($regstep_select); |
||
| 268 | } |
||
| 269 | $form->addElement(new XoopsFormHidden('op', 'save')); |
||
| 270 | $form->addElement(new XoopsFormButton('', 'submit', _SUBMIT, 'submit')); |
||
| 271 | |||
| 272 | $options = $field->getVar('field_options'); |
||
| 273 | if (count($options) > 0) { |
||
| 274 | $linkText = defined('_PROFILE_AM_EDIT_OPTION_STRINGS') ? _PROFILE_AM_EDIT_OPTION_STRINGS : 'Edit Option Strings'; |
||
| 275 | $editOptionsButton = new XoopsFormLabel('', '<a href="' . $action . '&op=edit-option-strings"><i class="fa-solid fa-2x fa-language" aria-hidden="true"></i> ' . $linkText . '</a>'); |
||
| 276 | $form->addElement($editOptionsButton); |
||
| 277 | } |
||
| 278 | |||
| 279 | return $form; |
||
| 280 | } |
||
| 607 |
Loading history...
