easytests.api.v1.controllers.QuestionsController - Code Metrics - Inspection of "Delete method for Questions" - malinink/easy-tests - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — dev (#392)

unknown

created 2018-05-25 14:39 UTC

easytests.api.v1.controllers.QuestionsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
c	1
b	0
f	0
dl	0
loc	52
rs	10

3 Methods

Rating	Name	Size	Complexity
A	getQuestionModel(Integer,QuestionsOptionsInterface)	6	2
A	delete(Integer)	13	3
A	getQuestionModel(Integer)	2	1

package easytests.api.v1.controllers;

import easytests.api.v1.exceptions.*;
import easytests.api.v1.mappers.QuestionsMapper;
import easytests.core.models.QuestionModelInterface;
import easytests.core.options.QuestionsOptionsInterface;
import easytests.core.options.builder.QuestionsOptionsBuilderInterface;
import easytests.core.services.QuestionsService;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.web.bind.annotation.*;

/**
 * @author RisaMagpie
 */
@RestController("QuestionControllerV1")
@SuppressWarnings("checkstyle:MultipleStringLiterals")
@RequestMapping("/v1/questions")
public class QuestionsController extends AbstractController {

    @Autowired
    protected QuestionsService questionsService;

    @Autowired
    protected QuestionsOptionsBuilderInterface questionsOptionsBuilder;

    @Autowired
    @Qualifier("QuestionsMapperV1")
    private QuestionsMapper questionsMapper;

    /**
     * list
     */
    /**
     * create
     */
    /**
     * update
     */
    /**
     * show(questionId)
     */
    @DeleteMapping("/{questionId}")
    public void delete(@PathVariable Integer questionId) throws NotFoundException, ForbiddenException {
        final QuestionModelInterface questionModel = this.getQuestionModel(questionId);

        if (questionModel == null) {

            throw new NotFoundException();
        }

        if (!this.acl.hasAccess(questionModel)) {
            throw new ForbiddenException();
        }

        this.questionsService.delete(questionModel);
    }

    private QuestionModelInterface getQuestionModel(Integer id, QuestionsOptionsInterface questionOptions) throws NotFoundException {
        final QuestionModelInterface questionModel = this.questionsService.find(id, questionOptions);
        if (questionModel == null) {
            throw new NotFoundException();
        }
        return questionModel;
    }

    private QuestionModelInterface getQuestionModel(Integer id) throws NotFoundException {
        return this.getQuestionModel(id, this.questionsOptionsBuilder.forDelete());
    }

}


1			package easytests.api.v1.controllers;
2
3			import easytests.api.v1.exceptions.*;
4			import easytests.api.v1.mappers.QuestionsMapper;
5			import easytests.core.models.QuestionModelInterface;
6			import easytests.core.options.QuestionsOptionsInterface;
7			import easytests.core.options.builder.QuestionsOptionsBuilderInterface;
8			import easytests.core.services.QuestionsService;
9			import org.springframework.beans.factory.annotation.Autowired;
10			import org.springframework.beans.factory.annotation.Qualifier;
11			import org.springframework.web.bind.annotation.*;
12
13			/**
14			* @author RisaMagpie
15			*/
16			@RestController("QuestionControllerV1")
17			@SuppressWarnings("checkstyle:MultipleStringLiterals")
18			@RequestMapping("/v1/questions")
19			public class QuestionsController extends AbstractController {
20
21			@Autowired
22			protected QuestionsService questionsService;
23
24			@Autowired
25			protected QuestionsOptionsBuilderInterface questionsOptionsBuilder;
26
27			@Autowired
28			@Qualifier("QuestionsMapperV1")
29			private QuestionsMapper questionsMapper;
30
31			/**
32			* list
33			*/
34			/**
35			* create
36			*/
37			/**
38			* update
39			*/
40			/**
41			* show(questionId)
42			*/
43			@DeleteMapping("/{questionId}")
44			public void delete(@PathVariable Integer questionId) throws NotFoundException, ForbiddenException {
45			final QuestionModelInterface questionModel = this.getQuestionModel(questionId);
46
47			if (questionModel == null) {
			0 ignored issues – show Bug introduced 2018-05-25 14:44 UTC by Report Bug Copy Issue Report This condition always evaluates to false. Consider refactoring your code to no longer check for it or rewrite the condition. Loading history...
48			throw new NotFoundException();
49			}
50
51			if (!this.acl.hasAccess(questionModel)) {
52			throw new ForbiddenException();
53			}
54
55			this.questionsService.delete(questionModel);
56			}
57
58			private QuestionModelInterface getQuestionModel(Integer id, QuestionsOptionsInterface questionOptions) throws NotFoundException {
59			final QuestionModelInterface questionModel = this.questionsService.find(id, questionOptions);
60			if (questionModel == null) {
61			throw new NotFoundException();
62			}
63			return questionModel;
64			}
65
66			private QuestionModelInterface getQuestionModel(Integer id) throws NotFoundException {
67			return this.getQuestionModel(id, this.questionsOptionsBuilder.forDelete());
68			}
69
70			}
71

malinink / easy-tests

Pull Request — dev (#392)

easytests.api.v1.controllers.QuestionsController A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like