easytests.api.v1.controllers.TopicsController - Code Metrics - Inspection of "Create method for TopicsController" - malinink/easy-tests - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#395)

unknown

created 2018-05-28 19:32 UTC

easytests.api.v1.controllers.TopicsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
c	1
b	0
f	0
dl	0
loc	86
rs	10

6 Methods

Rating	Name	Size	Complexity
A	list(Integer)	20	3
	show	12	?
A	checkSubject(Topic)	6	2
A	create(Topic)	14	2
	checkSubject	6	?
A	show(Integer)	12	3

package easytests.api.v1.controllers;

import easytests.api.v1.exceptions.BadRequestException;
import easytests.api.v1.exceptions.ForbiddenException;
import easytests.api.v1.exceptions.IdentifiedModelException;
import easytests.api.v1.exceptions.NotFoundException;
import easytests.api.v1.mappers.TopicsMapper;
import easytests.api.v1.models.Identity;
import easytests.api.v1.models.Topic;
import easytests.core.models.SubjectModelInterface;
import easytests.core.models.TopicModel;
import easytests.core.models.TopicModelInterface;
import easytests.core.options.builder.SubjectsOptionsBuilder;
import easytests.core.services.SubjectsServiceInterface;
import easytests.core.services.TopicsServiceInterface;
import java.util.List;
import java.util.stream.Collectors;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.http.HttpStatus;
import org.springframework.web.bind.annotation.*;


/**
 * @author lelay
 */
@RestController("TopicsControllerV1")
@SuppressWarnings("checkstyle:MultipleStringLiterals")
@RequestMapping("/v1/topics")
public class TopicsController extends AbstractController {

    @Autowired
    protected SubjectsOptionsBuilder subjectsOptionsBuilder;

    @Autowired
    protected TopicsServiceInterface topicsService;

    @Autowired
    protected SubjectsServiceInterface subjectsService;

    @Autowired
    @Qualifier("TopicsMapperV1")
    private TopicsMapper topicsMapper;

    @GetMapping("")
    public List<Topic> list(@RequestParam(name = "subjectId", required = true) Integer subjectId)
            throws NotFoundException, ForbiddenException {
        final SubjectModelInterface subjectModel = this.subjectsService.find(subjectId);

        if (subjectModel == null) {
            throw new NotFoundException();
        }

        if (!this.acl.hasAccess(subjectModel)) {
            throw new ForbiddenException();
        }

        final List<TopicModelInterface> topicsModels =
                this.topicsService.findBySubject(subjectModel);

        return topicsModels
                .stream()
                .map(model -> this.topicsMapper.map(model, Topic.class))
                .collect(Collectors.toList());
    }

    /**
     * create
     */

    @PostMapping("")
    @ResponseStatus(HttpStatus.CREATED)
    public Identity create(@RequestBody Topic topic) throws Exception {

        if (topic.getId() != null) {
            throw new IdentifiedModelException();
        }

        this.checkSubject(topic);

        final TopicModelInterface topicModel = this.topicsMapper.map(topic, TopicModel.class);

        this.topicsService.save(topicModel);

        return this.topicsMapper.map(topicModel, Identity.class);
    }

    private void checkSubject(Topic topic) throws BadRequestException {
        final SubjectModelInterface subjectModel = this.subjectsService.find(
                topic.getSubject().getId(),
                this.subjectsOptionsBuilder.forAuth()
                                );
        if (!this.acl.hasAccess(subjectModel)) {
            throw new BadRequestException();
        }

    }

    /**
     * update
     */
    @GetMapping("/{topicId}")
    public Topic show(@PathVariable Integer topicId) throws NotFoundException, ForbiddenException {
        final TopicModelInterface topicModel = this.topicsService.find(topicId);

        if (topicModel == null) {
            throw new NotFoundException();
        }

        if (!this.acl.hasAccess(topicModel)) {
            throw new ForbiddenException();
        }
        return this.topicsMapper.map(topicModel, Topic.class);
    }

    /**
     * delete(topicId)
     */
}


1			package easytests.api.v1.controllers;
2
3			import easytests.api.v1.exceptions.BadRequestException;
4			import easytests.api.v1.exceptions.ForbiddenException;
5			import easytests.api.v1.exceptions.IdentifiedModelException;
6			import easytests.api.v1.exceptions.NotFoundException;
7			import easytests.api.v1.mappers.TopicsMapper;
8			import easytests.api.v1.models.Identity;
9			import easytests.api.v1.models.Topic;
10			import easytests.core.models.SubjectModelInterface;
11			import easytests.core.models.TopicModel;
12			import easytests.core.models.TopicModelInterface;
13			import easytests.core.options.builder.SubjectsOptionsBuilder;
14			import easytests.core.services.SubjectsServiceInterface;
15			import easytests.core.services.TopicsServiceInterface;
16			import java.util.List;
17			import java.util.stream.Collectors;
18			import org.springframework.beans.factory.annotation.Autowired;
19			import org.springframework.beans.factory.annotation.Qualifier;
20			import org.springframework.http.HttpStatus;
21			import org.springframework.web.bind.annotation.*;
22
23
24			/**
25			* @author lelay
26			*/
27			@RestController("TopicsControllerV1")
28			@SuppressWarnings("checkstyle:MultipleStringLiterals")
29			@RequestMapping("/v1/topics")
30			public class TopicsController extends AbstractController {
31
32			@Autowired
33			protected SubjectsOptionsBuilder subjectsOptionsBuilder;
34
35			@Autowired
36			protected TopicsServiceInterface topicsService;
37
38			@Autowired
39			protected SubjectsServiceInterface subjectsService;
40
41			@Autowired
42			@Qualifier("TopicsMapperV1")
43			private TopicsMapper topicsMapper;
44
45			@GetMapping("")
46			public List<Topic> list(@RequestParam(name = "subjectId", required = true) Integer subjectId)
47			throws NotFoundException, ForbiddenException {
48			final SubjectModelInterface subjectModel = this.subjectsService.find(subjectId);
49
50			if (subjectModel == null) {
51			throw new NotFoundException();
52			}
53
54			if (!this.acl.hasAccess(subjectModel)) {
55			throw new ForbiddenException();
56			}
57
58			final List<TopicModelInterface> topicsModels =
59			this.topicsService.findBySubject(subjectModel);
60
61			return topicsModels
62			.stream()
63			.map(model -> this.topicsMapper.map(model, Topic.class))
64			.collect(Collectors.toList());
65			}
66
67			/**
68			* create
69			*/
70
71			@PostMapping("")
72			@ResponseStatus(HttpStatus.CREATED)
73			public Identity create(@RequestBody Topic topic) throws Exception {
			0 ignored issues – show Best Practice introduced 2018-04-15 19:14 UTC by Report Bug Copy Issue Report Dedicated exceptions should be preferred over throwing the generic Exception. Loading history...
74			if (topic.getId() != null) {
75			throw new IdentifiedModelException();
76			}
77
78			this.checkSubject(topic);
79
80			final TopicModelInterface topicModel = this.topicsMapper.map(topic, TopicModel.class);
81
82			this.topicsService.save(topicModel);
83
84			return this.topicsMapper.map(topicModel, Identity.class);
85			}
86
87			private void checkSubject(Topic topic) throws BadRequestException {
88			final SubjectModelInterface subjectModel = this.subjectsService.find(
89			topic.getSubject().getId(),
90			this.subjectsOptionsBuilder.forAuth()
91			);
92			if (!this.acl.hasAccess(subjectModel)) {
93			throw new BadRequestException();
94			}
95
96			}
97
98			/**
99			* update
100			*/
101			@GetMapping("/{topicId}")
102			public Topic show(@PathVariable Integer topicId) throws NotFoundException, ForbiddenException {
103			final TopicModelInterface topicModel = this.topicsService.find(topicId);
104
105			if (topicModel == null) {
106			throw new NotFoundException();
107			}
108
109			if (!this.acl.hasAccess(topicModel)) {
110			throw new ForbiddenException();
111			}
112			return this.topicsMapper.map(topicModel, Topic.class);
113			}
114
115			/**
116			* delete(topicId)
117			*/
118			}
119

malinink / easy-tests

Pull Request — dev (#395)

easytests.api.v1.controllers.TopicsController A

Complexity

Size/Duplication

Importance

6 Methods

Duplication Side-by-Side

Filter issues like