easytests.personal.controllers.QuestionsController - Code Metrics - malinink/easy-tests - Measure and Improve Code Quality continuously with Scrutinizer

easytests.personal.controllers.QuestionsController A
last analyzed 2018-03-30 20:09 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	188
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
dl	0
c	3
b	0
f	0
loc	188
rs	10
wmc	20

21 Methods

Rating	Name	Size	Complexity
	delete	9	?
	update	14	?
	deleteConfirmation	9	?
	checkModel	5	?
	read	11	?
	getQuestionModel	10	?
	injectQuestionTypeModels	3	?
A	injectQuestionTypeModels(Model)	3	1
	getCurrentTopicModel	5	?
A	checkModel(QuestionModelInterface,Integer)	5	3
A	insert(Model,QuestionModelDto,BindingResult,Integer)	21	2
A	list(Model,Integer)	7	1
A	delete(Model,Integer,Integer)	9	1
A	save(Model,Integer,QuestionModelDto,BindingResult,Integer)	21	2
A	getCurrentTopicModel(Integer)	5	1
A	create(Model,Integer)	9	1
A	update(Model,Integer,Integer)	14	1
A	checkModel(TopicModelInterface)	5	3
A	deleteConfirmation(Model,Integer,Integer)	9	1
A	getQuestionModel(Integer,Integer,Boolean)	10	2
A	read(Model,Integer,Integer)	11	1

package easytests.personal.controllers;

import easytests.common.controllers.AbstractCrudController;
import easytests.common.exceptions.ForbiddenException;
import easytests.common.exceptions.NotFoundException;
import easytests.core.models.*;
import easytests.core.options.*;
import easytests.core.options.builder.AnswersOptionsBuilder;
import easytests.core.options.builder.QuestionsOptionsBuilder;
import easytests.core.options.builder.TopicsOptionsBuilder;
import easytests.core.services.AnswersService;
import easytests.core.services.QuestionTypesService;
import easytests.core.services.QuestionsService;
import easytests.core.services.TopicsService;
import easytests.personal.dto.QuestionModelDto;
import easytests.personal.validators.QuestionModelDtoValidator;
import java.util.*;
import javax.validation.Valid;
import javax.validation.constraints.NotNull;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Controller;
import org.springframework.ui.Model;
import org.springframework.validation.BindingResult;
import org.springframework.web.bind.annotation.*;

/**
 * @author firkhraag
 * @author rezenbekk
 */
@Controller
@SuppressWarnings({
                "checkstyle:MultipleStringLiterals",
                "checkstyle:ClassFanOutComplexity"})
@RequestMapping("/personal/topics/{topicId}/questions")
public class QuestionsController extends AbstractCrudController {

    @Autowired
    protected TopicsService topicsService;

    @Autowired
    private QuestionsService questionsService;

    @Autowired
    private QuestionTypesService questionTypesService;

    @Autowired
    private QuestionsOptionsBuilder questionsOptionsBuilder;
    
    @Autowired
    private TopicsOptionsBuilder topicsOptionsBuilder;
    
    @Autowired
    private QuestionModelDtoValidator questionModelDtoValidator;

    @Autowired
    private AnswersOptionsBuilder answersOptionsBuilder;

    @Autowired
    private AnswersService answersService;

    @GetMapping("")
    public String list(Model model, @PathVariable("topicId") Integer topicId) {
        final List<QuestionModelInterface> questions = this.questionsService
            .findByTopic(this.getCurrentTopicModel(topicId));
        model.addAttribute("questions", questions);
        model.addAttribute("topicId", topicId);
        return "questions/list";
    }

    @GetMapping("{questionId}")
    public String read(
            Model model,
            @PathVariable("questionId") Integer questionId,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, false);
        injectQuestionTypeModels(model);
        model.addAttribute("question", questionModel);
        model.addAttribute("topicId", topicId);
        return "questions/view";
    }

    @GetMapping("create/")
    public String create(Model model, @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        injectQuestionTypeModels(model);
        final QuestionModelDto questionModelDto = new QuestionModelDto();
        setCreateBehaviour(model);
        model.addAttribute("question", questionModelDto);
        model.addAttribute("topicId", topicId);
        return "questions/form";
    }

    @PostMapping("create/")
    public String insert(
            Model model,
            @Valid @NotNull QuestionModelDto questionModelDto,
            BindingResult bindingResult,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
        this.questionModelDtoValidator.validate(questionModelDto, bindingResult);
        if (bindingResult.hasErrors()) {
            injectQuestionTypeModels(model);
            setCreateBehaviour(model);
            model.addAttribute("question", questionModelDto);
            model.addAttribute("topicId", topicId);
            model.addAttribute("errors", bindingResult);
            return "questions/form";
        }
        final QuestionModelInterface questionModel = new QuestionModel();
        questionModelDto.mapInto(questionModel, questionTypesService);
        questionModel.setTopic(topicModel);
        this.questionsService.save(questionModel);
        return "redirect:/personal/topics/" + topicId + "/questions/";
    }

    @GetMapping("update/{questionId}/")
    public String update(
            Model model,
            @PathVariable Integer questionId,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        final QuestionModelInterface questionModel = this.getQuestionModel(questionId, topicId, false);
        injectQuestionTypeModels(model);
        final QuestionModelDto questionModelDto = new QuestionModelDto();
        questionModelDto.map(questionModel);
        setUpdateBehaviour(model);
        model.addAttribute("question", questionModelDto);
        model.addAttribute("topicId", topicId);
        return "questions/form";
    }

    @PostMapping("update/{questionId}/")
    public String save(
            Model model,
            @PathVariable Integer questionId,
            @Valid @NotNull QuestionModelDto questionModelDto,
            BindingResult bindingResult,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        final QuestionModelInterface questionModel = this.getQuestionModel(questionId, topicId, false);
        this.questionModelDtoValidator.validate(questionModelDto, bindingResult);
        if (bindingResult.hasErrors()) {
            injectQuestionTypeModels(model);
            setUpdateBehaviour(model);
            model.addAttribute("question", questionModelDto);
            model.addAttribute("topicId", topicId);
            model.addAttribute("errors", bindingResult);
            return "questions/form";
        }
        questionModelDto.mapInto(questionModel, questionTypesService);
        this.questionsService.save(questionModel);
        return "redirect:/personal/topics/" + topicId + "/questions/";
    }

    @GetMapping("delete/{questionId}")
    public String deleteConfirmation(
            Model model,
            @PathVariable("questionId") Integer questionId,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, false);

        model.addAttribute("topicId", topicId);
        return "questions/delete";
    }

    @PostMapping("delete/{questionId}/")
    public String delete(
            Model model,
            @PathVariable("questionId") Integer questionId,
            @PathVariable("topicId") Integer topicId) {
        final TopicModelInterface topicModel = getCurrentTopicModel(topicId);

        final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, true);
        questionsService.delete(questionModel, this.questionsOptionsBuilder.forDelete());
        return "redirect:/personal/topics/" + topicId + "/questions/";
    }

    private TopicModelInterface getCurrentTopicModel(Integer topicId) {
        final TopicsOptionsInterface topicsOptions = this.topicsOptionsBuilder.forAuth();
        final TopicModelInterface topicModel = topicsService.find(topicId, topicsOptions);
        checkModel(topicModel);
        return topicModel;
    }

    private void checkModel(QuestionModelInterface questionModel, Integer topicId) {
        if (questionModel == null) {
            throw new NotFoundException();
        }
        if (!questionModel.getTopic().getId().equals(this.getCurrentTopicModel(topicId).getId())) {
            throw new ForbiddenException();
        }
    }
    
    private void checkModel(TopicModelInterface topicModel) {
        if (topicModel == null) {
            throw new NotFoundException();
        }
        if (!topicModel.getSubject().getUser().getId().equals(this.getCurrentUserModel().getId())) {
            throw new ForbiddenException();
        }
    }

    private QuestionModelInterface getQuestionModel(Integer id, Integer topicId, Boolean forDelete) {
        final QuestionsOptionsInterface questionsOptions = this.questionsOptionsBuilder
                .forAuth()
                .withAnswers(new AnswersOptions());
        final QuestionModelInterface questionModel = this.questionsService.find(id, questionsOptions);
        checkModel(questionModel, topicId);
        if (forDelete) {
            return this.questionsService.find(id, this.questionsOptionsBuilder.forDelete());
        }
        return questionModel;
    }

    private void injectQuestionTypeModels(Model model) {
        final List<QuestionTypeModelInterface> questionTypes = this.questionTypesService.findAll();
        model.addAttribute("questionTypes", questionTypes);
    }
}


1			package easytests.personal.controllers;
2
3			import easytests.common.controllers.AbstractCrudController;
4			import easytests.common.exceptions.ForbiddenException;
5			import easytests.common.exceptions.NotFoundException;
6			import easytests.core.models.*;
7			import easytests.core.options.*;
8			import easytests.core.options.builder.AnswersOptionsBuilder;
9			import easytests.core.options.builder.QuestionsOptionsBuilder;
10			import easytests.core.options.builder.TopicsOptionsBuilder;
11			import easytests.core.services.AnswersService;
12			import easytests.core.services.QuestionTypesService;
13			import easytests.core.services.QuestionsService;
14			import easytests.core.services.TopicsService;
15			import easytests.personal.dto.QuestionModelDto;
16			import easytests.personal.validators.QuestionModelDtoValidator;
17			import java.util.*;
18			import javax.validation.Valid;
19			import javax.validation.constraints.NotNull;
20			import org.springframework.beans.factory.annotation.Autowired;
21			import org.springframework.stereotype.Controller;
22			import org.springframework.ui.Model;
23			import org.springframework.validation.BindingResult;
24			import org.springframework.web.bind.annotation.*;
25
26			/**
27			* @author firkhraag
28			* @author rezenbekk
29			*/
30			@Controller
31			@SuppressWarnings({
32			"checkstyle:MultipleStringLiterals",
33			"checkstyle:ClassFanOutComplexity"})
34			@RequestMapping("/personal/topics/{topicId}/questions")
35			public class QuestionsController extends AbstractCrudController {
36
37			@Autowired
38			protected TopicsService topicsService;
39
40			@Autowired
41			private QuestionsService questionsService;
42
43			@Autowired
44			private QuestionTypesService questionTypesService;
45
46			@Autowired
47			private QuestionsOptionsBuilder questionsOptionsBuilder;
48
49			@Autowired
50			private TopicsOptionsBuilder topicsOptionsBuilder;
51
52			@Autowired
53			private QuestionModelDtoValidator questionModelDtoValidator;
54
55			@Autowired
56			private AnswersOptionsBuilder answersOptionsBuilder;
57
58			@Autowired
59			private AnswersService answersService;
60
61			@GetMapping("")
62			public String list(Model model, @PathVariable("topicId") Integer topicId) {
63			final List<QuestionModelInterface> questions = this.questionsService
64			.findByTopic(this.getCurrentTopicModel(topicId));
65			model.addAttribute("questions", questions);
66			model.addAttribute("topicId", topicId);
67			return "questions/list";
68			}
69
70			@GetMapping("{questionId}")
71			public String read(
72			Model model,
73			@PathVariable("questionId") Integer questionId,
74			@PathVariable("topicId") Integer topicId) {
75			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
76			final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, false);
77			injectQuestionTypeModels(model);
78			model.addAttribute("question", questionModel);
79			model.addAttribute("topicId", topicId);
80			return "questions/view";
81			}
82
83			@GetMapping("create/")
84			public String create(Model model, @PathVariable("topicId") Integer topicId) {
85			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
86			injectQuestionTypeModels(model);
87			final QuestionModelDto questionModelDto = new QuestionModelDto();
88			setCreateBehaviour(model);
89			model.addAttribute("question", questionModelDto);
90			model.addAttribute("topicId", topicId);
91			return "questions/form";
92			}
93
94			@PostMapping("create/")
95			public String insert(
96			Model model,
97			@Valid @NotNull QuestionModelDto questionModelDto,
98			BindingResult bindingResult,
99			@PathVariable("topicId") Integer topicId) {
100			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
101			this.questionModelDtoValidator.validate(questionModelDto, bindingResult);
102			if (bindingResult.hasErrors()) {
103			injectQuestionTypeModels(model);
104			setCreateBehaviour(model);
105			model.addAttribute("question", questionModelDto);
106			model.addAttribute("topicId", topicId);
107			model.addAttribute("errors", bindingResult);
108			return "questions/form";
109			}
110			final QuestionModelInterface questionModel = new QuestionModel();
111			questionModelDto.mapInto(questionModel, questionTypesService);
112			questionModel.setTopic(topicModel);
113			this.questionsService.save(questionModel);
114			return "redirect:/personal/topics/" + topicId + "/questions/";
115			}
116
117			@GetMapping("update/{questionId}/")
118			public String update(
119			Model model,
120			@PathVariable Integer questionId,
121			@PathVariable("topicId") Integer topicId) {
122			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
123			final QuestionModelInterface questionModel = this.getQuestionModel(questionId, topicId, false);
124			injectQuestionTypeModels(model);
125			final QuestionModelDto questionModelDto = new QuestionModelDto();
126			questionModelDto.map(questionModel);
127			setUpdateBehaviour(model);
128			model.addAttribute("question", questionModelDto);
129			model.addAttribute("topicId", topicId);
130			return "questions/form";
131			}
132
133			@PostMapping("update/{questionId}/")
134			public String save(
135			Model model,
136			@PathVariable Integer questionId,
137			@Valid @NotNull QuestionModelDto questionModelDto,
138			BindingResult bindingResult,
139			@PathVariable("topicId") Integer topicId) {
140			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
141			final QuestionModelInterface questionModel = this.getQuestionModel(questionId, topicId, false);
142			this.questionModelDtoValidator.validate(questionModelDto, bindingResult);
143			if (bindingResult.hasErrors()) {
144			injectQuestionTypeModels(model);
145			setUpdateBehaviour(model);
146			model.addAttribute("question", questionModelDto);
147			model.addAttribute("topicId", topicId);
148			model.addAttribute("errors", bindingResult);
149			return "questions/form";
150			}
151			questionModelDto.mapInto(questionModel, questionTypesService);
152			this.questionsService.save(questionModel);
153			return "redirect:/personal/topics/" + topicId + "/questions/";
154			}
155
156			@GetMapping("delete/{questionId}")
157			public String deleteConfirmation(
158			Model model,
159			@PathVariable("questionId") Integer questionId,
160			@PathVariable("topicId") Integer topicId) {
161			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
162			final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, false);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `questionModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "questionModel". Loading history...
163			model.addAttribute("topicId", topicId);
164			return "questions/delete";
165			}
166
167			@PostMapping("delete/{questionId}/")
168			public String delete(
169			Model model,
170			@PathVariable("questionId") Integer questionId,
171			@PathVariable("topicId") Integer topicId) {
172			final TopicModelInterface topicModel = getCurrentTopicModel(topicId);
			0 ignored issues – show Unused Code introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Consider removing the unused local variable `topicModel`. Loading history... Unused Code Code Smell introduced 2017-11-17 08:35 UTC by Report Bug Copy Issue Report Remove this useless assignment to local variable "topicModel". Loading history...
173			final QuestionModelInterface questionModel = getQuestionModel(questionId, topicId, true);
174			questionsService.delete(questionModel, this.questionsOptionsBuilder.forDelete());
175			return "redirect:/personal/topics/" + topicId + "/questions/";
176			}
177
178			private TopicModelInterface getCurrentTopicModel(Integer topicId) {
179			final TopicsOptionsInterface topicsOptions = this.topicsOptionsBuilder.forAuth();
180			final TopicModelInterface topicModel = topicsService.find(topicId, topicsOptions);
181			checkModel(topicModel);
182			return topicModel;
183			}
184
185			private void checkModel(QuestionModelInterface questionModel, Integer topicId) {
186			if (questionModel == null) {
187			throw new NotFoundException();
188			}
189			if (!questionModel.getTopic().getId().equals(this.getCurrentTopicModel(topicId).getId())) {
190			throw new ForbiddenException();
191			}
192			}
193
194			private void checkModel(TopicModelInterface topicModel) {
195			if (topicModel == null) {
196			throw new NotFoundException();
197			}
198			if (!topicModel.getSubject().getUser().getId().equals(this.getCurrentUserModel().getId())) {
199			throw new ForbiddenException();
200			}
201			}
202
203			private QuestionModelInterface getQuestionModel(Integer id, Integer topicId, Boolean forDelete) {
204			final QuestionsOptionsInterface questionsOptions = this.questionsOptionsBuilder
205			.forAuth()
206			.withAnswers(new AnswersOptions());
207			final QuestionModelInterface questionModel = this.questionsService.find(id, questionsOptions);
208			checkModel(questionModel, topicId);
209			if (forDelete) {
210			return this.questionsService.find(id, this.questionsOptionsBuilder.forDelete());
211			}
212			return questionModel;
213			}
214
215			private void injectQuestionTypeModels(Model model) {
216			final List<QuestionTypeModelInterface> questionTypes = this.questionTypesService.findAll();
217			model.addAttribute("questionTypes", questionTypes);
218			}
219			}
220

malinink / easy-tests

easytests.personal.controllers.QuestionsController A last analyzed 2018-03-30 20:09 UTC

Complexity

Size/Duplication

Importance

21 Methods

Duplication Side-by-Side

Filter issues like

easytests.personal.controllers.QuestionsController A
last analyzed 2018-03-30 20:09 UTC