MultiUnitSupport - Code Metrics - Inspection of "Apply fixes from StyleCI" - maksimru/multi-unit-models - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Maksim

created 2019-05-20 21:14 UTC

MultiUnitSupport B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	364
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	50
lcom	1
cbo	1
dl	0
loc	364
rs	8.4
c	0
b	0
f	0

24 Methods

Rating	Name	Size	Complexity
A	getUnitConversionDataColumns()	6	1
A	getUnitConversionUnitColumns()	6	1
A	fillableFromArray()	4	1
A	getFillable()	4	1
A	getHidden()	4	1
B	bootMultiUnitSupport()	38	6
A	calculateMultiUnitConversionData()	13	2
A	getMultiUnitExistingConversionData()	4	1
A	getUnitAttributePostfix()	4	1
A	getUnitConversionDataPostfix()	4	1
A	getMultiUnitColumns()	4	1
A	getMultiUnitFieldSupportedUnits()	8	2
A	getMultiUnitFieldDefaultUnit()	10	2
B	getMultiUnitFieldValue()	20	6
A	isMultiUnitField()	4	1
A	getMultiUnitFieldUnit()	16	4
A	forgetMultiUnitFieldUnitInput()	7	2
A	setMultiUnitFieldUnit()	5	1
A	resetMultiUnitFieldUnit()	4	1
A	hasSetMutator()	8	2
A	setMutatedAttributeValue()	11	2
A	processMultiUnitFieldChanges()	24	5
A	hasGetMutator()	8	3
A	mutateAttribute()	10	2

How to fix Complexity

<?php

namespace MaksimM\MultiUnitModels\Traits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use MaksimM\MultiUnitModels\Exceptions\NotSupportedMultiUnitField;
use UnitConverter\Unit\AbstractUnit;

trait MultiUnitSupport
{
    protected $unitAttributePostfix = '_units';
    protected $unitConversionDataPostfix = '_ucd';
    protected $multiUnitColumns = [];

    private function getUnitConversionDataColumns()
    {
        return array_map(function ($column) {
            return $column.$this->getUnitConversionDataPostfix();
        }, array_keys($this->getMultiUnitColumns()));
    }

    private function getUnitConversionUnitColumns()
    {
        return array_map(function ($column) {
            return $column.$this->getUnitAttributePostfix();
        }, array_keys($this->getMultiUnitColumns()));
    }

    /**
     * Allows to set input units and process them before multi-unit field.
     *
     * @param array $attributes
     *
     * @return array
     */
    protected function fillableFromArray(array $attributes)
    {
        return array_merge(array_intersect_key($attributes, array_flip($this->getUnitConversionUnitColumns())), parent::fillableFromArray($attributes));
    }

    /**
     * @return array
     */
    public function getFillable()
    {
        return array_merge($this->getUnitConversionDataColumns(), $this->getUnitConversionUnitColumns(), parent::getFillable());
    }

    /**
     * @return mixed
     */
    public function getHidden()
    {
        return array_merge(parent::getHidden(), $this->getUnitConversionDataColumns());
    }

    protected static function bootMultiUnitSupport()
    {
        //save conversion table if base value is changed
        static::creating(function ($model) {
            /**
             * @var Model|MultiUnitSupport $model
             */
            foreach ($model->getMultiUnitColumns() as $unitBasedColumn => $options) {
                if (isset($model->attributes[$unitBasedColumn])) {
                    $model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode(
                        $model->calculateMultiUnitConversionData(
                            $model->attributes[$unitBasedColumn],
                            $model->getMultiUnitFieldUnit($unitBasedColumn),
                            $options['supported_units']
                        )
                    );
                    $model->{$unitBasedColumn} = $model->processMultiUnitFieldChanges(
                        $unitBasedColumn,
                        $model->{$unitBasedColumn}
                    );
                }
            }
            //prevent saving of unit columns
            foreach ($model->getUnitConversionUnitColumns() as $unitColumn) {
                if (isset($model->attributes[$unitColumn])) {
                    unset($model->attributes[$unitColumn]);
                }
            }
        });
        static::updating(function ($model) {
            /**
             * @var Model|MultiUnitSupport $model
             */
            foreach (Arr::only($model->getMultiUnitColumns(), array_keys($model->getDirty())) as $unitBasedColumn => $options) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode($model->calculateMultiUnitConversionData($model->getDirty()[$unitBasedColumn], new $options['default_unit'](), $options['supported_units']));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        });
    }

    /**
     * @param              $value
     * @param AbstractUnit $unit
     * @param string[]     $requiredUnits
     *
     * @return array
     */
    private function calculateMultiUnitConversionData($value, AbstractUnit $unit, $requiredUnits)
    {
        $conversionData = [];
        foreach ($requiredUnits as $requiredUnitClass) {
            /**
             * @var AbstractUnit $requiredUnit
             */
            $requiredUnit = new $requiredUnitClass();
            $conversionData[$requiredUnit->getSymbol()] = (new $unit($value))->as($requiredUnit);
        }

        return $conversionData;
    }

    public function getMultiUnitExistingConversionData($field)

    {
        return json_decode($this->{$field.$this->getUnitConversionDataPostfix()} ?? null);
    }

    /**
     * @return string
     */
    public function getUnitAttributePostfix()
    {
        return $this->unitAttributePostfix;
    }

    /**
     * @return string
     */
    protected function getUnitConversionDataPostfix()
    {
        return $this->unitConversionDataPostfix;
    }

    /**
     * @return array
     */
    protected function getMultiUnitColumns()
    {
        return $this->multiUnitColumns;
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit[]
     */
    public function getMultiUnitFieldSupportedUnits($field)
    {
        if ($this->isMultiUnitField($field)) {
            return $this->getMultiUnitColumns()[$field]['supported_units'];
        }

        throw new NotSupportedMultiUnitField($field);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit
     */
    public function getMultiUnitFieldDefaultUnit($field)
    {
        if ($this->isMultiUnitField($field)) {
            $unitClass = $this->getMultiUnitColumns()[$field]['default_unit'];

            return new $unitClass();
        }

        throw new NotSupportedMultiUnitField($field);
    }

    /**
     * @param                   $field
     * @param AbstractUnit|null $unit
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    public function getMultiUnitFieldValue($field, AbstractUnit $unit = null)
    {
        if ($this->isMultiUnitField($field)) {
            if (isset($this->{$field})) {
                if (is_null($unit)) {
                    $unit = $this->getMultiUnitFieldUnit($field);
                }
                $existingConversionData = $this->getMultiUnitExistingConversionData($field);
                if (!is_null($existingConversionData) && !is_null($existingConversionData->{$unit->getSymbol()})) {
                    return $existingConversionData->{$unit->getSymbol()};
                }

                return ($this->getMultiUnitFieldDefaultUnit($field)->setValue($this->{$field} ?? $this->attributes[$field]))->as(new $unit());
class MyClass { }

$x = new MyClass();
$x->foo = true;
            } else {
                return;
            }
        }

        throw new NotSupportedMultiUnitField($field);
    }

    protected function isMultiUnitField($field)
    {
        return isset($this->getMultiUnitColumns()[$field]);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit
     */
    protected function getMultiUnitFieldUnit($field)
    {
        if (isset($this->{$field.$this->getUnitAttributePostfix()})) {
            foreach ($this->getMultiUnitFieldSupportedUnits($field) as $unitClass) {
                /**
                 * @var AbstractUnit $unit
                 */
                $unit = new $unitClass();
                if (strtolower($unit->getSymbol()) == strtolower($this->{$field.$this->getUnitAttributePostfix()})) {
                    return $unit;
                }
            }
        }

        return $this->getMultiUnitFieldDefaultUnit($field);
    }

    protected function forgetMultiUnitFieldUnitInput($field)
    {
        //prevent column_units to by saved to DB
        if (isset($this->attributes[$field.$this->getUnitAttributePostfix()])) {
            $this->syncOriginalAttribute($field.$this->getUnitAttributePostfix());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    protected function setMultiUnitFieldUnit($field, AbstractUnit $unit)
    {
        $this->{$field.$this->getUnitAttributePostfix()} = $unit->getSymbol();
        $this->forgetMultiUnitFieldUnitInput($field);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     */
    protected function resetMultiUnitFieldUnit($field)
    {
        $this->setMultiUnitFieldUnit($field, $this->getMultiUnitFieldDefaultUnit($field));
    }

    /**
     * Determine if a set mutator exists for an attribute.
     *
     * @param string $key
     *
     * @return bool
     */
    public function hasSetMutator($key)
    {
        if ($this->isMultiUnitField($key)) {
            return true;
        }

        return parent::hasSetMutator($key);
    }

    /**
     * Set the value of an attribute using its mutator.
     *
     * @param string $key
     * @param mixed  $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    protected function setMutatedAttributeValue($key, $value)
    {
        if ($this->isMultiUnitField($key)) {
            $value = $this->processMultiUnitFieldChanges($key, $value);
            $this->attributes[$key] = $value;

            return $value;
        }

        parent::setMutatedAttributeValue($key, $value);
    }

    /**
     * Detect changes and set proper base value.
     *
     * @param $field
     * @param $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    private function processMultiUnitFieldChanges($field, $value)
    {
        $existingConversionData = $this->getMultiUnitExistingConversionData($field);
        if (!is_null($existingConversionData)) {
            $inputUnit = $this->getMultiUnitFieldUnit($field);
            //change existing value only in case if new value doesn't match with stored conversion table or not exists
            if (!isset($existingConversionData->{$inputUnit->getSymbol()}) || $value != $existingConversionData->{$inputUnit->getSymbol()}) {
                $this->resetMultiUnitFieldUnit($field);

                return (new $inputUnit($value))->as($this->getMultiUnitFieldDefaultUnit($field));
            } elseif ($value == $existingConversionData->{$inputUnit->getSymbol()}) {
                //forget changes if value actually isn't changed
                $this->resetMultiUnitFieldUnit($field);
                $originalValue = $existingConversionData->{$this->getMultiUnitFieldDefaultUnit($field)->getSymbol()};
                $this->attributes[$field] = $originalValue;
                $this->syncOriginalAttribute($field);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

                return $originalValue;
            }
            $this->resetMultiUnitFieldUnit($field);
        }

        return $value;
    }

    /**
     * Determine if a get mutator exists for an attribute.
     *coo.
     *
     * @param string $key
     *
     * @return bool
     */
    public function hasGetMutator($key)
    {
        if ($this->isMultiUnitField($key) && isset($this->{$key})) {
            return true;
        }

        return parent::hasGetMutator($key);
    }

    /**
     * Get the value of an attribute using its mutator.
     *
     * @param string $key
     * @param mixed  $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    public function mutateAttribute($key, $value)
    {
        if ($this->isMultiUnitField($key)) {
            $requestedUnit = $this->getMultiUnitFieldUnit($key);

            return $this->getMultiUnitFieldValue($key, new $requestedUnit());
        }

        return parent::mutateAttribute($key, $value);
    }
}


1			<?php
2
3			namespace MaksimM\MultiUnitModels\Traits;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Support\Arr;
7			use MaksimM\MultiUnitModels\Exceptions\NotSupportedMultiUnitField;
8			use UnitConverter\Unit\AbstractUnit;
9
10			trait MultiUnitSupport
11			{
12			protected $unitAttributePostfix = '_units';
13			protected $unitConversionDataPostfix = '_ucd';
14			protected $multiUnitColumns = [];
15
16			private function getUnitConversionDataColumns()
17			{
18			return array_map(function ($column) {
19			return $column.$this->getUnitConversionDataPostfix();
20			}, array_keys($this->getMultiUnitColumns()));
21			}
22
23			private function getUnitConversionUnitColumns()
24			{
25			return array_map(function ($column) {
26			return $column.$this->getUnitAttributePostfix();
27			}, array_keys($this->getMultiUnitColumns()));
28			}
29
30			/**
31			* Allows to set input units and process them before multi-unit field.
32			*
33			* @param array $attributes
34			*
35			* @return array
36			*/
37			protected function fillableFromArray(array $attributes)
38			{
39			return array_merge(array_intersect_key($attributes, array_flip($this->getUnitConversionUnitColumns())), parent::fillableFromArray($attributes));
40			}
41
42			/**
43			* @return array
44			*/
45			public function getFillable()
46			{
47			return array_merge($this->getUnitConversionDataColumns(), $this->getUnitConversionUnitColumns(), parent::getFillable());
48			}
49
50			/**
51			* @return mixed
52			*/
53			public function getHidden()
54			{
55			return array_merge(parent::getHidden(), $this->getUnitConversionDataColumns());
56			}
57
58			protected static function bootMultiUnitSupport()
59			{
60			//save conversion table if base value is changed
61			static::creating(function ($model) {
62			/**
63			* @var Model\|MultiUnitSupport $model
64			*/
65			foreach ($model->getMultiUnitColumns() as $unitBasedColumn => $options) {
66			if (isset($model->attributes[$unitBasedColumn])) {
67			$model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode(
68			$model->calculateMultiUnitConversionData(
69			$model->attributes[$unitBasedColumn],
70			$model->getMultiUnitFieldUnit($unitBasedColumn),
71			$options['supported_units']
72			)
73			);
74			$model->{$unitBasedColumn} = $model->processMultiUnitFieldChanges(
75			$unitBasedColumn,
76			$model->{$unitBasedColumn}
77			);
78			}
79			}
80			//prevent saving of unit columns
81			foreach ($model->getUnitConversionUnitColumns() as $unitColumn) {
82			if (isset($model->attributes[$unitColumn])) {
83			unset($model->attributes[$unitColumn]);
84			}
85			}
86			});
87			static::updating(function ($model) {
88			/**
89			* @var Model\|MultiUnitSupport $model
90			*/
91			foreach (Arr::only($model->getMultiUnitColumns(), array_keys($model->getDirty())) as $unitBasedColumn => $options) {
			0 ignored issues – show Bug introduced 2019-05-03 03:08 UTC by Report Bug Copy Issue Report It seems like `getDirty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
92			$model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode($model->calculateMultiUnitConversionData($model->getDirty()[$unitBasedColumn], new $options['default_unit'](), $options['supported_units']));
			0 ignored issues – show Bug introduced 2019-05-03 03:08 UTC by Report Bug Copy Issue Report It seems like `getDirty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
93			}
94			});
95			}
96
97			/**
98			* @param $value
99			* @param AbstractUnit $unit
100			* @param string[] $requiredUnits
101			*
102			* @return array
103			*/
104			private function calculateMultiUnitConversionData($value, AbstractUnit $unit, $requiredUnits)
105			{
106			$conversionData = [];
107			foreach ($requiredUnits as $requiredUnitClass) {
108			/**
109			* @var AbstractUnit $requiredUnit
110			*/
111			$requiredUnit = new $requiredUnitClass();
112			$conversionData[$requiredUnit->getSymbol()] = (new $unit($value))->as($requiredUnit);
113			}
114
115			return $conversionData;
116			}
117
118			public function getMultiUnitExistingConversionData($field)
			0 ignored issues – show Documentation introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
119			{
120			return json_decode($this->{$field.$this->getUnitConversionDataPostfix()} ?? null);
121			}
122
123			/**
124			* @return string
125			*/
126			public function getUnitAttributePostfix()
127			{
128			return $this->unitAttributePostfix;
129			}
130
131			/**
132			* @return string
133			*/
134			protected function getUnitConversionDataPostfix()
135			{
136			return $this->unitConversionDataPostfix;
137			}
138
139			/**
140			* @return array
141			*/
142			protected function getMultiUnitColumns()
143			{
144			return $this->multiUnitColumns;
145			}
146
147			/**
148			* @param $field
149			*
150			* @throws NotSupportedMultiUnitField
151			*
152			* @return AbstractUnit[]
153			*/
154			public function getMultiUnitFieldSupportedUnits($field)
155			{
156			if ($this->isMultiUnitField($field)) {
157			return $this->getMultiUnitColumns()[$field]['supported_units'];
158			}
159
160			throw new NotSupportedMultiUnitField($field);
161			}
162
163			/**
164			* @param $field
165			*
166			* @throws NotSupportedMultiUnitField
167			*
168			* @return AbstractUnit
169			*/
170			public function getMultiUnitFieldDefaultUnit($field)
171			{
172			if ($this->isMultiUnitField($field)) {
173			$unitClass = $this->getMultiUnitColumns()[$field]['default_unit'];
174
175			return new $unitClass();
176			}
177
178			throw new NotSupportedMultiUnitField($field);
179			}
180
181			/**
182			* @param $field
183			* @param AbstractUnit\|null $unit
184			*
185			* @throws NotSupportedMultiUnitField
186			*
187			* @return mixed
188			*/
189			public function getMultiUnitFieldValue($field, AbstractUnit $unit = null)
190			{
191			if ($this->isMultiUnitField($field)) {
192			if (isset($this->{$field})) {
193			if (is_null($unit)) {
194			$unit = $this->getMultiUnitFieldUnit($field);
195			}
196			$existingConversionData = $this->getMultiUnitExistingConversionData($field);
197			if (!is_null($existingConversionData) && !is_null($existingConversionData->{$unit->getSymbol()})) {
198			return $existingConversionData->{$unit->getSymbol()};
199			}
200
201			return ($this->getMultiUnitFieldDefaultUnit($field)->setValue($this->{$field} ?? $this->attributes[$field]))->as(new $unit());
			0 ignored issues – show Bug introduced 2019-05-20 21:15 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
202			} else {
203			return;
204			}
205			}
206
207			throw new NotSupportedMultiUnitField($field);
208			}
209
210			protected function isMultiUnitField($field)
211			{
212			return isset($this->getMultiUnitColumns()[$field]);
213			}
214
215			/**
216			* @param $field
217			*
218			* @throws NotSupportedMultiUnitField
219			*
220			* @return AbstractUnit
221			*/
222			protected function getMultiUnitFieldUnit($field)
223			{
224			if (isset($this->{$field.$this->getUnitAttributePostfix()})) {
225			foreach ($this->getMultiUnitFieldSupportedUnits($field) as $unitClass) {
226			/**
227			* @var AbstractUnit $unit
228			*/
229			$unit = new $unitClass();
230			if (strtolower($unit->getSymbol()) == strtolower($this->{$field.$this->getUnitAttributePostfix()})) {
231			return $unit;
232			}
233			}
234			}
235
236			return $this->getMultiUnitFieldDefaultUnit($field);
237			}
238
239			protected function forgetMultiUnitFieldUnitInput($field)
240			{
241			//prevent column_units to by saved to DB
242			if (isset($this->attributes[$field.$this->getUnitAttributePostfix()])) {
243			$this->syncOriginalAttribute($field.$this->getUnitAttributePostfix());
			0 ignored issues – show Bug introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report It seems like `syncOriginalAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
244			}
245			}
246
247			protected function setMultiUnitFieldUnit($field, AbstractUnit $unit)
248			{
249			$this->{$field.$this->getUnitAttributePostfix()} = $unit->getSymbol();
250			$this->forgetMultiUnitFieldUnitInput($field);
251			}
252
253			/**
254			* @param $field
255			*
256			* @throws NotSupportedMultiUnitField
257			*/
258			protected function resetMultiUnitFieldUnit($field)
259			{
260			$this->setMultiUnitFieldUnit($field, $this->getMultiUnitFieldDefaultUnit($field));
261			}
262
263			/**
264			* Determine if a set mutator exists for an attribute.
265			*
266			* @param string $key
267			*
268			* @return bool
269			*/
270			public function hasSetMutator($key)
271			{
272			if ($this->isMultiUnitField($key)) {
273			return true;
274			}
275
276			return parent::hasSetMutator($key);
277			}
278
279			/**
280			* Set the value of an attribute using its mutator.
281			*
282			* @param string $key
283			* @param mixed $value
284			*
285			* @throws NotSupportedMultiUnitField
286			*
287			* @return mixed
288			*/
289			protected function setMutatedAttributeValue($key, $value)
290			{
291			if ($this->isMultiUnitField($key)) {
292			$value = $this->processMultiUnitFieldChanges($key, $value);
293			$this->attributes[$key] = $value;
294
295			return $value;
296			}
297
298			parent::setMutatedAttributeValue($key, $value);
299			}
300
301			/**
302			* Detect changes and set proper base value.
303			*
304			* @param $field
305			* @param $value
306			*
307			* @throws NotSupportedMultiUnitField
308			*
309			* @return mixed
310			*/
311			private function processMultiUnitFieldChanges($field, $value)
312			{
313			$existingConversionData = $this->getMultiUnitExistingConversionData($field);
314			if (!is_null($existingConversionData)) {
315			$inputUnit = $this->getMultiUnitFieldUnit($field);
316			//change existing value only in case if new value doesn't match with stored conversion table or not exists
317			if (!isset($existingConversionData->{$inputUnit->getSymbol()}) \|\| $value != $existingConversionData->{$inputUnit->getSymbol()}) {
318			$this->resetMultiUnitFieldUnit($field);
319
320			return (new $inputUnit($value))->as($this->getMultiUnitFieldDefaultUnit($field));
321			} elseif ($value == $existingConversionData->{$inputUnit->getSymbol()}) {
322			//forget changes if value actually isn't changed
323			$this->resetMultiUnitFieldUnit($field);
324			$originalValue = $existingConversionData->{$this->getMultiUnitFieldDefaultUnit($field)->getSymbol()};
325			$this->attributes[$field] = $originalValue;
326			$this->syncOriginalAttribute($field);
			0 ignored issues – show Bug introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report It seems like `syncOriginalAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
327
328			return $originalValue;
329			}
330			$this->resetMultiUnitFieldUnit($field);
331			}
332
333			return $value;
334			}
335
336			/**
337			* Determine if a get mutator exists for an attribute.
338			*coo.
339			*
340			* @param string $key
341			*
342			* @return bool
343			*/
344			public function hasGetMutator($key)
345			{
346			if ($this->isMultiUnitField($key) && isset($this->{$key})) {
347			return true;
348			}
349
350			return parent::hasGetMutator($key);
351			}
352
353			/**
354			* Get the value of an attribute using its mutator.
355			*
356			* @param string $key
357			* @param mixed $value
358			*
359			* @throws NotSupportedMultiUnitField
360			*
361			* @return mixed
362			*/
363			public function mutateAttribute($key, $value)
364			{
365			if ($this->isMultiUnitField($key)) {
366			$requestedUnit = $this->getMultiUnitFieldUnit($key);
367
368			return $this->getMultiUnitFieldValue($key, new $requestedUnit());
369			}
370
371			return parent::mutateAttribute($key, $value);
372			}
373			}
374

maksimru / multi-unit-models

Pull Request — master (#3)

MultiUnitSupport B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like