MultiUnitSupport - Code Metrics - Inspection of "fix for non-required unit based fields" - maksimru/multi-unit-models - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b73c64...168e7d )

by Maksim

created 2019-05-17 17:18 UTC

MultiUnitSupport B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	363
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	50
lcom	1
cbo	1
dl	0
loc	363
rs	8.4
c	0
b	0
f	0

24 Methods

Rating	Name	Size	Complexity
A	getUnitConversionDataColumns()	6	1
A	getUnitConversionUnitColumns()	6	1
A	fillableFromArray()	4	1
A	getFillable()	4	1
A	getHidden()	4	1
B	bootMultiUnitSupport()	37	6
A	calculateMultiUnitConversionData()	13	2
A	getMultiUnitExistingConversionData()	4	1
A	getUnitAttributePostfix()	4	1
A	getUnitConversionDataPostfix()	4	1
A	getMultiUnitColumns()	4	1
A	getMultiUnitFieldSupportedUnits()	8	2
A	getMultiUnitFieldDefaultUnit()	10	2
B	getMultiUnitFieldValue()	20	6
A	isMultiUnitField()	4	1
A	getMultiUnitFieldUnit()	16	4
A	forgetMultiUnitFieldUnitInput()	7	2
A	setMultiUnitFieldUnit()	5	1
A	resetMultiUnitFieldUnit()	4	1
A	hasSetMutator()	8	2
A	setMutatedAttributeValue()	11	2
A	processMultiUnitFieldChanges()	24	5
A	hasGetMutator()	8	3
A	mutateAttribute()	10	2

How to fix Complexity

<?php

namespace MaksimM\MultiUnitModels\Traits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use MaksimM\MultiUnitModels\Exceptions\NotSupportedMultiUnitField;
use UnitConverter\Unit\AbstractUnit;

trait MultiUnitSupport
{
    protected $unitAttributePostfix = '_units';
    protected $unitConversionDataPostfix = '_ucd';
    protected $multiUnitColumns = [];

    private function getUnitConversionDataColumns()
    {
        return array_map(function ($column) {
            return $column.$this->getUnitConversionDataPostfix();
        }, array_keys($this->getMultiUnitColumns()));
    }

    private function getUnitConversionUnitColumns()
    {
        return array_map(function ($column) {
            return $column.$this->getUnitAttributePostfix();
        }, array_keys($this->getMultiUnitColumns()));
    }

    /**
     * Allows to set input units and process them before multi-unit field.
     *
     * @param array $attributes
     *
     * @return array
     */
    protected function fillableFromArray(array $attributes)
    {
        return array_merge(array_intersect_key($attributes, array_flip($this->getUnitConversionUnitColumns())), parent::fillableFromArray($attributes));
    }

    /**
     * @return array
     */
    public function getFillable()
    {
        return array_merge($this->getUnitConversionDataColumns(), $this->getUnitConversionUnitColumns(), parent::getFillable());
    }

    /**
     * @return mixed
     */
    public function getHidden()
    {
        return array_merge(parent::getHidden(), $this->getUnitConversionDataColumns());
    }

    protected static function bootMultiUnitSupport()
    {
        //save conversion table if base value is changed
        static::creating(function ($model) {
            /**
             * @var Model|MultiUnitSupport $model
             */
            foreach ($model->getMultiUnitColumns() as $unitBasedColumn => $options) {
                if(isset($model->attributes[$unitBasedColumn])) {
                    $model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode(
                        $model->calculateMultiUnitConversionData(
                            $model->attributes[$unitBasedColumn],
                            $model->getMultiUnitFieldUnit($unitBasedColumn),
                            $options['supported_units']
                        )
                    );
                    $model->{$unitBasedColumn} = $model->processMultiUnitFieldChanges(
                        $unitBasedColumn,
                        $model->{$unitBasedColumn}
                    );
                }
            }
            //prevent saving of unit columns
            foreach ($model->getUnitConversionUnitColumns() as $unitColumn) {
                if(isset($model->attributes[$unitColumn]))
                    unset($model->attributes[$unitColumn]);
            }
        });
        static::updating(function ($model) {
            /**
             * @var Model|MultiUnitSupport $model
             */
            foreach (Arr::only($model->getMultiUnitColumns(), array_keys($model->getDirty())) as $unitBasedColumn => $options) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode($model->calculateMultiUnitConversionData($model->getDirty()[$unitBasedColumn], new $options['default_unit'](), $options['supported_units']));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        });
    }

    /**
     * @param              $value
     * @param AbstractUnit $unit
     * @param string[]     $requiredUnits
     *
     * @return array
     */
    private function calculateMultiUnitConversionData($value, AbstractUnit $unit, $requiredUnits)
    {
        $conversionData = [];
        foreach ($requiredUnits as $requiredUnitClass) {
            /**
             * @var AbstractUnit $requiredUnit
             */
            $requiredUnit = new $requiredUnitClass();
            $conversionData[$requiredUnit->getSymbol()] = (new $unit($value))->as($requiredUnit);
        }

        return $conversionData;
    }

    public function getMultiUnitExistingConversionData($field)

    {
        return json_decode($this->{$field.$this->getUnitConversionDataPostfix()} ?? null);
    }

    /**
     * @return string
     */
    public function getUnitAttributePostfix()
    {
        return $this->unitAttributePostfix;
    }

    /**
     * @return string
     */
    protected function getUnitConversionDataPostfix()
    {
        return $this->unitConversionDataPostfix;
    }

    /**
     * @return array
     */
    protected function getMultiUnitColumns()
    {
        return $this->multiUnitColumns;
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit[]
     */
    public function getMultiUnitFieldSupportedUnits($field)
    {
        if ($this->isMultiUnitField($field)) {
            return $this->getMultiUnitColumns()[$field]['supported_units'];
        }

        throw new NotSupportedMultiUnitField($field);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit
     */
    public function getMultiUnitFieldDefaultUnit($field)
    {
        if ($this->isMultiUnitField($field)) {
            $unitClass = $this->getMultiUnitColumns()[$field]['default_unit'];

            return new $unitClass();
        }

        throw new NotSupportedMultiUnitField($field);
    }

    /**
     * @param                   $field
     * @param AbstractUnit|null $unit
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    public function getMultiUnitFieldValue($field, AbstractUnit $unit = null)
    {
        if ($this->isMultiUnitField($field)) {
            if (isset($this->{$field})) {
                if (is_null($unit)) {
                    $unit = $this->getMultiUnitFieldUnit($field);
                }
                $existingConversionData = $this->getMultiUnitExistingConversionData($field);
                if (!is_null($existingConversionData) && !is_null($existingConversionData->{$unit->getSymbol()})) {
                    return $existingConversionData->{$unit->getSymbol()};
                }

                return ($this->getMultiUnitFieldDefaultUnit($field)->setValue($this->{$field}))->as(new $unit());
            } else {
                return;
            }
        }

        throw new NotSupportedMultiUnitField($field);
    }

    protected function isMultiUnitField($field)
    {
        return isset($this->getMultiUnitColumns()[$field]);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return AbstractUnit
     */
    protected function getMultiUnitFieldUnit($field)
    {
        if (isset($this->{$field.$this->getUnitAttributePostfix()})) {
            foreach ($this->getMultiUnitFieldSupportedUnits($field) as $unitClass) {
                /**
                 * @var AbstractUnit $unit
                 */
                $unit = new $unitClass();
                if (strtolower($unit->getSymbol()) == strtolower($this->{$field.$this->getUnitAttributePostfix()})) {
                    return $unit;
                }
            }
        }

        return $this->getMultiUnitFieldDefaultUnit($field);
    }

    protected function forgetMultiUnitFieldUnitInput($field)
    {
        //prevent column_units to by saved to DB
        if (isset($this->attributes[$field.$this->getUnitAttributePostfix()])) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->syncOriginalAttribute($field.$this->getUnitAttributePostfix());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    protected function setMultiUnitFieldUnit($field, AbstractUnit $unit)
    {
        $this->{$field.$this->getUnitAttributePostfix()} = $unit->getSymbol();
        $this->forgetMultiUnitFieldUnitInput($field);
    }

    /**
     * @param $field
     *
     * @throws NotSupportedMultiUnitField
     */
    protected function resetMultiUnitFieldUnit($field)
    {
        $this->setMultiUnitFieldUnit($field, $this->getMultiUnitFieldDefaultUnit($field));
    }

    /**
     * Determine if a set mutator exists for an attribute.
     *
     * @param string $key
     *
     * @return bool
     */
    public function hasSetMutator($key)
    {
        if ($this->isMultiUnitField($key)) {
            return true;
        }

        return parent::hasSetMutator($key);
    }

    /**
     * Set the value of an attribute using its mutator.
     *
     * @param string $key
     * @param mixed  $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    protected function setMutatedAttributeValue($key, $value)
    {
        if ($this->isMultiUnitField($key)) {
            $value = $this->processMultiUnitFieldChanges($key, $value);
            $this->attributes[$key] = $value;

            return $value;
        }

        parent::setMutatedAttributeValue($key, $value);
    }

    /**
     * Detect changes and set proper base value.
     *
     * @param $field
     * @param $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    private function processMultiUnitFieldChanges($field, $value)
    {
        $existingConversionData = $this->getMultiUnitExistingConversionData($field);
        if (!is_null($existingConversionData)) {
            $inputUnit = $this->getMultiUnitFieldUnit($field);
            //change existing value only in case if new value doesn't match with stored conversion table or not exists
            if (!isset($existingConversionData->{$inputUnit->getSymbol()}) || $value != $existingConversionData->{$inputUnit->getSymbol()}) {
                $this->resetMultiUnitFieldUnit($field);

                return (new $inputUnit($value))->as($this->getMultiUnitFieldDefaultUnit($field));
            } elseif ($value == $existingConversionData->{$inputUnit->getSymbol()}) {
                //forget changes if value actually isn't changed
                $this->resetMultiUnitFieldUnit($field);
                $originalValue = $existingConversionData->{$this->getMultiUnitFieldDefaultUnit($field)->getSymbol()};
                $this->attributes[$field] = $originalValue;
                $this->syncOriginalAttribute($field);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

                return $originalValue;
            }
            $this->resetMultiUnitFieldUnit($field);
        }

        return $value;
    }

    /**
     * Determine if a get mutator exists for an attribute.
     *coo.
     *
     * @param string $key
     *
     * @return bool
     */
    public function hasGetMutator($key)
    {
        if ($this->isMultiUnitField($key) && isset($this->{$key})) {
            return true;
        }

        return parent::hasGetMutator($key);
    }

    /**
     * Get the value of an attribute using its mutator.
     *
     * @param string $key
     * @param mixed  $value
     *
     * @throws NotSupportedMultiUnitField
     *
     * @return mixed
     */
    public function mutateAttribute($key, $value)
    {
        if ($this->isMultiUnitField($key)) {
            $requestedUnit = $this->getMultiUnitFieldUnit($key);

            return $this->getMultiUnitFieldValue($key, new $requestedUnit());
        }

        return parent::mutateAttribute($key, $value);
    }
}


1			<?php
2
3			namespace MaksimM\MultiUnitModels\Traits;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Support\Arr;
7			use MaksimM\MultiUnitModels\Exceptions\NotSupportedMultiUnitField;
8			use UnitConverter\Unit\AbstractUnit;
9
10			trait MultiUnitSupport
11			{
12			protected $unitAttributePostfix = '_units';
13			protected $unitConversionDataPostfix = '_ucd';
14			protected $multiUnitColumns = [];
15
16			private function getUnitConversionDataColumns()
17			{
18			return array_map(function ($column) {
19			return $column.$this->getUnitConversionDataPostfix();
20			}, array_keys($this->getMultiUnitColumns()));
21			}
22
23			private function getUnitConversionUnitColumns()
24			{
25			return array_map(function ($column) {
26			return $column.$this->getUnitAttributePostfix();
27			}, array_keys($this->getMultiUnitColumns()));
28			}
29
30			/**
31			* Allows to set input units and process them before multi-unit field.
32			*
33			* @param array $attributes
34			*
35			* @return array
36			*/
37			protected function fillableFromArray(array $attributes)
38			{
39			return array_merge(array_intersect_key($attributes, array_flip($this->getUnitConversionUnitColumns())), parent::fillableFromArray($attributes));
40			}
41
42			/**
43			* @return array
44			*/
45			public function getFillable()
46			{
47			return array_merge($this->getUnitConversionDataColumns(), $this->getUnitConversionUnitColumns(), parent::getFillable());
48			}
49
50			/**
51			* @return mixed
52			*/
53			public function getHidden()
54			{
55			return array_merge(parent::getHidden(), $this->getUnitConversionDataColumns());
56			}
57
58			protected static function bootMultiUnitSupport()
59			{
60			//save conversion table if base value is changed
61			static::creating(function ($model) {
62			/**
63			* @var Model\|MultiUnitSupport $model
64			*/
65			foreach ($model->getMultiUnitColumns() as $unitBasedColumn => $options) {
66			if(isset($model->attributes[$unitBasedColumn])) {
67			$model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode(
68			$model->calculateMultiUnitConversionData(
69			$model->attributes[$unitBasedColumn],
70			$model->getMultiUnitFieldUnit($unitBasedColumn),
71			$options['supported_units']
72			)
73			);
74			$model->{$unitBasedColumn} = $model->processMultiUnitFieldChanges(
75			$unitBasedColumn,
76			$model->{$unitBasedColumn}
77			);
78			}
79			}
80			//prevent saving of unit columns
81			foreach ($model->getUnitConversionUnitColumns() as $unitColumn) {
82			if(isset($model->attributes[$unitColumn]))
83			unset($model->attributes[$unitColumn]);
84			}
85			});
86			static::updating(function ($model) {
87			/**
88			* @var Model\|MultiUnitSupport $model
89			*/
90			foreach (Arr::only($model->getMultiUnitColumns(), array_keys($model->getDirty())) as $unitBasedColumn => $options) {
			0 ignored issues – show Bug introduced 2019-05-03 03:08 UTC by Report Bug Copy Issue Report It seems like `getDirty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
91			$model->{$unitBasedColumn.$model->getUnitConversionDataPostfix()} = json_encode($model->calculateMultiUnitConversionData($model->getDirty()[$unitBasedColumn], new $options['default_unit'](), $options['supported_units']));
			0 ignored issues – show Bug introduced 2019-05-03 03:08 UTC by Report Bug Copy Issue Report It seems like `getDirty()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
92			}
93			});
94			}
95
96			/**
97			* @param $value
98			* @param AbstractUnit $unit
99			* @param string[] $requiredUnits
100			*
101			* @return array
102			*/
103			private function calculateMultiUnitConversionData($value, AbstractUnit $unit, $requiredUnits)
104			{
105			$conversionData = [];
106			foreach ($requiredUnits as $requiredUnitClass) {
107			/**
108			* @var AbstractUnit $requiredUnit
109			*/
110			$requiredUnit = new $requiredUnitClass();
111			$conversionData[$requiredUnit->getSymbol()] = (new $unit($value))->as($requiredUnit);
112			}
113
114			return $conversionData;
115			}
116
117			public function getMultiUnitExistingConversionData($field)
			0 ignored issues – show Documentation introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
118			{
119			return json_decode($this->{$field.$this->getUnitConversionDataPostfix()} ?? null);
120			}
121
122			/**
123			* @return string
124			*/
125			public function getUnitAttributePostfix()
126			{
127			return $this->unitAttributePostfix;
128			}
129
130			/**
131			* @return string
132			*/
133			protected function getUnitConversionDataPostfix()
134			{
135			return $this->unitConversionDataPostfix;
136			}
137
138			/**
139			* @return array
140			*/
141			protected function getMultiUnitColumns()
142			{
143			return $this->multiUnitColumns;
144			}
145
146			/**
147			* @param $field
148			*
149			* @throws NotSupportedMultiUnitField
150			*
151			* @return AbstractUnit[]
152			*/
153			public function getMultiUnitFieldSupportedUnits($field)
154			{
155			if ($this->isMultiUnitField($field)) {
156			return $this->getMultiUnitColumns()[$field]['supported_units'];
157			}
158
159			throw new NotSupportedMultiUnitField($field);
160			}
161
162			/**
163			* @param $field
164			*
165			* @throws NotSupportedMultiUnitField
166			*
167			* @return AbstractUnit
168			*/
169			public function getMultiUnitFieldDefaultUnit($field)
170			{
171			if ($this->isMultiUnitField($field)) {
172			$unitClass = $this->getMultiUnitColumns()[$field]['default_unit'];
173
174			return new $unitClass();
175			}
176
177			throw new NotSupportedMultiUnitField($field);
178			}
179
180			/**
181			* @param $field
182			* @param AbstractUnit\|null $unit
183			*
184			* @throws NotSupportedMultiUnitField
185			*
186			* @return mixed
187			*/
188			public function getMultiUnitFieldValue($field, AbstractUnit $unit = null)
189			{
190			if ($this->isMultiUnitField($field)) {
191			if (isset($this->{$field})) {
192			if (is_null($unit)) {
193			$unit = $this->getMultiUnitFieldUnit($field);
194			}
195			$existingConversionData = $this->getMultiUnitExistingConversionData($field);
196			if (!is_null($existingConversionData) && !is_null($existingConversionData->{$unit->getSymbol()})) {
197			return $existingConversionData->{$unit->getSymbol()};
198			}
199
200			return ($this->getMultiUnitFieldDefaultUnit($field)->setValue($this->{$field}))->as(new $unit());
201			} else {
202			return;
203			}
204			}
205
206			throw new NotSupportedMultiUnitField($field);
207			}
208
209			protected function isMultiUnitField($field)
210			{
211			return isset($this->getMultiUnitColumns()[$field]);
212			}
213
214			/**
215			* @param $field
216			*
217			* @throws NotSupportedMultiUnitField
218			*
219			* @return AbstractUnit
220			*/
221			protected function getMultiUnitFieldUnit($field)
222			{
223			if (isset($this->{$field.$this->getUnitAttributePostfix()})) {
224			foreach ($this->getMultiUnitFieldSupportedUnits($field) as $unitClass) {
225			/**
226			* @var AbstractUnit $unit
227			*/
228			$unit = new $unitClass();
229			if (strtolower($unit->getSymbol()) == strtolower($this->{$field.$this->getUnitAttributePostfix()})) {
230			return $unit;
231			}
232			}
233			}
234
235			return $this->getMultiUnitFieldDefaultUnit($field);
236			}
237
238			protected function forgetMultiUnitFieldUnitInput($field)
239			{
240			//prevent column_units to by saved to DB
241			if (isset($this->attributes[$field.$this->getUnitAttributePostfix()])) {
			0 ignored issues – show Bug introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
242			$this->syncOriginalAttribute($field.$this->getUnitAttributePostfix());
			0 ignored issues – show Bug introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report It seems like `syncOriginalAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
243			}
244			}
245
246			protected function setMultiUnitFieldUnit($field, AbstractUnit $unit)
247			{
248			$this->{$field.$this->getUnitAttributePostfix()} = $unit->getSymbol();
249			$this->forgetMultiUnitFieldUnitInput($field);
250			}
251
252			/**
253			* @param $field
254			*
255			* @throws NotSupportedMultiUnitField
256			*/
257			protected function resetMultiUnitFieldUnit($field)
258			{
259			$this->setMultiUnitFieldUnit($field, $this->getMultiUnitFieldDefaultUnit($field));
260			}
261
262			/**
263			* Determine if a set mutator exists for an attribute.
264			*
265			* @param string $key
266			*
267			* @return bool
268			*/
269			public function hasSetMutator($key)
270			{
271			if ($this->isMultiUnitField($key)) {
272			return true;
273			}
274
275			return parent::hasSetMutator($key);
276			}
277
278			/**
279			* Set the value of an attribute using its mutator.
280			*
281			* @param string $key
282			* @param mixed $value
283			*
284			* @throws NotSupportedMultiUnitField
285			*
286			* @return mixed
287			*/
288			protected function setMutatedAttributeValue($key, $value)
289			{
290			if ($this->isMultiUnitField($key)) {
291			$value = $this->processMultiUnitFieldChanges($key, $value);
292			$this->attributes[$key] = $value;
293
294			return $value;
295			}
296
297			parent::setMutatedAttributeValue($key, $value);
298			}
299
300			/**
301			* Detect changes and set proper base value.
302			*
303			* @param $field
304			* @param $value
305			*
306			* @throws NotSupportedMultiUnitField
307			*
308			* @return mixed
309			*/
310			private function processMultiUnitFieldChanges($field, $value)
311			{
312			$existingConversionData = $this->getMultiUnitExistingConversionData($field);
313			if (!is_null($existingConversionData)) {
314			$inputUnit = $this->getMultiUnitFieldUnit($field);
315			//change existing value only in case if new value doesn't match with stored conversion table or not exists
316			if (!isset($existingConversionData->{$inputUnit->getSymbol()}) \|\| $value != $existingConversionData->{$inputUnit->getSymbol()}) {
317			$this->resetMultiUnitFieldUnit($field);
318
319			return (new $inputUnit($value))->as($this->getMultiUnitFieldDefaultUnit($field));
320			} elseif ($value == $existingConversionData->{$inputUnit->getSymbol()}) {
321			//forget changes if value actually isn't changed
322			$this->resetMultiUnitFieldUnit($field);
323			$originalValue = $existingConversionData->{$this->getMultiUnitFieldDefaultUnit($field)->getSymbol()};
324			$this->attributes[$field] = $originalValue;
325			$this->syncOriginalAttribute($field);
			0 ignored issues – show Bug introduced 2019-05-03 03:07 UTC by Report Bug Copy Issue Report It seems like `syncOriginalAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
326
327			return $originalValue;
328			}
329			$this->resetMultiUnitFieldUnit($field);
330			}
331
332			return $value;
333			}
334
335			/**
336			* Determine if a get mutator exists for an attribute.
337			*coo.
338			*
339			* @param string $key
340			*
341			* @return bool
342			*/
343			public function hasGetMutator($key)
344			{
345			if ($this->isMultiUnitField($key) && isset($this->{$key})) {
346			return true;
347			}
348
349			return parent::hasGetMutator($key);
350			}
351
352			/**
353			* Get the value of an attribute using its mutator.
354			*
355			* @param string $key
356			* @param mixed $value
357			*
358			* @throws NotSupportedMultiUnitField
359			*
360			* @return mixed
361			*/
362			public function mutateAttribute($key, $value)
363			{
364			if ($this->isMultiUnitField($key)) {
365			$requestedUnit = $this->getMultiUnitFieldUnit($key);
366
367			return $this->getMultiUnitFieldValue($key, new $requestedUnit());
368			}
369
370			return parent::mutateAttribute($key, $value);
371			}
372			}
373

maksimru / multi-unit-models

Push — master ( b73c64...168e7d )

MultiUnitSupport B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like