MaksimM\CompositePrimaryKeys\Http\Traits\CompositeRelationships::belongsTo()

Complexity

Conditions	5
Paths	6

Size

Total Lines	30
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function belongsTo($related, $foreignKey = null, $ownerKey = null, $relation = null)
    {
        // If no relation name was given, we will use this debug backtrace to extract
        // the calling method's name and use that as the relationship name as most
        // of the time this will be what we desire to use for the relationships.
        if (is_null($relation)) {

The condition is_null($relation) is always true.

            $relation = $this->guessBelongsToRelation();

It seems like guessBelongsToRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        /**
         * @var Model $instance
         */
        $instance = $this->newRelatedInstance($related);

It seems like newRelatedInstance() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // If no foreign key was supplied, we can use a backtrace to guess the proper
        // foreign key name by using the name of the relationship function, which
        // when combined with an "_id" should conventionally match the columns.
        if (is_null($foreignKey)) {

The condition is_null($foreignKey) is always true.

            $foreignKey = is_array($instance->getKeyName()) ? array_map(function($key) use ($relation) {

The condition is_array($instance->getKeyName()) is always false.

                return Str::snake($relation).'_'.$key;
            }, $instance->getKeyName()) : Str::snake($relation).'_'.$instance->getKeyName();
        }

        // Once we have the foreign key names, we'll just create a new Eloquent query
        // for the related models and returns the relationship instance which will
        // actually be responsible for retrieving and hydrating every relations.
        $ownerKey = $ownerKey ?: $instance->getKeyName();

$ownerKey is of type null, thus it always evaluated to false.

        return $this->newBelongsTo(
            $instance->newQuery(), $this, $foreignKey, $ownerKey, $relation

$this of type MaksimM\CompositePrimaryKeys\Http\Traits\CompositeRelationships is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $child of MaksimM\CompositePrimaryKeys\Http\Traits\CompositeRelationships::newBelongsTo().

        );
}