majiameng / uploads

src/Connector/Gateway.php

<?php
namespace tinymeng\uploads\Connector;

/**
 * 所有第三方上传类必须继承的抽象类
 */
abstract class Gateway implements GatewayInterface
{
    /**
     * 配置信息
     *
     * @var
     */
    protected $config;

    /**
     * @var string|null path prefix
     */
    protected $pathPrefix;

    /**
     * @var string
     */
    protected $pathSeparator = '/';
    /**
     * @var 
     */
    protected $client;


    /**
     * Gateway constructor.
     * @param null $config

Are you sure the doc-type for parameter $config is correct as it would always require null to be passed?

     * @throws \Exception
     */
    public function __construct($config = null)
    {
        if (!$config) {

$config is of type null, thus it always evaluated to false.

            throw new \Exception('传入的配置不能为空');
        }
        $this->config    = $config;
    }

    /**
     * Set the path prefix.
     * @param string $prefix
     * @return void
     */
    public function setPathPrefix($prefix)
    {
        $prefix = (string) $prefix;

        if ($prefix === '') {
            $this->pathPrefix = null;
            return;
        }

        $this->pathPrefix = rtrim($prefix, '\\/') . $this->pathSeparator;
    }

    /**
     * Get the path prefix.
     * @return string|null path prefix or null if pathPrefix is empty
     */
    public function getPathPrefix()
    {
        return $this->pathPrefix;
    }

    /**
     * Prefix a path.
     * @param string $path
     * @return string prefixed path
     */
    public function applyPathPrefix($path)
    {
        return $this->getPathPrefix() . ltrim($path, '\\/');
    }

    /**
     * Remove a path prefix.
     * @param string $path
     * @return string path without the prefix
     */
    public function removePathPrefix($path)
    {
        return substr($path, strlen($this->getPathPrefix()));

It seems like $this->getPathPrefix() can also be of type null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

    }


}