tinymeng\spreadsheet\Excel\Handler\MergeHandler::autoMergeColumns()

Complexity

Conditions	9
Paths	11

Size

Total Lines	31
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function autoMergeColumns(
        Worksheet $worksheet,
        array $mergeColumns,
        array $fields,
        int $rowStart,
        int $rowEnd
    ) {
        if ($rowEnd <= $rowStart) return;
        
        foreach ($mergeColumns as $fieldName) {
            $colIdx = array_search($fieldName, $fields);
            if ($colIdx === false) continue;
            
            $colLetter = WorkSheetHelper::cellName($colIdx);

It seems like $colIdx can also be of type string; however, parameter $columnIndex of tinymeng\spreadsheet\Util\WorkSheetHelper::cellName() does only seem to accept integer, maybe add an additional type check?

            $lastValue = null;
            $mergeStart = $rowStart;
            
            for ($row = $rowStart; $row <= $rowEnd; $row++) {
                $cellValue = $worksheet->getCell($colLetter . $row)->getValue();
                if ($lastValue !== null && $cellValue !== $lastValue) {
                    if ($row - $mergeStart > 1) {
                        $worksheet->mergeCells($colLetter . $mergeStart . ':' . $colLetter . ($row - 1));
                    }
                    $mergeStart = $row;
                }
                $lastValue = $cellValue;
            }
            
            // 处理最后一组
            if ($rowEnd - $mergeStart + 1 > 1) {
                $worksheet->mergeCells($colLetter . $mergeStart . ':' . $colLetter . $rowEnd);
            }