Conditions | 10 |
Paths | 36 |
Total Lines | 35 |
Code Lines | 29 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
75 | public static function random(int $length = 6, int $type = null, string $addChars = ''): string |
||
76 | { |
||
77 | $str = ''; |
||
78 | switch ($type) { |
||
79 | case 0: |
||
|
|||
80 | $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz' . $addChars; |
||
81 | break; |
||
82 | case 1: |
||
83 | $chars = str_repeat('0123456789', 3); |
||
84 | break; |
||
85 | case 2: |
||
86 | $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' . $addChars; |
||
87 | break; |
||
88 | case 3: |
||
89 | $chars = 'abcdefghijklmnopqrstuvwxyz' . $addChars; |
||
90 | break; |
||
91 | case 4: |
||
92 | $chars = "们以我到他会作时要动国产的一是工就年阶义发成部民可出能方进在了不和有大这主中人上为来分生对于学下级地个用同行面说种过命度革而多子后自社加小机也经力线本电高量长党得实家定深法表着水理化争现所二起政三好十战无农使性前等反体合斗路图把结第里正新开论之物从当两些还天资事队批点育重其思与间内去因件日利相由压员气业代全组数果期导平各基或月毛然如应形想制心样干都向变关问比展那它最及外没看治提五解系林者米群头意只明四道马认次文通但条较克又公孔领军流入接席位情运器并飞原油放立题质指建区验活众很教决特此常石强极土少已根共直团统式转别造切九你取西持总料连任志观调七么山程百报更见必真保热委手改管处己将修支识病象几先老光专什六型具示复安带每东增则完风回南广劳轮科北打积车计给节做务被整联步类集号列温装即毫知轴研单色坚据速防史拉世设达尔场织历花受求传口断况采精金界品判参层止边清至万确究书" . $addChars; |
||
93 | break; |
||
94 | default: |
||
95 | $chars = 'ABCDEFGHIJKMNPQRSTUVWXYZabcdefghijkmnpqrstuvwxyz23456789' . $addChars; |
||
96 | break; |
||
97 | } |
||
98 | if ($length > 10) { |
||
99 | $chars = $type == 1 ? str_repeat($chars, $length) : str_repeat($chars, 5); |
||
100 | } |
||
101 | if ($type != 4) { |
||
102 | $chars = str_shuffle($chars); |
||
103 | $str = substr($chars, 0, $length); |
||
104 | } else { |
||
105 | for ($i = 0; $i < $length; $i++) { |
||
106 | $str .= mb_substr($chars, floor(mt_rand(0, mb_strlen($chars, 'utf-8') - 1)), 1); |
||
107 | } |
||
108 | } |
||
109 | return $str; |
||
110 | } |
||
226 | } |