tinymeng\Chinaums\Service\Contract\StoreChangeSign

Complexity

Total Complexity

3

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	getUrl()	0	21	3

<?php

namespace tinymeng\Chinaums\Service\Contract;

use tinymeng\Chinaums\Service\Contract\Base;
use tinymeng\Chinaums\Tools\DES;
use Exception;

/**
 * 分店变更签约接口
 */
class StoreChangeSign extends Base
{
    /**
     * @var string 接口地址
     */
    protected $api = '/self-contract-nmrs/interface/autoReg';
    /**
     * @var array $body 请求参数
     */
    protected $body = [
        'service' => 'store_change_sign',
        'sign_type' => 'SHA-256',
    ];
    /**
     * 必传的值
     * @var array
     */
    protected $require = ['service', 'accesser_id', 'sign_type', 'request_date', 'request_seq', 'ums_reg_id'];

    /**
     * 获取get前端签约方式
     * @param array $data
     * @return void
     */
    public function getUrl($data = [])
    {
        $data['accesser_id'] = $this->config['accesser_id'];
        $key = $this->config['private_key'];
        if ($data) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

$data is a non-empty array, thus is always true.

            $this->body = array_merge($this->body, $data);
        }
        try {
            $this->validate();
            $data = $this->body;
            $gateway  = $this->config['gateway'] . $this->api;
            $data = json_encode($data);
            $sign = hash('sha256', $data);
            $method = $this->method;
            $des = new DES($key, $method, DES::OUTPUT_HEX);
            // 加密
            $str = $des->encrypt($data);
            $url = $gateway . '?sign_data=' . $sign . '&json_data=' . $str . '&accesser_id=' . $this->config['accesser_id'];
            return json_encode(['res_code' => '0000', 'res_msg' => 'success', 'url' => $url], JSON_UNESCAPED_SLASHES);

The expression return json_encode(array('res_code' => '0000', 'res_msg' => 'success', 'url' => $url), tinymeng\Chinaums\Service\Contract\JSON_UNESCAPED_SLASHES) returns the type string which is incompatible with the documented return type void.

        } catch (Exception $e) {
            return json_encode(['res_code' => -1, 'res_msg' => $e->getMessage(), 'request_seq' => null]);

The expression return json_encode(array('res_code' => -1, 'res_msg' => $e->getMessage(), 'request_seq' => null)) returns the type string which is incompatible with the documented return type void.

        }
    }
}