MailMotor\Bundle\MailMotorBundle\Factory\MailMotorFactory

Complexity

Total Complexity

5

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getSubscriberGateway()	0	3	1
A	setMailEngine()	0	7	3
A	__construct()	0	6	1

<?php

namespace MailMotor\Bundle\MailMotorBundle\Factory;

use Symfony\Component\DependencyInjection\ServiceLocator;
use MailMotor\Bundle\MailMotorBundle\Gateway\SubscriberGateway;

/**
 * This is the class that loads and manages your bundle configuration
 *
 * @author Jeroen Desloovere <info@jeroendesloovere.be>
 */
class MailMotorFactory
{
    /** @var ServiceLocator */
    protected $serviceLocator;

    /** @var string|null */
    protected $mailEngine;

    public function __construct(
        ServiceLocator $serviceLocator,
        ?string $mailEngine
    ) {
        $this->serviceLocator = $serviceLocator;
        $this->setMailEngine($mailEngine);
    }

    public function getSubscriberGateway(): SubscriberGateway
    {
        return $this->serviceLocator->get($this->mailEngine);

It seems like $this->mailEngine can also be of type null; however, parameter $id of Symfony\Component\DependencyInjection\ServiceLocator::get() does only seem to accept string, maybe add an additional type check?

    }

    protected function setMailEngine(?string $mailEngine): void
    {
        if ($mailEngine === null || !$this->serviceLocator->has($mailEngine)) {
            $mailEngine = 'not_implemented';
        }

        $this->mailEngine = strtolower($mailEngine);
    }
}