ShowResponse - Code Metrics - Inspection of "Renamed namespace from Resource\Api to Model (#293..." - mailgun/mailgun-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da873d...74929b )

by Tobias

created 2017-02-23 19:56 UTC

ShowResponse A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	83
Duplicated Lines	12.05 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	10
lcom	0
cbo	2
dl	10
loc	83
ccs	0
cts	29
cp	0
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	create()	10	24	6
A	__construct()	0	6	1
A	getDomain()	0	4	1
A	getInboundDNSRecords()	0	4	1
A	getOutboundDNSRecords()	0	4	1

How to fix Duplicated Code

<?php

/*
 * Copyright (C) 2013-2016 Mailgun
 *
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Mailgun\Model\Domain;

use Mailgun\Model\ApiResponse;

/**
 * @author Sean Johnson <[email protected]>
 */
final class ShowResponse implements ApiResponse
{
    /**
     * @var Domain
     */
    private $domain;

    /**
     * @var DnsRecord[]
     */
    private $inboundDnsRecords;

    /**
     * @var DnsRecord[]
     */
    private $outboundDnsRecords;

    /**
     * @param array $data
     *
     * @return self
     */
    public static function create(array $data)
    {
        $rx = [];
        $tx = [];
        $domain = null;

        if (isset($data['domain'])) {
            $domain = Domain::create($data['domain']);
        }

        if (isset($data['receiving_dns_records'])) {

            foreach ($data['receiving_dns_records'] as $item) {
                $rx[] = DnsRecord::create($item);
            }
        }

        if (isset($data['sending_dns_records'])) {

            foreach ($data['sending_dns_records'] as $item) {
                $tx[] = DnsRecord::create($item);
            }
        }

        return new self($domain, $rx, $tx);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    /**
     * @param Domain      $domainInfo
     * @param DnsRecord[] $rxRecords
     * @param DnsRecord[] $txRecords
     */
    private function __construct(Domain $domainInfo, array $rxRecords, array $txRecords)
    {
        $this->domain = $domainInfo;
        $this->inboundDnsRecords = $rxRecords;
        $this->outboundDnsRecords = $txRecords;
    }

    /**
     * @return Domain
     */
    public function getDomain()
    {
        return $this->domain;
    }

    /**
     * @return DnsRecord[]
     */
    public function getInboundDNSRecords()
    {
        return $this->inboundDnsRecords;
    }

    /**
     * @return DnsRecord[]
     */
    public function getOutboundDNSRecords()
    {
        return $this->outboundDnsRecords;
    }
}


1		<?php
2
3		/*
4		* Copyright (C) 2013-2016 Mailgun
5		*
6		* This software may be modified and distributed under the terms
7		* of the MIT license. See the LICENSE file for details.
8		*/
9
10		namespace Mailgun\Model\Domain;
11
12		use Mailgun\Model\ApiResponse;
13
14		/**
15		* @author Sean Johnson <[email protected]>
16		*/
17		final class ShowResponse implements ApiResponse
18		{
19		/**
20		* @var Domain
21		*/
22		private $domain;
23
24		/**
25		* @var DnsRecord[]
26		*/
27		private $inboundDnsRecords;
28
29		/**
30		* @var DnsRecord[]
31		*/
32		private $outboundDnsRecords;
33
34		/**
35		* @param array $data
36		*
37		* @return self
38		*/
39		public static function create(array $data)
40		{
41		$rx = [];
42		$tx = [];
43		$domain = null;
44
45		if (isset($data['domain'])) {
46		$domain = Domain::create($data['domain']);
47		}
48
49	View Code Duplication	if (isset($data['receiving_dns_records'])) {
		0 ignored issues – show Duplication introduced 2016-12-06 06:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		foreach ($data['receiving_dns_records'] as $item) {
51		$rx[] = DnsRecord::create($item);
52		}
53		}
54
55	View Code Duplication	if (isset($data['sending_dns_records'])) {
		0 ignored issues – show Duplication introduced 2016-12-06 06:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		foreach ($data['sending_dns_records'] as $item) {
57		$tx[] = DnsRecord::create($item);
58		}
59		}
60
61		return new self($domain, $rx, $tx);
		0 ignored issues – show Bug introduced 2017-02-23 20:00 UTC by Report Bug Copy Issue Report It seems like `$domain` defined by `null` on line `43` can be `null`; however, `Mailgun\Model\Domain\ShowResponse::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
62		}
63
64		/**
65		* @param Domain $domainInfo
66		* @param DnsRecord[] $rxRecords
67		* @param DnsRecord[] $txRecords
68		*/
69		private function __construct(Domain $domainInfo, array $rxRecords, array $txRecords)
70		{
71		$this->domain = $domainInfo;
72		$this->inboundDnsRecords = $rxRecords;
73		$this->outboundDnsRecords = $txRecords;
74		}
75
76		/**
77		* @return Domain
78		*/
79		public function getDomain()
80		{
81		return $this->domain;
82		}
83
84		/**
85		* @return DnsRecord[]
86		*/
87		public function getInboundDNSRecords()
88		{
89		return $this->inboundDnsRecords;
90		}
91
92		/**
93		* @return DnsRecord[]
94		*/
95		public function getOutboundDNSRecords()
96		{
97		return $this->outboundDnsRecords;
98		}
99		}
100

mailgun / mailgun-php

Push — master ( da873d...74929b )

ShowResponse A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like