CreateResponse - Code Metrics - Inspection of "Renamed namespace from Resource\Api to Model (#293..." - mailgun/mailgun-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da873d...74929b )

by Tobias

created 2017-02-23 19:56 UTC

CreateResponse A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	103
Duplicated Lines	9.71 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	12
lcom	0
cbo	2
dl	10
loc	103
ccs	0
cts	36
cp	0
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
C	create()	10	29	7
A	__construct()	0	7	1
A	getDomain()	0	4	1
A	getInboundDNSRecords()	0	4	1
A	getOutboundDNSRecords()	0	4	1
A	getMessage()	0	4	1

How to fix Duplicated Code

<?php

/*
 * Copyright (C) 2013-2016 Mailgun
 *
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Mailgun\Model\Domain;

use Mailgun\Model\ApiResponse;

/**
 * @author Tobias Nyholm <[email protected]>
 */
final class CreateResponse implements ApiResponse
{
    /**
     * @var string
     */
    private $message;

    /**
     * @var Domain
     */
    private $domain;

    /**
     * @var DnsRecord[]
     */
    private $inboundDnsRecords;

    /**
     * @var DnsRecord[]
     */
    private $outboundDnsRecords;

    /**
     * @param array $data
     *
     * @return self
     */
    public static function create(array $data)
    {
        $rx = [];
        $tx = [];
        $domain = null;
        $message = null;

        if (isset($data['domain'])) {
            $domain = Domain::create($data['domain']);
        }

        if (isset($data['message'])) {
            $message = $data['message'];
        }

        if (isset($data['receiving_dns_records'])) {

            foreach ($data['receiving_dns_records'] as $item) {
                $rx[] = DnsRecord::create($item);
            }
        }

        if (isset($data['sending_dns_records'])) {

            foreach ($data['sending_dns_records'] as $item) {
                $tx[] = DnsRecord::create($item);
            }
        }

        return new self($domain, $rx, $tx, $message);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    /**
     * @param Domain      $domainInfo
     * @param DnsRecord[] $rxRecords
     * @param DnsRecord[] $txRecords
     * @param string      $message
     */
    private function __construct(Domain $domainInfo, array $rxRecords, array $txRecords, $message)
    {
        $this->domain = $domainInfo;
        $this->inboundDnsRecords = $rxRecords;
        $this->outboundDnsRecords = $txRecords;
        $this->message = $message;
    }

    /**
     * @return Domain
     */
    public function getDomain()
    {
        return $this->domain;
    }

    /**
     * @return DnsRecord[]
     */
    public function getInboundDNSRecords()
    {
        return $this->inboundDnsRecords;
    }

    /**
     * @return DnsRecord[]
     */
    public function getOutboundDNSRecords()
    {
        return $this->outboundDnsRecords;
    }

    /**
     * @return string
     */
    public function getMessage()
    {
        return $this->message;
    }
}


1		<?php
2
3		/*
4		* Copyright (C) 2013-2016 Mailgun
5		*
6		* This software may be modified and distributed under the terms
7		* of the MIT license. See the LICENSE file for details.
8		*/
9
10		namespace Mailgun\Model\Domain;
11
12		use Mailgun\Model\ApiResponse;
13
14		/**
15		* @author Tobias Nyholm <[email protected]>
16		*/
17		final class CreateResponse implements ApiResponse
18		{
19		/**
20		* @var string
21		*/
22		private $message;
23
24		/**
25		* @var Domain
26		*/
27		private $domain;
28
29		/**
30		* @var DnsRecord[]
31		*/
32		private $inboundDnsRecords;
33
34		/**
35		* @var DnsRecord[]
36		*/
37		private $outboundDnsRecords;
38
39		/**
40		* @param array $data
41		*
42		* @return self
43		*/
44		public static function create(array $data)
45		{
46		$rx = [];
47		$tx = [];
48		$domain = null;
49		$message = null;
50
51		if (isset($data['domain'])) {
52		$domain = Domain::create($data['domain']);
53		}
54
55		if (isset($data['message'])) {
56		$message = $data['message'];
57		}
58
59	View Code Duplication	if (isset($data['receiving_dns_records'])) {
		0 ignored issues – show Duplication introduced 2016-12-06 06:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		foreach ($data['receiving_dns_records'] as $item) {
61		$rx[] = DnsRecord::create($item);
62		}
63		}
64
65	View Code Duplication	if (isset($data['sending_dns_records'])) {
		0 ignored issues – show Duplication introduced 2016-12-06 06:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		foreach ($data['sending_dns_records'] as $item) {
67		$tx[] = DnsRecord::create($item);
68		}
69		}
70
71		return new self($domain, $rx, $tx, $message);
		0 ignored issues – show Bug introduced 2017-02-23 20:00 UTC by Report Bug Copy Issue Report It seems like `$domain` defined by `null` on line `48` can be `null`; however, `Mailgun\Model\Domain\CreateResponse::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
72		}
73
74		/**
75		* @param Domain $domainInfo
76		* @param DnsRecord[] $rxRecords
77		* @param DnsRecord[] $txRecords
78		* @param string $message
79		*/
80		private function __construct(Domain $domainInfo, array $rxRecords, array $txRecords, $message)
81		{
82		$this->domain = $domainInfo;
83		$this->inboundDnsRecords = $rxRecords;
84		$this->outboundDnsRecords = $txRecords;
85		$this->message = $message;
86		}
87
88		/**
89		* @return Domain
90		*/
91		public function getDomain()
92		{
93		return $this->domain;
94		}
95
96		/**
97		* @return DnsRecord[]
98		*/
99		public function getInboundDNSRecords()
100		{
101		return $this->inboundDnsRecords;
102		}
103
104		/**
105		* @return DnsRecord[]
106		*/
107		public function getOutboundDNSRecords()
108		{
109		return $this->outboundDnsRecords;
110		}
111
112		/**
113		* @return string
114		*/
115		public function getMessage()
116		{
117		return $this->message;
118		}
119		}
120

mailgun / mailgun-php

Push — master ( da873d...74929b )

CreateResponse A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like