Mailgun::setApiVersion() - Code Metrics - Inspection of "Messages api" - mailgun/mailgun-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#247)

by Tobias

created 2016-12-07 21:50 UTC

Mailgun::setApiVersion() A

↳ Parent: Mailgun

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	2

<?PHP

/*
 * Copyright (C) 2013-2016 Mailgun
 *
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Mailgun;

use Http\Client\Common\HttpMethodsClient;
use Http\Client\HttpClient;
use Mailgun\Connection\RestClient;
use Mailgun\Constants\ExceptionMessages;
use Mailgun\Lists\OptInHandler;
use Mailgun\Messages\BatchMessage;
use Mailgun\Messages\Exceptions;
use Mailgun\Messages\MessageBuilder;
use Mailgun\Deserializer\ModelDeserializer;
use Mailgun\Deserializer\ResponseDeserializer;

/**
 * This class is the base class for the Mailgun SDK.
 */
class Mailgun
{
    /**
     * @var RestClient
     *
     * @depracated Will be removed in 3.0
     */
    protected $restClient;

    /**
     * @var null|string
     */
    protected $apiKey;

    /**
     * @var HttpMethodsClient
     */
    private $httpClient;

    /**
     * @var ResponseDeserializer
     */
    private $deserializer;

    /**
     * @var RequestBuilder
     */
    private $requestBuilder;

    /**
     * @param string|null                 $apiKey
     * @param HttpClient|null             $httpClient
     * @param string                      $apiEndpoint
     * @param ResponseDeserializer|null   $deserializer
     * @param HttpClientConfigurator|null $clientConfigurator
     * @param RequestBuilder|null         $requestBuilder
     */
    public function __construct(
        $apiKey = null,
        HttpClient $httpClient = null, /* Deprecated, will be removed in 3.0 */
        $apiEndpoint = 'api.mailgun.net', /* Deprecated, will be removed in 3.0 */
        ResponseDeserializer $deserializer = null,
        HttpClientConfigurator $clientConfigurator = null,
        RequestBuilder $requestBuilder = null
    ) {
        $this->apiKey = $apiKey;
        $this->restClient = new RestClient($apiKey, $apiEndpoint, $httpClient);

        if (null === $clientConfigurator) {
            $clientConfigurator = new HttpClientConfigurator();

            /*
             * To be backward compatible
             */
            if ($apiEndpoint !== 'api.mailgun.net') {
                $clientConfigurator->setEndpoint($apiEndpoint);
            }
            if ($httpClient !== null) {
                $clientConfigurator->setHttpClient($httpClient);
            }
        }

        $clientConfigurator->setApiKey($apiKey);

        $this->httpClient = $clientConfigurator->createConfiguredClient();

        $this->requestBuilder = $requestBuilder ?: new RequestBuilder();
        $this->deserializer = $deserializer ?: new ModelDeserializer();
    }

    /**
     *  This function allows the sending of a fully formed message OR a custom
     *  MIME string. If sending MIME, the string must be passed in to the 3rd
     *  position of the function call.
     *
     * @param string $workingDomain
     * @param array  $postData
     * @param array  $postFiles
     *
     * @throws Exceptions\MissingRequiredMIMEParameters
     *
     * @return \stdClass
     */
    public function sendMessage($workingDomain, $postData, $postFiles = [])
    {
        if (is_array($postFiles)) {
            return $this->post("$workingDomain/messages", $postData, $postFiles);
        } elseif (is_string($postFiles)) {
            $tempFile = tempnam(sys_get_temp_dir(), 'MG_TMP_MIME');
            $fileHandle = fopen($tempFile, 'w');
            fwrite($fileHandle, $postFiles);

            $result = $this->post("$workingDomain/messages.mime", $postData, ['message' => $tempFile]);
            fclose($fileHandle);
            unlink($tempFile);

            return $result;
        } else {
            throw new Exceptions\MissingRequiredMIMEParameters(ExceptionMessages::EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS);
        }
    }

    /**
     * This function checks the signature in a POST request to see if it is
     * authentic.
     *
     * Pass an array of parameters.  If you pass nothing, $_POST will be
     * used instead.
     *
     * If this function returns FALSE, you must not process the request.
     * You should reject the request with status code 403 Forbidden.
     *
     * @param array|null $postData
     *
     * @return bool
     */
    public function verifyWebhookSignature($postData = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($postData === null) {
            $postData = $_POST;
        }
        if (!isset($postData['timestamp']) || !isset($postData['token']) || !isset($postData['signature'])) {
            return false;
        }
        $hmac = hash_hmac('sha256', "{$postData['timestamp']}{$postData['token']}", $this->apiKey);
        $sig = $postData['signature'];
        if (function_exists('hash_equals')) {
            // hash_equals is constant time, but will not be introduced until PHP 5.6
            return hash_equals($hmac, $sig);
        } else {
            return $hmac === $sig;
        }
    }

    /**
     * @param string $endpointUrl
     * @param array  $postData
     * @param array  $files
     *
     * @return \stdClass
     */
    public function post($endpointUrl, $postData = [], $files = [])
    {
        return $this->restClient->post($endpointUrl, $postData, $files);
    }

    /**
     * @param string $endpointUrl
     * @param array  $queryString
     *
     * @return \stdClass
     */
    public function get($endpointUrl, $queryString = [])
    {
        return $this->restClient->get($endpointUrl, $queryString);
    }

    /**
     * @param string $endpointUrl
     *
     * @return \stdClass
     */
    public function delete($endpointUrl)
    {
        return $this->restClient->delete($endpointUrl);
    }

    /**
     * @param string $endpointUrl
     * @param array  $putData
     *
     * @return \stdClass
     */
    public function put($endpointUrl, $putData)
    {
        return $this->restClient->put($endpointUrl, $putData);
    }

    /**
     * @param string $apiVersion
     *
     * @return Mailgun
     */
    public function setApiVersion($apiVersion)
    {
        $this->restClient->setApiVersion($apiVersion);

        return $this;
    }

    /**
     * @param bool $sslEnabled
     *
     * @return Mailgun
     *
     * @deprecated This will be removed in 3.0. Mailgun does not support non-secure connections to their API.
     */
    public function setSslEnabled($sslEnabled)
    {
        $this->restClient->setSslEnabled($sslEnabled);


        return $this;
    }

    /**
     * @return MessageBuilder
     */
    public function MessageBuilder()
    {
        return new MessageBuilder();
    }

    /**
     * @return OptInHandler
     */
    public function OptInHandler()
    {
        return new OptInHandler();
    }

    /**
     * @param string $workingDomain
     * @param bool   $autoSend
     *
     * @return BatchMessage
     */
    public function BatchMessage($workingDomain, $autoSend = true)
    {
        return new BatchMessage($this->restClient, $workingDomain, $autoSend);
    }

    /**
     * @return Api\Stats
     */
    public function stats()
    {
        return new Api\Stats($this->httpClient, $this->requestBuilder, $this->deserializer);
    }

    /**
     * @return Api\Domain
     */
    public function domains()
    {
        return new Api\Domain($this->httpClient, $this->requestBuilder, $this->deserializer);
    }

    /**
     * @return Api\Event
     */
    public function events()
    {
        return new Api\Event($this->httpClient, $this->requestBuilder, $this->deserializer);
    }

    /**
     * @return Api\Webhook
     */
    public function webhooks()
    {
        return new Api\Webhook($this->httpClient, $this->requestBuilder, $this->deserializer);
    }

    /**
     * @return Api\Message
     */
    public function messages()
    {
        return new Api\Message($this->httpClient, $this->requestBuilder, $this->deserializer);
    }
}


1		<?PHP
2
3		/*
4		* Copyright (C) 2013-2016 Mailgun
5		*
6		* This software may be modified and distributed under the terms
7		* of the MIT license. See the LICENSE file for details.
8		*/
9
10		namespace Mailgun;
11
12		use Http\Client\Common\HttpMethodsClient;
13		use Http\Client\HttpClient;
14		use Mailgun\Connection\RestClient;
15		use Mailgun\Constants\ExceptionMessages;
16		use Mailgun\Lists\OptInHandler;
17		use Mailgun\Messages\BatchMessage;
18		use Mailgun\Messages\Exceptions;
19		use Mailgun\Messages\MessageBuilder;
20		use Mailgun\Deserializer\ModelDeserializer;
21		use Mailgun\Deserializer\ResponseDeserializer;
22
23		/**
24		* This class is the base class for the Mailgun SDK.
25		*/
26		class Mailgun
27		{
28		/**
29		* @var RestClient
30		*
31		* @depracated Will be removed in 3.0
32		*/
33		protected $restClient;
34
35		/**
36		* @var null\|string
37		*/
38		protected $apiKey;
39
40		/**
41		* @var HttpMethodsClient
42		*/
43		private $httpClient;
44
45		/**
46		* @var ResponseDeserializer
47		*/
48		private $deserializer;
49
50		/**
51		* @var RequestBuilder
52		*/
53		private $requestBuilder;
54
55		/**
56		* @param string\|null $apiKey
57		* @param HttpClient\|null $httpClient
58		* @param string $apiEndpoint
59		* @param ResponseDeserializer\|null $deserializer
60		* @param HttpClientConfigurator\|null $clientConfigurator
61		* @param RequestBuilder\|null $requestBuilder
62		*/
63	4	public function __construct(
64		$apiKey = null,
65		HttpClient $httpClient = null, /* Deprecated, will be removed in 3.0 */
66		$apiEndpoint = 'api.mailgun.net', /* Deprecated, will be removed in 3.0 */
67		ResponseDeserializer $deserializer = null,
68		HttpClientConfigurator $clientConfigurator = null,
69		RequestBuilder $requestBuilder = null
70		) {
71	4	$this->apiKey = $apiKey;
72	4	$this->restClient = new RestClient($apiKey, $apiEndpoint, $httpClient);
73
74	4	if (null === $clientConfigurator) {
75	4	$clientConfigurator = new HttpClientConfigurator();
76
77		/*
78		* To be backward compatible
79		*/
80	4	if ($apiEndpoint !== 'api.mailgun.net') {
81		$clientConfigurator->setEndpoint($apiEndpoint);
82		}
83	4	if ($httpClient !== null) {
84		$clientConfigurator->setHttpClient($httpClient);
85		}
86	4	}
87
88	4	$clientConfigurator->setApiKey($apiKey);
89
90	4	$this->httpClient = $clientConfigurator->createConfiguredClient();
		0 ignored issues – show Documentation Bug introduced 2016-11-24 17:22 UTC by Report Bug Copy Issue Report It seems like `$clientConfigurator->createConfiguredClient()` of type `object<Http\Client\Common\PluginClient>` is incompatible with the declared type `object<Http\Client\Common\HttpMethodsClient>` of property `$httpClient`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
91	4	$this->requestBuilder = $requestBuilder ?: new RequestBuilder();
92	4	$this->deserializer = $deserializer ?: new ModelDeserializer();
93	4	}
94
95		/**
96		* This function allows the sending of a fully formed message OR a custom
97		* MIME string. If sending MIME, the string must be passed in to the 3rd
98		* position of the function call.
99		*
100		* @param string $workingDomain
101		* @param array $postData
102		* @param array $postFiles
103		*
104		* @throws Exceptions\MissingRequiredMIMEParameters
105		*
106		* @return \stdClass
107		*/
108	6	public function sendMessage($workingDomain, $postData, $postFiles = [])
109		{
110	6	if (is_array($postFiles)) {
111	4	return $this->post("$workingDomain/messages", $postData, $postFiles);
112	2	} elseif (is_string($postFiles)) {
113	1	$tempFile = tempnam(sys_get_temp_dir(), 'MG_TMP_MIME');
114	1	$fileHandle = fopen($tempFile, 'w');
115	1	fwrite($fileHandle, $postFiles);
116
117	1	$result = $this->post("$workingDomain/messages.mime", $postData, ['message' => $tempFile]);
118	1	fclose($fileHandle);
119	1	unlink($tempFile);
120
121	1	return $result;
122		} else {
123	1	throw new Exceptions\MissingRequiredMIMEParameters(ExceptionMessages::EXCEPTION_MISSING_REQUIRED_MIME_PARAMETERS);
124		}
125		}
126
127		/**
128		* This function checks the signature in a POST request to see if it is
129		* authentic.
130		*
131		* Pass an array of parameters. If you pass nothing, $_POST will be
132		* used instead.
133		*
134		* If this function returns FALSE, you must not process the request.
135		* You should reject the request with status code 403 Forbidden.
136		*
137		* @param array\|null $postData
138		*
139		* @return bool
140		*/
141	3	public function verifyWebhookSignature($postData = null)
		0 ignored issues – show Coding Style introduced 2016-11-24 17:22 UTC by Report Bug Copy Issue Report `verifyWebhookSignature` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
142		{
143	3	if ($postData === null) {
144		$postData = $_POST;
145		}
146	3	if (!isset($postData['timestamp']) \|\| !isset($postData['token']) \|\| !isset($postData['signature'])) {
147	1	return false;
148		}
149	2	$hmac = hash_hmac('sha256', "{$postData['timestamp']}{$postData['token']}", $this->apiKey);
150	2	$sig = $postData['signature'];
151	2	if (function_exists('hash_equals')) {
152		// hash_equals is constant time, but will not be introduced until PHP 5.6
153		return hash_equals($hmac, $sig);
154		} else {
155	2	return $hmac === $sig;
156		}
157		}
158
159		/**
160		* @param string $endpointUrl
161		* @param array $postData
162		* @param array $files
163		*
164		* @return \stdClass
165		*/
166	7	public function post($endpointUrl, $postData = [], $files = [])
167		{
168	7	return $this->restClient->post($endpointUrl, $postData, $files);
169		}
170
171		/**
172		* @param string $endpointUrl
173		* @param array $queryString
174		*
175		* @return \stdClass
176		*/
177		public function get($endpointUrl, $queryString = [])
178		{
179		return $this->restClient->get($endpointUrl, $queryString);
180		}
181
182		/**
183		* @param string $endpointUrl
184		*
185		* @return \stdClass
186		*/
187		public function delete($endpointUrl)
188		{
189		return $this->restClient->delete($endpointUrl);
190		}
191
192		/**
193		* @param string $endpointUrl
194		* @param array $putData
195		*
196		* @return \stdClass
197		*/
198		public function put($endpointUrl, $putData)
199		{
200		return $this->restClient->put($endpointUrl, $putData);
201		}
202
203		/**
204		* @param string $apiVersion
205		*
206		* @return Mailgun
207		*/
208		public function setApiVersion($apiVersion)
209		{
210		$this->restClient->setApiVersion($apiVersion);
211
212		return $this;
213		}
214
215		/**
216		* @param bool $sslEnabled
217		*
218		* @return Mailgun
219		*
220		* @deprecated This will be removed in 3.0. Mailgun does not support non-secure connections to their API.
221		*/
222		public function setSslEnabled($sslEnabled)
223		{
224		$this->restClient->setSslEnabled($sslEnabled);
		0 ignored issues – show Deprecated Code introduced 2016-11-24 17:22 UTC by Report Bug Copy Issue Report The method `Mailgun\Connection\RestClient::setSslEnabled()` has been deprecated with message: To be removed in 3.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
225
226		return $this;
227		}
228
229		/**
230		* @return MessageBuilder
231		*/
232	28	public function MessageBuilder()
233		{
234	28	return new MessageBuilder();
235		}
236
237		/**
238		* @return OptInHandler
239		*/
240	3	public function OptInHandler()
241		{
242	3	return new OptInHandler();
243		}
244
245		/**
246		* @param string $workingDomain
247		* @param bool $autoSend
248		*
249		* @return BatchMessage
250		*/
251	15	public function BatchMessage($workingDomain, $autoSend = true)
252		{
253	15	return new BatchMessage($this->restClient, $workingDomain, $autoSend);
254		}
255
256		/**
257		* @return Api\Stats
258		*/
259		public function stats()
260		{
261		return new Api\Stats($this->httpClient, $this->requestBuilder, $this->deserializer);
262		}
263
264		/**
265		* @return Api\Domain
266		*/
267		public function domains()
268		{
269		return new Api\Domain($this->httpClient, $this->requestBuilder, $this->deserializer);
270		}
271
272		/**
273		* @return Api\Event
274		*/
275		public function events()
276		{
277		return new Api\Event($this->httpClient, $this->requestBuilder, $this->deserializer);
278		}
279
280		/**
281		* @return Api\Webhook
282		*/
283		public function webhooks()
284		{
285		return new Api\Webhook($this->httpClient, $this->requestBuilder, $this->deserializer);
286		}
287
288		/**
289		* @return Api\Message
290		*/
291		public function messages()
292		{
293		return new Api\Message($this->httpClient, $this->requestBuilder, $this->deserializer);
294		}
295		}
296

mailgun / mailgun-php

Pull Request — master (#247)

Mailgun::setApiVersion() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like