Summary::create() - Code Metrics - Inspection of "fix" - mailgun/mailgun-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 43a76d...75ce5f )

by David

created 2021-02-01 16:07 UTC

Summary::create() A

↳ Parent: Summary

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	9
loc	9
ccs	5
cts	5
cp	1
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

/*
 * Copyright (C) 2013 Mailgun
 *
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Mailgun\Model\EmailValidationV4;

use Mailgun\Model\ApiResponse;

final class Summary implements ApiResponse

{
    /**
     * @var SummaryResult
     */
    private $result;

    /**
     * @var SummaryRisk
     */
    private $risk;

    public static function create(array $data): self
    {
        $model = new self();

        $model->result = SummaryResult::create($data['result']);

        $model->risk = SummaryRisk::create($data['risk']);


        return $model;
    }

    private function __construct()
    {
    }

    public function getResult(): SummaryResult
    {
        return $this->result;
    }

    public function getRisk(): SummaryRisk
    {
        return $this->risk;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* Copyright (C) 2013 Mailgun
7			*
8			* This software may be modified and distributed under the terms
9			* of the MIT license. See the LICENSE file for details.
10			*/
11
12			namespace Mailgun\Model\EmailValidationV4;
13
14			use Mailgun\Model\ApiResponse;
15
16		View Code Duplication	final class Summary implements ApiResponse
			0 ignored issues – show Duplication introduced 2021-02-01 16:08 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17			{
18			/**
19			* @var SummaryResult
20			*/
21			private $result;
22
23			/**
24			* @var SummaryRisk
25			*/
26			private $risk;
27
28	7		public static function create(array $data): self
29			{
30	7		$model = new self();
31
32	7		$model->result = SummaryResult::create($data['result']);
			0 ignored issues – show Documentation Bug introduced 2021-02-01 16:08 UTC by Report Bug Copy Issue Report It seems like `\Mailgun\Model\EmailVali...create($data['result'])` of type `object<self>` is incompatible with the declared type `object<Mailgun\Model\Ema...dationV4\SummaryResult>` of property `$result`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
33	7		$model->risk = SummaryRisk::create($data['risk']);
			0 ignored issues – show Documentation Bug introduced 2021-02-01 16:08 UTC by Report Bug Copy Issue Report It seems like `\Mailgun\Model\EmailVali...::create($data['risk'])` of type `object<self>` is incompatible with the declared type `object<Mailgun\Model\Ema...lidationV4\SummaryRisk>` of property `$risk`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
34
35	7		return $model;
36			}
37
38	7		private function __construct()
39			{
40	7		}
41
42	1		public function getResult(): SummaryResult
43			{
44	1		return $this->result;
45			}
46
47	1		public function getRisk(): SummaryRisk
48			{
49	1		return $this->risk;
50			}
51			}
52

mailgun / mailgun-php

Push — master ( 43a76d...75ce5f )

Summary::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like