TotalResponseItem::create() - Code Metrics - Inspection of "Fixed stats retrieval (#384)" - mailgun/mailgun-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6dfd2b...b73ada )

by Tobias

created 2017-12-01 20:10 UTC

TotalResponseItem::create() B

↳ Parent: TotalResponseItem

Complexity

Conditions	5
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	9
c	0
b	0
f	0
ccs	7
cts	7
cp	1
rs	8.8571
cc	5
eloc	6
nc	1
nop	1
crap	5

<?php

/*
 * Copyright (C) 2013 Mailgun
 *
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Mailgun\Model\Stats;

/**
 * @author Tobias Nyholm <[email protected]>
 */
class TotalResponseItem
{
    /**
     * @var \DateTime
     */
    private $time;

    /**
     * @var array
     */
    private $accepted;

    /**
     * @var array
     */
    private $delivered;

    /**
     * @var array
     */
    private $failed;

    /**
     * @param array $data
     *
     * @return self
     */
    public static function create(array $data)
    {
        return new self(
            isset($data['time']) ? new \DateTime($data['time']) : null,
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            isset($data['accepted']) ? $data['accepted'] : [],
            isset($data['delivered']) ? $data['delivered'] : [],
            isset($data['failed']) ? $data['failed'] : []
        );
    }

    /**
     * @param \DateTime $time
     * @param array     $accepted
     * @param array     $delivered
     * @param array     $failed
     */
    private function __construct(\DateTime $time, array $accepted, array $delivered, array $failed)
    {
        $this->time = $time;
        $this->accepted = $accepted;
        $this->delivered = $delivered;
        $this->failed = $failed;
    }

    /**
     * @return \DateTime
     */
    public function getTime()
    {
        return $this->time;
    }

    /**
     * @return array
     */
    public function getAccepted()
    {
        return $this->accepted;
    }

    /**
     * @return array
     */
    public function getDelivered()
    {
        return $this->delivered;
    }

    /**
     * @return array
     */
    public function getFailed()
    {
        return $this->failed;
    }
}


1		<?php
2
3		/*
4		* Copyright (C) 2013 Mailgun
5		*
6		* This software may be modified and distributed under the terms
7		* of the MIT license. See the LICENSE file for details.
8		*/
9
10		namespace Mailgun\Model\Stats;
11
12		/**
13		* @author Tobias Nyholm <[email protected]>
14		*/
15		class TotalResponseItem
16		{
17		/**
18		* @var \DateTime
19		*/
20		private $time;
21
22		/**
23		* @var array
24		*/
25		private $accepted;
26
27		/**
28		* @var array
29		*/
30		private $delivered;
31
32		/**
33		* @var array
34		*/
35		private $failed;
36
37		/**
38		* @param array $data
39		*
40		* @return self
41		*/
42	3	public static function create(array $data)
43		{
44	3	return new self(
45	3	isset($data['time']) ? new \DateTime($data['time']) : null,
		0 ignored issues – show Bug introduced 2016-12-06 06:54 UTC by Report Bug Copy Issue Report It seems like `isset($data['time']) ? n...e($data['time']) : null` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
46	3	isset($data['accepted']) ? $data['accepted'] : [],
47	3	isset($data['delivered']) ? $data['delivered'] : [],
48	3	isset($data['failed']) ? $data['failed'] : []
49	3	);
50		}
51
52		/**
53		* @param \DateTime $time
54		* @param array $accepted
55		* @param array $delivered
56		* @param array $failed
57		*/
58	3	private function __construct(\DateTime $time, array $accepted, array $delivered, array $failed)
59		{
60	3	$this->time = $time;
61	3	$this->accepted = $accepted;
62	3	$this->delivered = $delivered;
63	3	$this->failed = $failed;
64	3	}
65
66		/**
67		* @return \DateTime
68		*/
69		public function getTime()
70		{
71		return $this->time;
72		}
73
74		/**
75		* @return array
76		*/
77		public function getAccepted()
78		{
79		return $this->accepted;
80		}
81
82		/**
83		* @return array
84		*/
85		public function getDelivered()
86		{
87		return $this->delivered;
88		}
89
90		/**
91		* @return array
92		*/
93		public function getFailed()
94		{
95		return $this->failed;
96		}
97		}
98

mailgun / mailgun-php

Push — master ( 6dfd2b...b73ada )

TotalResponseItem::create() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like