Complex classes like Contact often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Contact, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class Contact |
||
| 13 | { |
||
| 14 | const POLITE_FORM_FORMAL = 'formal'; |
||
| 15 | const POLITE_FORM_INFORMAL = 'informal'; |
||
| 16 | |||
| 17 | const TITLE_MALE = 'male'; |
||
| 18 | const TITLE_FEMALE = 'female'; |
||
| 19 | const TITLE_COMPANY = 'company'; |
||
| 20 | const TITLE_FAMILY = 'family'; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | private $id; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var string |
||
| 29 | */ |
||
| 30 | private $hash; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var \DateTime |
||
| 34 | */ |
||
| 35 | private $subscribed; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var \DateTime |
||
| 39 | */ |
||
| 40 | private $unsubscribed; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var \DateTime |
||
| 44 | */ |
||
| 45 | private $created; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var \DateTime |
||
| 49 | */ |
||
| 50 | private $updated; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var string |
||
| 54 | */ |
||
| 55 | private $contactListId; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var string |
||
| 59 | */ |
||
| 60 | private $email; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var string |
||
| 64 | */ |
||
| 65 | private $language; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var string |
||
| 69 | */ |
||
| 70 | private $politeForm; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var string |
||
| 74 | */ |
||
| 75 | private $title; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @var string |
||
| 79 | */ |
||
| 80 | private $company; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @var string |
||
| 84 | */ |
||
| 85 | private $firstname; |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @var string |
||
| 89 | */ |
||
| 90 | private $lastname; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @var string |
||
| 94 | */ |
||
| 95 | private $address; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * @var string |
||
| 99 | */ |
||
| 100 | private $address2; |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @var string |
||
| 104 | */ |
||
| 105 | private $zip; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * @var string |
||
| 109 | */ |
||
| 110 | private $city; |
||
| 111 | |||
| 112 | /** |
||
| 113 | * @var string |
||
| 114 | */ |
||
| 115 | private $country; |
||
| 116 | |||
| 117 | /** |
||
| 118 | * @var string |
||
| 119 | */ |
||
| 120 | private $phone; |
||
| 121 | |||
| 122 | /** |
||
| 123 | * @var string |
||
| 124 | */ |
||
| 125 | private $birthday; |
||
| 126 | |||
| 127 | /** |
||
| 128 | * @var bool |
||
| 129 | */ |
||
| 130 | private $inactive; |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @var array |
||
| 134 | */ |
||
| 135 | private $customValues = []; |
||
| 136 | |||
| 137 | /** |
||
| 138 | * Contact constructor. |
||
| 139 | * |
||
| 140 | * @param string $email |
||
| 141 | * @param string $id |
||
| 142 | */ |
||
| 143 | public function __construct($email, $id = null) |
||
| 148 | |||
| 149 | /** |
||
| 150 | * @return string |
||
| 151 | */ |
||
| 152 | public function __toString() |
||
| 156 | |||
| 157 | |||
| 158 | /** |
||
| 159 | * @return string |
||
| 160 | */ |
||
| 161 | public function getId() |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @param string $id |
||
| 168 | */ |
||
| 169 | public function setId($id) |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @return string |
||
| 176 | */ |
||
| 177 | public function getHash() |
||
| 181 | |||
| 182 | /** |
||
| 183 | * @param string $hash |
||
| 184 | */ |
||
| 185 | public function setHash($hash) |
||
| 189 | |||
| 190 | /** |
||
| 191 | * @return \DateTime |
||
| 192 | */ |
||
| 193 | public function getSubscribed() |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @param \DateTime|string $subscribed |
||
| 200 | */ |
||
| 201 | public function setSubscribed($subscribed) |
||
| 209 | |||
| 210 | /** |
||
| 211 | * @return \DateTime |
||
| 212 | */ |
||
| 213 | public function getUnsubscribed() |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @param \DateTime $unsubscribed |
||
| 220 | */ |
||
| 221 | public function setUnsubscribed($unsubscribed) |
||
| 229 | |||
| 230 | /** |
||
| 231 | * @return \DateTime |
||
| 232 | */ |
||
| 233 | public function getCreated() |
||
| 237 | |||
| 238 | /** |
||
| 239 | * @param \DateTime $created |
||
| 240 | */ |
||
| 241 | public function setCreated($created) |
||
| 249 | |||
| 250 | /** |
||
| 251 | * @return \DateTime |
||
| 252 | */ |
||
| 253 | public function getUpdated() |
||
| 257 | |||
| 258 | /** |
||
| 259 | * @param \DateTime $updated |
||
| 260 | */ |
||
| 261 | public function setUpdated($updated) |
||
| 269 | |||
| 270 | /** |
||
| 271 | * @return string |
||
| 272 | */ |
||
| 273 | public function getContactListId() |
||
| 277 | |||
| 278 | /** |
||
| 279 | * @param string $contactListId |
||
| 280 | */ |
||
| 281 | public function setContactListId($contactListId) |
||
| 285 | |||
| 286 | /** |
||
| 287 | * @return string |
||
| 288 | */ |
||
| 289 | public function getEmail() |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @param string $email |
||
| 296 | */ |
||
| 297 | public function setEmail($email) |
||
| 301 | |||
| 302 | /** |
||
| 303 | * @return string |
||
| 304 | */ |
||
| 305 | public function getLanguage() |
||
| 309 | |||
| 310 | /** |
||
| 311 | * @param string $language |
||
| 312 | */ |
||
| 313 | public function setLanguage($language) |
||
| 317 | |||
| 318 | /** |
||
| 319 | * @return string |
||
| 320 | */ |
||
| 321 | public function getPoliteForm() |
||
| 325 | |||
| 326 | /** |
||
| 327 | * @param string $politeForm |
||
| 328 | */ |
||
| 329 | public function setPoliteForm($politeForm) |
||
| 333 | |||
| 334 | /** |
||
| 335 | * @return string |
||
| 336 | */ |
||
| 337 | public function getTitle() |
||
| 341 | |||
| 342 | /** |
||
| 343 | * @param string $title |
||
| 344 | */ |
||
| 345 | public function setTitle($title) |
||
| 349 | |||
| 350 | /** |
||
| 351 | * @return string |
||
| 352 | */ |
||
| 353 | public function getCompany() |
||
| 357 | |||
| 358 | /** |
||
| 359 | * @param string $company |
||
| 360 | */ |
||
| 361 | public function setCompany($company) |
||
| 365 | |||
| 366 | /** |
||
| 367 | * @return string |
||
| 368 | */ |
||
| 369 | public function getFirstname() |
||
| 373 | |||
| 374 | /** |
||
| 375 | * @param string $firstname |
||
| 376 | */ |
||
| 377 | public function setFirstname($firstname) |
||
| 381 | |||
| 382 | /** |
||
| 383 | * @return string |
||
| 384 | */ |
||
| 385 | public function getLastname() |
||
| 389 | |||
| 390 | /** |
||
| 391 | * @param string $lastname |
||
| 392 | */ |
||
| 393 | public function setLastname($lastname) |
||
| 397 | |||
| 398 | /** |
||
| 399 | * @return string |
||
| 400 | */ |
||
| 401 | public function getAddress() |
||
| 405 | |||
| 406 | /** |
||
| 407 | * @param string $address |
||
| 408 | */ |
||
| 409 | public function setAddress($address) |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @return string |
||
| 416 | */ |
||
| 417 | public function getAddress2() |
||
| 421 | |||
| 422 | /** |
||
| 423 | * @param string $address2 |
||
| 424 | */ |
||
| 425 | public function setAddress2($address2) |
||
| 429 | |||
| 430 | /** |
||
| 431 | * @return string |
||
| 432 | */ |
||
| 433 | public function getZip() |
||
| 437 | |||
| 438 | /** |
||
| 439 | * @param string $zip |
||
| 440 | */ |
||
| 441 | public function setZip($zip) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * @return string |
||
| 448 | */ |
||
| 449 | public function getCity() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * @param string $city |
||
| 456 | */ |
||
| 457 | public function setCity($city) |
||
| 461 | |||
| 462 | /** |
||
| 463 | * @return string |
||
| 464 | */ |
||
| 465 | public function getCountry() |
||
| 469 | |||
| 470 | /** |
||
| 471 | * @param string $country |
||
| 472 | */ |
||
| 473 | public function setCountry($country) |
||
| 477 | |||
| 478 | /** |
||
| 479 | * @return string |
||
| 480 | */ |
||
| 481 | public function getPhone() |
||
| 485 | |||
| 486 | /** |
||
| 487 | * @param string $phone |
||
| 488 | */ |
||
| 489 | public function setPhone($phone) |
||
| 493 | |||
| 494 | /** |
||
| 495 | * @return string |
||
| 496 | */ |
||
| 497 | public function getBirthday() |
||
| 501 | |||
| 502 | /** |
||
| 503 | * @param string $birthday |
||
| 504 | */ |
||
| 505 | public function setBirthday($birthday) |
||
| 509 | |||
| 510 | /** |
||
| 511 | * @return bool |
||
| 512 | */ |
||
| 513 | public function getInactive() |
||
| 517 | |||
| 518 | /** |
||
| 519 | * @param bool $inactive |
||
| 520 | */ |
||
| 521 | public function setInactive($inactive) |
||
| 525 | |||
| 526 | /** |
||
| 527 | * @return array |
||
| 528 | */ |
||
| 529 | public function getCustomValues() |
||
| 533 | |||
| 534 | /** |
||
| 535 | * @param array $customValues |
||
| 536 | */ |
||
| 537 | public function setCustomValues($customValues) |
||
| 541 | |||
| 542 | /** |
||
| 543 | * @param string $alias |
||
| 544 | * @param string $value |
||
| 545 | */ |
||
| 546 | public function setCustomValue($alias, $value) |
||
| 550 | |||
| 551 | /** |
||
| 552 | * @param string $alias |
||
| 553 | * @param string|null $default |
||
| 554 | * |
||
| 555 | * @return null |
||
| 556 | */ |
||
| 557 | public function getCustomValue($alias, $default = null) |
||
| 565 | |||
| 566 | /** |
||
| 567 | * @param string $alias |
||
| 568 | * |
||
| 569 | * @return bool |
||
| 570 | */ |
||
| 571 | public function hasCustomValue($alias) |
||
| 575 | |||
| 576 | /** |
||
| 577 | * @param array $exclude |
||
| 578 | * @param bool $clean |
||
| 579 | * |
||
| 580 | * @return array |
||
| 581 | */ |
||
| 582 | public function toAPI(array $exclude = [], $clean = true) |
||
| 618 | |||
| 619 | /** |
||
| 620 | * @param array $data |
||
| 621 | */ |
||
| 622 | public function fromAPI(array $data) |
||
| 694 | } |
||
| 695 |