ContactListsRequest::post() - Code Metrics - mailXpert/mailxpert-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

ContactListsRequest::post() A
last analyzed 2020-02-21 15:19 UTC

↳ Parent: ContactListsRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php
namespace Mailxpert\Request;

use Mailxpert\Exceptions\MailxpertSDKException;
use Mailxpert\Mailxpert;

/**
 * Date: 20/08/15
 */
class ContactListsRequest
{
    /**
     * @param Mailxpert $mailxpert
     * @param array     $params
     *
     * @return \Mailxpert\MailxpertResponse
     */
    public static function get(Mailxpert $mailxpert, array $params = [])
    {
        $response = $mailxpert->sendRequest('GET', 'contact_lists', $params);

        return $response;
    }

    /**
     * @param Mailxpert $mailxpert
     * @param string    $name
     *
     * @return \Mailxpert\MailxpertResponse
     * @throws MailxpertSDKException
     */
    public static function post(Mailxpert $mailxpert, $name)
    {
        $response = $mailxpert->sendRequest('POST', 'contact_lists', [], null, json_encode(['name' => $name]));

        if (!$response->getHeader('Location')) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            throw new MailxpertSDKException('An error occured during the Contact list creation.');
        }

        return $response;
    }
}


1			<?php
2			namespace Mailxpert\Request;
3
4			use Mailxpert\Exceptions\MailxpertSDKException;
5			use Mailxpert\Mailxpert;
6
7			/**
8			* Date: 20/08/15
9			*/
10			class ContactListsRequest
11			{
12			/**
13			* @param Mailxpert $mailxpert
14			* @param array $params
15			*
16			* @return \Mailxpert\MailxpertResponse
17			*/
18			public static function get(Mailxpert $mailxpert, array $params = [])
19			{
20			$response = $mailxpert->sendRequest('GET', 'contact_lists', $params);
21
22			return $response;
23			}
24
25			/**
26			* @param Mailxpert $mailxpert
27			* @param string $name
28			*
29			* @return \Mailxpert\MailxpertResponse
30			* @throws MailxpertSDKException
31			*/
32			public static function post(Mailxpert $mailxpert, $name)
33			{
34			$response = $mailxpert->sendRequest('POST', 'contact_lists', [], null, json_encode(['name' => $name]));
35
36			if (!$response->getHeader('Location')) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-19 13:19 UTC by Report Bug Copy Issue Report The expression `$response->getHeader('Location')` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37			throw new MailxpertSDKException('An error occured during the Contact list creation.');
38			}
39
40			return $response;
41			}
42			}
43

mailXpert / mailxpert-php-sdk

ContactListsRequest::post() A last analyzed 2020-02-21 15:19 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ContactListsRequest::post() A
last analyzed 2020-02-21 15:19 UTC