HttpClient::retrieveAndParseResponse() - Code Metrics - Inspection of "Adding https and secure client socket" - maikgreubel/phpgenerics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9cb483...15ad7c )

by Maik

created 2017-08-22 04:27 UTC

HttpClient::retrieveAndParseResponse() C

↳ Parent: Project

Complexity

Conditions	11
Paths	44

Size

Total Lines	68
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	38
CRAP Score	11.0151

Importance

Changes

Metric	Value
dl	0
loc	68
ccs	38
cts	40
cp	0.95
rs	5.8371
c	0
b	0
f	0
cc	11
eloc	40
nc	44
nop	1
crap	11.0151

How to fix Long Method Complexity

<?php

/**
 * This file is part of the PHP Generics package.
 *
 * @package Generics
 */
namespace Generics\Client;

use Generics\Socket\ClientSocket;
use Generics\Socket\Url;
use Generics\Streams\HttpStream;

/**
 * This class implements a HttpStream as client
 *
 * @author Maik Greubel <[email protected]>
 */
class HttpClient extends ClientSocket implements HttpStream
{
    use HttpClientTrait;
    
    /**
     * Whether to use https instead of http
     *
     * @var boolean
     */
    private $secure;

    /**
     * Create a new http client
     *
     * @param Url $url
     *            The url for http request
     * @param string $proto
     *            The protocol to use (default = HTTP/1.1)
     * @param integer $timeout
     *            Optional timeout for request (default = 10 seconds)
     */
    public function __construct(Url $url, $proto = 'HTTP/1.1', $timeout = 10)
    {
        parent::__construct($url);
        
        $this->secure = $url->getScheme() == 'https';

        $this->setTimeout($timeout);
        $this->setPath($url->getPath());
        $this->setProtocol($proto);
        $this->setQueryString($url->getQueryString());
        $this->reset();
        $this->resetHeaders();
    }

    /**
     *
     * {@inheritdoc}
     * @see \Generics\Streams\HttpStream::request()
     */
    public function request(string $requestType)
    {
        if ($this->secure) {
            throw new HttpException("Secure connection using HTTPs is not supported!");
        }
        
        $this->requestImpl($requestType);
    }
}


1			<?php
2
3			/**
4			* This file is part of the PHP Generics package.
5			*
6			* @package Generics
7			*/
8			namespace Generics\Client;
9
10			use Generics\Socket\ClientSocket;
11			use Generics\Socket\Url;
12			use Generics\Streams\HttpStream;
13
14			/**
15			* This class implements a HttpStream as client
16			*
17			* @author Maik Greubel <[email protected]>
18			*/
19			class HttpClient extends ClientSocket implements HttpStream
20			{
21			use HttpClientTrait;
22
23			/**
24			* Whether to use https instead of http
25			*
26			* @var boolean
27			*/
28			private $secure;
29
30			/**
31			* Create a new http client
32			*
33			* @param Url $url
34			* The url for http request
35			* @param string $proto
36			* The protocol to use (default = HTTP/1.1)
37			* @param integer $timeout
38			* Optional timeout for request (default = 10 seconds)
39			*/
40	12	View Code Duplication	public function __construct(Url $url, $proto = 'HTTP/1.1', $timeout = 10)
41			{
42	12		parent::__construct($url);
43
44	12		$this->secure = $url->getScheme() == 'https';
45
46	12		$this->setTimeout($timeout);
47	12		$this->setPath($url->getPath());
48	12		$this->setProtocol($proto);
49	12		$this->setQueryString($url->getQueryString());
50	12		$this->reset();
51	12		$this->resetHeaders();
52	12		}
53
54			/**
55			*
56			* {@inheritdoc}
57			* @see \Generics\Streams\HttpStream::request()
58			*/
59	12		public function request(string $requestType)
60			{
61	12		if ($this->secure) {
62	1		throw new HttpException("Secure connection using HTTPs is not supported!");
63			}
64
65	11		$this->requestImpl($requestType);
66	9		}
67			}
68

maikgreubel / phpgenerics

Push — master ( 9cb483...15ad7c )

HttpClient::retrieveAndParseResponse() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like