Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class ClientSocket extends Socket |
||
| 16 | { |
||
| 17 | |||
| 18 | /** |
||
| 19 | * Whether the socket is connected |
||
| 20 | * |
||
| 21 | * @var boolean |
||
| 22 | */ |
||
| 23 | private $conntected; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * Create a new client socket |
||
| 27 | * |
||
| 28 | * @param Endpoint $endpoint |
||
| 29 | * The endpoint to use |
||
| 30 | * @param resource $clientHandle |
||
| 31 | * optional existing client handle |
||
| 32 | */ |
||
| 33 | 10 | public function __construct(Endpoint $endpoint, $clientHandle = null) |
|
| 34 | { |
||
| 35 | 10 | $this->endpoint = $endpoint; |
|
| 36 | 10 | $this->handle = $clientHandle; |
|
| 37 | 10 | $this->conntected = false; |
|
| 38 | |||
| 39 | 10 | if (! is_resource($clientHandle)) { |
|
| 40 | 10 | parent::__construct($endpoint); |
|
| 41 | } |
||
| 42 | 10 | } |
|
| 43 | |||
| 44 | /** |
||
| 45 | * Connect to remote endpoint |
||
| 46 | * |
||
| 47 | * @throws SocketException |
||
| 48 | */ |
||
| 49 | 9 | View Code Duplication | public function connect() |
| 57 | |||
| 58 | /** |
||
| 59 | * Disconnects the socket |
||
| 60 | * |
||
| 61 | * @throws SocketException |
||
| 62 | */ |
||
| 63 | 5 | public function disconnect() |
|
| 64 | { |
||
| 65 | 5 | if (! $this->conntected) { |
|
| 66 | throw new SocketException("Socket is not connected"); |
||
| 67 | } |
||
| 68 | |||
| 69 | 5 | $this->close(); |
|
| 70 | 5 | } |
|
| 71 | |||
| 72 | /** |
||
| 73 | * Whether the client is connected |
||
| 74 | * |
||
| 75 | * @return boolean |
||
| 76 | */ |
||
| 77 | 8 | public function isConnected() |
|
| 78 | { |
||
| 79 | 8 | return $this->conntected; |
|
| 80 | } |
||
| 81 | |||
| 82 | /** |
||
| 83 | * |
||
| 84 | * @see \Generics\Socket\ClientSocket::disconnect() |
||
| 85 | */ |
||
| 86 | 10 | public function close() |
|
| 87 | { |
||
| 88 | 10 | parent::close(); |
|
| 89 | 10 | $this->conntected = false; |
|
| 90 | 10 | } |
|
| 91 | |||
| 92 | /** |
||
| 93 | * |
||
| 94 | * {@inheritdoc} |
||
| 95 | * @see \Generics\Socket\Socket::isWriteable() |
||
| 96 | */ |
||
| 97 | 1 | public function isWriteable() |
|
| 105 | } |
||
| 106 |