Nkey\DDG\API\QueryResultParser

Complexity

Total Complexity

18

Size/Duplication

Total Lines	101
Duplicated Lines	46.53 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	parseQueryResult()	15	29	5
B	parseRelatedTopics()	17	28	6
B	parseIcon()	15	26	6
A	parseMeta()	0	4	1

<?php
namespace Nkey\DDG\API;

use Nkey\DDG\API\Model\Icon;
use Nkey\DDG\API\Model\QueryResult;
use Nkey\DDG\API\Model\RelatedTopic;
use Webmozart\Json\JsonDecoder;
use ReflectionClass;
use ReflectionMethod;

/**
 * This class provides means for parsing json from duckduckgo api into a local model
 *
 * @author Maik Greubel <greubel@nkey.de>
 * @license Apache 2.0
 */
class QueryResultParser
{

    /**
     * Parse a payload json string
     *
     * @param string $payload
     *            The payload to parse
     * @return QueryResult
     */
    public function parseQueryResult(string $payload): QueryResult
    {
        $decoder = new JsonDecoder();
        
        $json = $decoder->decode($payload);
        
        $result = new QueryResult();
        
        $ref = new ReflectionClass($result);
        $methods = $ref->getMethods(ReflectionMethod::IS_PUBLIC);
        foreach ($methods as $method) {

This code seems to be duplicated across your project.

            assert($method instanceof ReflectionMethod);
            
            if (substr($method->getName(), 0, 3) === 'set') {

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                $propertyName = substr($method->getName(), 3);

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                if ($propertyName === 'Meta') {
                    $result = $this->parseMeta($result, $json->meta);
                    continue;
                }
                if (property_exists($json, $propertyName)) {
                    $property = $json->$propertyName;
                    $method->invoke($result, $property);
                }
            }
        }
        
        $result = $this->parseRelatedTopics($result, $json->RelatedTopics);
        return $result;
    }

    private function parseRelatedTopics(QueryResult $result, $relatedTopics)
    {
        foreach ($relatedTopics as $relatedTopic) {
            $topic = new RelatedTopic();
            $ref = new ReflectionClass($topic);
            $methods = $ref->getMethods(ReflectionMethod::IS_PUBLIC);
            foreach ($methods as $method) {

This code seems to be duplicated across your project.

                assert($method instanceof ReflectionMethod);
                
                if (substr($method->getName(), 0, 3) === 'set') {

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                    $propertyName = substr($method->getName(), 3);

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                    
                    if ($propertyName === 'Icon') {
                        $topic = $this->parseIcon($topic, $relatedTopic->Icon);
                        continue;
                    }
                    
                    if (property_exists($relatedTopic, $propertyName)) {
                        $property = $relatedTopic->$propertyName;
                        $method->invoke($topic, $property);
                    }
                }
            }
            $result->addRelatedTopic($topic);
        }
        
        return $result;
    }

    private function parseIcon(RelatedTopic $topic, $icon): RelatedTopic
    {
        $ico = new Icon();
        
        $ref = new ReflectionClass($ico);
        $methods = $ref->getMethods(ReflectionMethod::IS_PUBLIC);
        foreach ($methods as $method) {

This code seems to be duplicated across your project.

            assert($method instanceof ReflectionMethod);
            
            if (substr($method->getName(), 0, 3) === 'set') {

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                $propertyName = substr($method->getName(), 3);

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

                if (property_exists($icon, $propertyName)) {
                    $property = $icon->$propertyName;
                    
                    if ($propertyName === 'Height' || $propertyName === 'Width') {
                        $property = intval($property);
                    }
                    $method->invoke($ico, $property);
                }
            }
        }
        
        $topic->setIcon($ico);
        
        return $topic;
    }

    private function parseMeta(QueryResult $result, $meta): QueryResult

The parameter $meta is not used and could be removed.

    {
        return $result;
    }
}