Nkey\Caribu\Mvc\Router\AbstractRouter

Complexity

Total Complexity

12

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

79.31%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setApplication()	0	7	2
A	addRoute()	0	4	1
A	hasRoute()	0	4	1
A	getRoute()	0	8	2
B	route()	0	23	6

<?php
namespace Nkey\Caribu\Mvc\Router;

use Nkey\Caribu\Mvc\Controller\AbstractController;
use Nkey\Caribu\Mvc\Controller\Request;
use Nkey\Caribu\Mvc\Application;

abstract class AbstractRouter {
	
	/**
	 * Application instance
	 * 
	 * @var Application
	 */
	private $application;
	
	public function setApplication(Application $application)
	{
		$this->application = $application;
		foreach($this->routes as $routeName => $controller) {
			$this->application->registerController($controller, $routeName);
		}
	}
	
	/**
	 * @var array
	 */
	private $routes;
	
	public function addRoute(string $name, AbstractController $controller)
	{
		$this->routes[$name] = $controller;
	}
	
	/**
	 * Checks wether a route exists
	 * 
	 * @param string $name
	 * @return bool
	 */
	public function hasRoute(string $name)
	{
		return key_exists($name, $this->routes);
	}
	
	/**
	 * 
	 * @param string $name
	 * @throws RouterException
	 * @return AbstractController
	 */
	private function getRoute(string $name)
	{
		if(!$this->hasRoute($name)) {
			throw new RouterException("Router {$router} is not registered");
		}
		
		return $this->routes[$name];
	}
	
	/**
	 * Route the existing request into a new controller
	 * 
	 * @param string $name The name of route
	 * @param Request $request The existing request instance
	 * @return \Nkey\Caribu\Mvc\Controller\AbstractController
	 */
	public function route(string $name, Request $request)
	{
		$parts = \explode('/', $request->getOrigin());
		$found = false;
		for($i = 0; $i < count($parts); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

			if($parts[$i] === $name && isset($parts[$i+1])) {
				$action = $parts[$i+1];
				if(strpos($action, "?")) {
					$action = strstr($action, "?", true);
				}
				
				$request->setAction($action);
				$found = true;
			}
		}
		if(!$found) {
			$request->setAction("index");
		}
		$controller = $this->getRoute($name);
		$request->setController($controller->getControllerSimpleName());
		
		return $controller;
	}
}