MocOrm\Support\Model

Complexity

Total Complexity

12

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	first()	0	3	1
A	offsetSet()	0	8	2
A	offsetExists()	0	5	1
A	offsetGet()	0	5	2
A	toArray()	0	3	1
A	offsetUnset()	0	5	1
A	toList()	0	9	2
A	end()	0	2	1
A	count()	0	3	1

<?php

namespace MocOrm\Support;

/**
 * Class Model
 * @package MocOrm\Support
 */
abstract class Model extends \MocOrm\Model\Model implements \ArrayAccess
{
    /**
     * Gets model data.
     *
     * @return array
     */
    public function toArray()
    {
        return $this->getData();

The expression return $this->getData() also could return the type boolean which is incompatible with the documented return type array.

    }

    /**
     * Return count of data
     * @return int
     */
    public function count()
    {
        return count($this->getData());

It seems like $this->getData() can also be of type boolean; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

    }

    /**
     * Get first model from query result.
     * @return mixed
     */
    public function end() {
        return end($this->getData());

It seems like $this->getData() can also be of type boolean; however, parameter $array of end() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Gets model data through static method.
     *
     * @param  mixed $data
     * @return array
     */
    public static function toList($data)
    {
        if (!($data instanceof self)) throw new \Exception(" It's not a model.");

        $data = array_map(function ($object) {
            return $object->toArray();
        }, $data);

$data of type MocOrm\Support\Model is incompatible with the type array expected by parameter $arr1 of array_map().

        return $data;
    }

    /**
     * Get first model from query result.
     *
     * @return mixed
     */
    public function first()
    {
        return current($this->getData());

It seems like $this->getData() can also be of type boolean; however, parameter $array of current() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * ArrayAccess Interface.
     */
    public function offsetExists($offset)
    {
        $data = $this->getData();

        return isset($data[$offset]);
    }

    /**
     * @param mixed $offset
     * @return mixed|null
     */
    public function offsetGet($offset)
    {
        $data = $this->getData();

        return isset($data[$offset]) ? $data[$offset] : null;
    }

    /**
     * @param mixed $offset
     * @param mixed $value
     */
    public function offsetSet($offset, $value)
    {
        $data = $this->getData();

        if (is_null($offset)) {
            $data[] = $value;
        } else {
            $data[$offset] = $value;
        }
    }

    /**
     * @param mixed $offset
     */
    public function offsetUnset($offset)
    {
        $data = $this->getData();

The assignment to $data is dead and can be removed.

        unset($this->data[$offset]);

The property data does not exist on MocOrm\Support\Model. Since you implemented __get, consider adding a @property annotation.

    }
}