Anax\Weather\WeatherJsonController::indexActionGet()

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	2

Importance

Changes

0

<?php
    public function indexActionGet() : array
    {
        $this->api = require ANAX_INSTALL_PATH . "/config/keys.php";

The property api does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $address = $this->di->get("request")->getGet("address");
        $curl = $this->di->get("curl");
        $curl->getIpData($address, $this->api["ip_key"]);
        $curl->getWeatherData($this->api["weather_key"]);
        $resOne = $curl->weatherData;
        $resTwo = $curl->ipData;

        if (sizeOf($resOne) == 2) {
            $json = [
                "error" => $resOne["error"],
            ];

            return [$json];
        } else {
            $json = [
                "ip_data" => $resTwo,
                "daily_weather" => $resOne["daily"]["data"],
            ];

            return [$json];
        }