Failed Conditions
Pull Request — master (#38)
by Matthias
04:08 queued 01:21
created

CheckCommand::getASTFromFilesLocator()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 5
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 4
CRAP Score 2

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 5
ccs 4
cts 4
cp 1
rs 9.4285
cc 2
eloc 3
nc 2
nop 1
crap 2
1
<?php
2
3
namespace ComposerRequireChecker\Cli;
4
5
use ComposerRequireChecker\ASTLocator\LocateASTFromFiles;
6
use ComposerRequireChecker\DefinedExtensionsResolver\DefinedExtensionsResolver;
7
use ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromASTRoots;
8
use ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromExtensions;
9
use ComposerRequireChecker\DependencyGuesser\DependencyGuesser;
10
use ComposerRequireChecker\FileLocator\LocateComposerPackageDirectDependenciesSourceFiles;
11
use ComposerRequireChecker\FileLocator\LocateComposerPackageSourceFiles;
12
use ComposerRequireChecker\GeneratorUtil\ComposeGenerators;
13
use ComposerRequireChecker\JsonLoader;
14
use ComposerRequireChecker\UsedSymbolsLocator\LocateUsedSymbolsFromASTRoots;
15
use PhpParser\ErrorHandler\Collecting as CollectingErrorHandler;
16
use PhpParser\ParserFactory;
17
use Symfony\Component\Console\Command\Command;
18
use Symfony\Component\Console\Helper\Table;
19
use Symfony\Component\Console\Input\InputArgument;
20
use Symfony\Component\Console\Input\InputInterface;
21
use Symfony\Component\Console\Input\InputOption;
22
use Symfony\Component\Console\Output\OutputInterface;
23
24
class CheckCommand extends Command
25
{
26 3
    protected function configure()
27
    {
28
        $this
29 3
            ->setName('check')
30 3
            ->setDescription('check the defined dependencies against your code')
31 3
            ->addOption(
32 3
                'config-file',
33 3
                null,
34 3
                InputOption::VALUE_REQUIRED,
35 3
                'the config.json file to configure the checking options'
36
            )
37 3
            ->addArgument(
38 3
                'composer-json',
39 3
                InputArgument::OPTIONAL,
40 3
                'the composer.json of your package, that should be checked',
41 3
                './composer.json'
42
            )
43 3
        ->addOption(
44 3
                'ignore-parse-errors',
45 3
                null,
46 3
                InputOption::VALUE_NONE,
47
                'this will cause ComposerRequireChecker to ignore errors when files cannot be parsed, otherwise'
48 3
                . ' errors will be thrown'
49
            );
50 3
    }
51
52 2
    protected function execute(InputInterface $input, OutputInterface $output): int
53
    {
54 2
        if (!$output->isQuiet()) {
55 2
            $output->writeln($this->getApplication()->getLongVersion());
56
        }
57
58 2
        $composerJson = realpath($input->getArgument('composer-json'));
59 2
        if (false === $composerJson) {
0 ignored issues
show
introduced by
The condition false === $composerJson can never be true.
Loading history...
60 1
            throw new \InvalidArgumentException('file not found: [' . $input->getArgument('composer-json') . ']');
61
        }
62 1
        $this->checkJsonFile($composerJson);
63
64 1
        $options = $this->getCheckOptions($input);
65
66 1
        $getPackageSourceFiles = new LocateComposerPackageSourceFiles();
67
68 1
        $sourcesASTs = $this->getASTFromFilesLocator($input);
69
70 1
        $definedVendorSymbols = (new LocateDefinedSymbolsFromASTRoots())->__invoke($sourcesASTs(
71 1
            (new ComposeGenerators())->__invoke(
72 1
                $getPackageSourceFiles($composerJson),
73 1
                (new LocateComposerPackageDirectDependenciesSourceFiles())->__invoke($composerJson)
74
            )
75
        ));
76
77 1
        $definedExtensionSymbols = (new LocateDefinedSymbolsFromExtensions())->__invoke(
78 1
            (new DefinedExtensionsResolver())->__invoke($composerJson, $options->getPhpCoreExtensions())
79
        );
80
81 1
        $usedSymbols = (new LocateUsedSymbolsFromASTRoots())
82 1
            ->__invoke($sourcesASTs($getPackageSourceFiles($composerJson)));
83
84 1
        if (!count($usedSymbols)) {
85
            throw new \LogicException('There were no symbols found, please check your configuration.');
86
        }
87
88 1
        $unknownSymbols = array_diff(
89 1
            $usedSymbols,
90 1
            $definedVendorSymbols,
91 1
            $definedExtensionSymbols,
92 1
            $options->getSymbolWhitelist()
93
        );
94
95 1
        if (!$unknownSymbols) {
0 ignored issues
show
introduced by
The condition ! $unknownSymbols can never be false.
Loading history...
Bug Best Practice introduced by
The expression $unknownSymbols of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
96 1
            $output->writeln("There were no unknown symbols found.");
97 1
            return 0;
98
        }
99
100
        $output->writeln("The following unknown symbols were found:");
101
        $table = new Table($output);
102
        $table->setHeaders(['unknown symbol', 'guessed dependency']);
103
        $guesser = new DependencyGuesser();
104
        foreach ($unknownSymbols as $unknownSymbol) {
105
            $guessedDependencies = [];
106
            foreach ($guesser($unknownSymbol) as $guessedDependency) {
107
                $guessedDependencies[] = $guessedDependency;
108
            }
109
            $table->addRow([$unknownSymbol, implode("\n", $guessedDependencies)]);
110
        }
111
        $table->render();
112
113
        return ((int)(bool)$unknownSymbols);
114
    }
115
116 1
    private function getCheckOptions(InputInterface $input): Options
117
    {
118 1
        $fileName = $input->getOption('config-file');
119 1
        if (!$fileName) {
120 1
            return new Options();
121
        }
122
        return new Options((new JsonLoader($fileName))->getData());
123
    }
124
125
    /**
126
     * @param string $jsonFile
127
     * @throws \ComposerRequireChecker\Exception\InvalidJsonException
128
     * @throws \ComposerRequireChecker\Exception\NotReadableException
129
     * @internal param string $composerJson the path to composer.json
130
     */
131 1
    private function checkJsonFile(string $jsonFile)
132
    {
133
        // JsonLoader throws an exception if it cannot load the file
134 1
        new JsonLoader($jsonFile);
135 1
    }
136
137
    /**
138
     * @param InputInterface $input
139
     * @return LocateASTFromFiles
140
     */
141 1
    private function getASTFromFilesLocator(InputInterface $input): LocateASTFromFiles
142
    {
143 1
        $errorHandler = $input->getOption('ignore-parse-errors') ? new CollectingErrorHandler() : null;
144 1
        $sourcesASTs = new LocateASTFromFiles((new ParserFactory())->create(ParserFactory::PREFER_PHP7), $errorHandler);
145 1
        return $sourcesASTs;
146
    }
147
148
}
149