Completed
Pull Request — master (#195)
by
unknown
05:29
created

UsedSymbolCollector   B

Complexity

Total Complexity 44

Size/Duplication

Total Lines 171
Duplicated Lines 0 %

Test Coverage

Coverage 100%

Importance

Changes 10
Bugs 1 Features 0
Metric Value
wmc 44
eloc 59
c 10
b 1
f 0
dl 0
loc 171
ccs 83
cts 83
cp 1
rs 8.8798

15 Methods

Rating   Name   Duplication   Size   Complexity  
A recordUsageOfByString() 0 3 1
B recordFunctionParameterTypesUsage() 0 11 7
A recordFunctionReturnTypeUsage() 0 10 6
A getCollectedSymbols() 0 3 1
A recordCatchUsage() 0 5 3
A recordConstantFetchUsage() 0 4 2
A __construct() 0 2 1
A recordImplementsUsage() 0 4 2
A beforeTraverse() 0 5 1
A recordUsageOf() 0 3 1
A recordFunctionCallUsage() 0 6 3
A recordExtendsUsage() 0 8 3
B recordClassExpressionUsage() 0 11 7
A enterNode() 0 13 1
A recordTraitUsage() 0 15 5

How to fix   Complexity   

Complex Class

Complex classes like UsedSymbolCollector often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use UsedSymbolCollector, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace ComposerRequireChecker\NodeVisitor;
4
5
use PhpParser\Node;
6
use PhpParser\NodeVisitorAbstract;
7
8
final class UsedSymbolCollector extends NodeVisitorAbstract
9
{
10
    /**
11
     * @var mixed[]
12
     */
13
    private $collectedSymbols = [];
14
15 29
    public function __construct()
16
    {
17 29
    }
18
19
    /**
20
     * @return string[]
21
     */
22 28
    public function getCollectedSymbols(): array
23
    {
24 28
        return array_keys($this->collectedSymbols);
25
    }
26
27
    /**
28
     * {@inheritDoc}
29
     */
30 6
    public function beforeTraverse(array $nodes)
31
    {
32 6
        $this->collectedSymbols = [];
33
34 6
        return parent::beforeTraverse($nodes);
0 ignored issues
show
Bug introduced by
Are you sure the usage of parent::beforeTraverse($nodes) targeting PhpParser\NodeVisitorAbstract::beforeTraverse() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
35
    }
36
37
    /**
38
     * {@inheritDoc}
39
     */
40 28
    public function enterNode(Node $node)
41
    {
42 28
        $this->recordExtendsUsage($node);
43 28
        $this->recordImplementsUsage($node);
44 28
        $this->recordClassExpressionUsage($node);
45 28
        $this->recordCatchUsage($node);
46 28
        $this->recordFunctionCallUsage($node);
47 28
        $this->recordFunctionParameterTypesUsage($node);
48 28
        $this->recordFunctionReturnTypeUsage($node);
49 28
        $this->recordConstantFetchUsage($node);
50 28
        $this->recordTraitUsage($node);
51
52 28
        return parent::enterNode($node);
0 ignored issues
show
Bug introduced by
Are you sure the usage of parent::enterNode($node) targeting PhpParser\NodeVisitorAbstract::enterNode() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
53
    }
54
55 28
    private function recordExtendsUsage(Node $node)
56
    {
57 28
        if ($node instanceof Node\Stmt\Class_) {
58 8
            array_map([$this, 'recordUsageOf'], array_filter([$node->extends]));
59
        }
60
61 28
        if ($node instanceof Node\Stmt\Interface_) {
62 5
            array_map([$this, 'recordUsageOf'], array_filter($node->extends));
63
        }
64 28
    }
65
66 28
    private function recordImplementsUsage(Node $node)
67
    {
68 28
        if ($node instanceof Node\Stmt\Class_) {
69 8
            array_map([$this, 'recordUsageOf'], $node->implements);
70
        }
71 28
    }
72
73 28
    private function recordClassExpressionUsage(Node $node)
74
    {
75 28
        if (($node instanceof Node\Expr\StaticCall
76 27
                || $node instanceof Node\Expr\StaticPropertyFetch
77 26
                || $node instanceof Node\Expr\ClassConstFetch
78 25
                || $node instanceof Node\Expr\New_
79 28
                || $node instanceof Node\Expr\Instanceof_
80
            )
81 28
            && $node->class instanceof Node\Name
82
        ) {
83 10
            $this->recordUsageOf($node->class);
84
        }
85 28
    }
86
87 28
    private function recordCatchUsage(Node $node)
88
    {
89 28
        if ($node instanceof Node\Stmt\Catch_) {
90 5
            foreach ($node->types as $type) {
91 5
                $this->recordUsageOf($type);
92
            }
93
        }
94 28
    }
95
96 28
    private function recordFunctionCallUsage(Node $node)
97
    {
98 28
        if ($node instanceof Node\Expr\FuncCall
99 28
            && $node->name instanceof Node\Name
100
        ) {
101 6
            $this->recordUsageOf($node->name);
102
        }
103 28
    }
104
105 28
    private function recordFunctionParameterTypesUsage(Node $node)
106
    {
107 28
        if ($node instanceof Node\Stmt\Function_
108 28
            || $node instanceof Node\Stmt\ClassMethod
109
        ) {
110 13
            foreach ($node->getParams() as $param) {
111 9
                if ($param->type instanceof Node\Name) {
112 7
                    $this->recordUsageOf($param->type);
113
                }
114 9
                if (is_string($param->type) || $param->type instanceof Node\Identifier) {
115 6
                    $this->recordUsageOfByString($param->type);
116
                }
117
            }
118
        }
119 28
    }
120
121 28
    private function recordFunctionReturnTypeUsage(Node $node)
122
    {
123 28
        if ($node instanceof Node\Stmt\Function_
124 28
            || $node instanceof Node\Stmt\ClassMethod
125
        ) {
126 13
            if ($node->getReturnType() instanceof Node\Name) {
127 6
                $this->recordUsageOf($node->getReturnType());
128
            }
129 13
            if (is_string($node->getReturnType()) || $node->getReturnType() instanceof Node\Identifier) {
130 6
                $this->recordUsageOfByString($node->getReturnType());
131
            }
132
        }
133 28
    }
134
135 28
    private function recordConstantFetchUsage(Node $node)
136
    {
137 28
        if ($node instanceof Node\Expr\ConstFetch) {
138 6
            $this->recordUsageOf($node->name);
139
        }
140 28
    }
141
142 28
    private function recordTraitUsage(Node $node)
143
    {
144 28
        if (!$node instanceof Node\Stmt\TraitUse) {
145 25
            return;
146
        }
147
148 3
        array_map([$this, 'recordUsageOf'], $node->traits);
149
150 3
        foreach ($node->adaptations as $adaptation) {
151 2
            if (null !== $adaptation->trait) {
152 1
                $this->recordUsageOf($adaptation->trait);
153
            }
154
155 2
            if ($adaptation instanceof Node\Stmt\TraitUseAdaptation\Precedence) {
156 1
                array_map([$this, 'recordUsageOf'], $adaptation->insteadof);
157
            }
158
        }
159 3
    }
160
161
    /**
162
     * @param Node\Name $symbol
163
     *
164
     * @return void
165
     */
166 24
    private function recordUsageOf(Node\Name $symbol)
167
    {
168 24
        $this->collectedSymbols[(string)$symbol] = $symbol;
169 24
    }
170
171
    /**
172
     * @param string $symbol
173
     *
174
     * @return void
175
     */
176 8
    private function recordUsageOfByString(string $symbol)
177
    {
178 8
        $this->collectedSymbols[$symbol] = $symbol;
179 8
    }
180
}
181