ComposerRequireCheckerTest\Cli\CheckCommandGetManualListTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testBuildManualList()	0	6	1
A	provideBuildManualList()	0	10	1
A	getInputMockForManualList()	0	13	2

<?php

namespace ComposerRequireCheckerTest\Cli;

use ComposerRequireChecker\Cli\CheckCommand;
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use ReflectionMethod;
use Symfony\Component\Console\Input\InputInterface;

class CheckCommandGetManualListTest extends TestCase
{
    /**
     * @return array
     */
    public function provideBuildManualList():array
    {
        $method = (new ReflectionClass(CheckCommand::class))->getMethod('buildManualList');
        $method->setAccessible(true);
        return [
            [$this->getInputMockForManualList(), $method, []],
            [$this->getInputMockForManualList(
                ['abc', 'nope', 'abc/hi:Abc\\:src', 'abc/def/qoi:Qui\\:src/lib/ext', 'abc/def/:Qui\\:src/lib/ext']),
                $method,
                ['abc/def/qoi', 'abc/hi']
            ],
        ];
    }

    /**
     * @param array $return
     * @return InputInterface
     */
    private function getInputMockForManualList(array $return = [])
    {
        $input = $this->getMockBuilder(InputInterface::class)->getMock();
        $hasReturn = count($return)>0;
        $input->expects($this->once())
            ->method('hasOption')
            ->with('register-namespace')

'register-namespace' of type string is incompatible with the type array expected by parameter $arguments of PHPUnit\Framework\MockObject\Builder\InvocationMocker::with().

            ->willReturn($hasReturn);
        $input->expects($hasReturn?$this->once():$this->never())
            ->method('getOption')
            ->with('register-namespace')
            ->willReturn($return);
        return $input;

The expression return $input returns the type PHPUnit\Framework\MockObject\MockObject which is incompatible with the documented return type Symfony\Component\Console\Input\InputInterface.

    }

    /**
     * Since the command does so much, there's no reasonable way to supply test data
     * @test
     */
    public function testBuildManualList(InputInterface $input, ReflectionMethod $method, array $expected)
    {
        $instance = new CheckCommand();
        $result = $method->invoke($instance, $input, __FILE__);
        $this->assertCount(count($expected), $result);
        $this->assertCount(0, array_diff(array_keys($result), $expected));

It seems like $result can also be of type Countable and Traversable; however, parameter $input of array_keys() does only seem to accept array, maybe add an additional type check?

    }
}