Passed
Push — develop ( 6e52cc...15d896 )
by Kevin
05:03 queued 02:32
created

ConfigurationSet   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 55
Duplicated Lines 21.82 %

Coupling/Cohesion

Components 1
Dependencies 9

Test Coverage

Coverage 96.67%

Importance

Changes 3
Bugs 0 Features 0
Metric Value
wmc 5
c 3
b 0
f 0
lcom 1
cbo 9
dl 12
loc 55
ccs 29
cts 30
cp 0.9667
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A configure() 12 12 1
B execute() 0 32 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Magium\Configuration\Console\Command;
4
5
use Magium\Configuration\Config\Config;
6
use Magium\Configuration\Config\ConfigInterface;
7
use Magium\Configuration\MagiumConfigurationFactory;
8
use Magium\Configuration\MagiumConfigurationFactoryInterface;
9
use Symfony\Component\Console\Command\Command;
10
use Symfony\Component\Console\Input\InputArgument;
11
use Symfony\Component\Console\Input\InputInterface;
12
use Symfony\Component\Console\Input\InputOption;
13
use Symfony\Component\Console\Output\OutputInterface;
14
15
class ConfigurationSet extends Command
16
{
17
    use ConfigurationFactoryTrait;
18
19
    const COMMAND = 'magium:configuration:set';
20
21 3 View Code Duplication
    protected function configure()
22
    {
23
        $this
24 3
            ->setName(self::COMMAND)
25 3
            ->setDescription('Set a configuration value')
26 3
            ->setHelp("This command sets a value for a specific configuration path")
27
        ;
28
29 3
        $this->addArgument('path', InputArgument::REQUIRED, 'Configuration Path');
30 3
        $this->addArgument('value', InputArgument::OPTIONAL, 'Value');
31 3
        $this->addArgument('context', InputArgument::OPTIONAL, 'Configuration Context', Config::CONTEXT_DEFAULT);
32 3
    }
33
34
35 2
    protected function execute(InputInterface $input, OutputInterface $output)
36
    {
37 2
        $factory = $this->getConfigurationFactory();
38 2
        $builderFactory = $factory->getBuilderFactory();
39 2
        $path = $input->getArgument('path');
40 2
        $value = $input->getArgument('value');
41 2
        $context = $input->getArgument('context');
42
43 2
        $structure = $factory->getBuilder()->getMergedStructure();
44 2
        $structure->registerXPathNamespace('s', 'http://www.magiumlib.com/Configuration');
45 2
        $paths = explode('/', $path);
46 2
        $xpath = '/';
47 2
        foreach ($paths as $pathName) {
48 2
            $xpath .= sprintf('/s:*[@id="%s"]', $pathName);
49
        }
50
51 2
        $results = $structure->xpath($xpath);
52 2
        if (!$results) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
53 1
            throw new UnconfiguredPathException(sprintf('Path (%s) is not configured.  Do you need to create a configuration file?', $path));
54
        }
55
56 1
        $builderFactory->getPersistence()->setValue($path, $value, $context);
57
58 1
        if (!$value) {
59
            $value = '<empty>';
60
        }
61
62 1
        $out = sprintf("Set %s to %s (context: %s)", $path, $value, $context);
63
64 1
        $output->writeln($out);
65 1
        $output->writeln("Don't forget to rebuild your configuration cache with " . ConfigurationBuild::COMMAND);
66 1
    }
67
68
69
}
70