Magium\Configuration\Config\ConfigurationRepository

Complexity

Total Complexity

7

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hasValue()	0	10	2
A	getValue()	0	11	2
A	getValueFlag()	0	10	3

<?php

namespace Magium\Configuration\Config;

class ConfigurationRepository extends \SimpleXMLElement implements ConfigInterface
{

    const CONTEXT_DEFAULT = 'default';

    protected static $allowedTrues = [
        true, 'true', 1, '1', 'on', 'yes'
    ];

    public function hasValue($path)
    {
        list($section, $group, $element) = explode('/', $path);
        $xpath = sprintf('/*/%s/%s/%s', $section, $group, $element);
        $element = $this->xpath($xpath);
        if ($element) {

The expression $element of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return true;
        }
        return false;
    }

    public function getValue($path)
    {
        list($section, $group, $element) = explode('/', $path);
        $xpath = sprintf('/*/%s/%s/%s', $section, $group, $element);
        $element = $this->xpath($xpath);
        if (empty($element)) {
            return null;
        }
        $value = (string)$element[0];
        return $value;
    }

    public function getValueFlag($path)
    {
        $value = $this->getValue($path);
        foreach (self::$allowedTrues as $true) {
            if ($value === $true) {
                return true;
            }
        }
        return false;
    }
}