Magium\Configuration\Console\Command\ConfigurationSet

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	21.05 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

96.77%

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	12	12	1
B	execute()	0	34	4

<?php

namespace Magium\Configuration\Console\Command;

use Magium\Configuration\Config\ConfigurationRepository;
use Magium\Configuration\Config\ConfigInterface;
use Magium\Configuration\MagiumConfigurationFactory;
use Magium\Configuration\MagiumConfigurationFactoryInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class ConfigurationSet extends Command
{
    use ConfigurationFactoryTrait;

    const COMMAND = 'magium:configuration:set';

    protected function configure()
    {
        $this
            ->setName(self::COMMAND)
            ->setDescription('Set a configuration value')
            ->setHelp("This command sets a value for a specific configuration path")
        ;

        $this->addArgument('path', InputArgument::REQUIRED, 'Configuration Path');
        $this->addArgument('value', InputArgument::OPTIONAL, 'Value');
        $this->addArgument('context', InputArgument::OPTIONAL, 'Configuration Context', ConfigurationRepository::CONTEXT_DEFAULT);
    }


    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $factory = $this->getConfigurationFactory();
        $builderFactory = $factory->getBuilderFactory();

The method getBuilderFactory() does not exist on Magium\Configuration\MagiumConfigurationFactoryInterface. Did you maybe mean getBuilder()?

        $path = $input->getArgument('path');
        $value = $input->getArgument('value');
        $context = $input->getArgument('context');

        $structure = $factory->getBuilder()->getMergedStructure();
        $xml = $structure->asXML();

$xml is not used, you could remove the assignment.

        $structure->registerXPathNamespace('s', 'http://www.magiumlib.com/Configuration');
        $paths = explode('/', $path);
        $xpath = '/';
        foreach ($paths as $pathName) {
            $xpath .= sprintf('/s:*[@identifier="%s"]', $pathName);
        }

        $results = $structure->xpath($xpath);
        if (!$results) {

The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new UnconfiguredPathException(sprintf('Path (%s) is not configured.  Do you need to create a configuration file?', $path));
        }

        $builderFactory->getBuilder()->setValue($path, $value, $context);

        if (!$value) {
            $value = '<empty>';
        }

        $out = sprintf("Set %s to %s (context: %s)", $path, $value, $context);

        $output->writeln($out);
        $output->writeln("Don't forget to rebuild your configuration cache with " . ConfigurationBuild::COMMAND);
    }


}