ConfigurationFileRepository::__construct() - Code Metrics - Inspection of "Attempting to fix code coverage" - magium/configuration-manager - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — develop (#18)

by Kevin

created 2017-02-14 16:37 UTC

ConfigurationFileRepository::__construct() D

↳ Parent: ConfigurationFileRepository

Complexity

Conditions	10
Paths	34

Size

Total Lines	42
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	42
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	27
nc	34
nop	2

How to fix Complexity

<?php

namespace Magium\Configuration\File\Configuration;

use Magium\Configuration\Config\InvalidConfigurationLocationException;
use Magium\Configuration\Config\InvalidDirectoryException;
use Magium\Configuration\File\AdapterInterface;
use Magium\Configuration\File\InvalidFileException;

class ConfigurationFileRepository implements \ArrayAccess, \Iterator, \Countable
{
    protected $files = [];
    protected $secureBases = [];

    public function __construct(array $secureBases = [], array $configurationFiles = [])
    {
        foreach ($secureBases as $base) {
            $this->addSecureBase($base);
        }

        $supportedTypes = [];
        if (!empty($configurationFiles)) {
            $checkSupportedTypes = glob(__DIR__ . '/*File.php');
            foreach ($checkSupportedTypes as $file) {
                $file = basename($file);
                if ($file != 'AbstractConfigurationFile.php') {
                    $match = null;
                    if (preg_match('/^([a-zA-Z]+)File.php$/', $file, $match)) {
                        $supportedTypes[] = strtolower($match[1]);
                    }
                }
            }
        }

        foreach ($configurationFiles as $file) {
            $fileName = basename($file);
            $typeFound = false;
            foreach ($supportedTypes as $type) {
                if (strpos($fileName, '.' . $type) !== false) {
                    $class = 'Magium\Configuration\File\Configuration\\' . ucfirst($type) . 'File';
                    $configurationFile = new $class($file);
                    $this->registerConfigurationFile($configurationFile);
                    $typeFound = true;
                }
            }
            if (!$typeFound) {
                throw new UnsupportedFileTypeException(
                    sprintf(
                        'File %s does not have a supported file extension: %s',
                        $file,
                        implode(',', $supportedTypes)
                    ))
                ;
            }
        }
    }

    public function count()
    {
        return count($this->files);
    }

    public function registerConfigurationFile(AdapterInterface $file)
    {
        if (isset($this->files[$file->getFile()])) {
            throw new InvalidFileException('The file has been added already: ' . $file->getFile());
        }
        $this->files[$file->getFile()] = $file;
    }

    public function addSecureBase($base)
    {
        $path = realpath($base);
        if (!is_dir($path)) {
            throw new InvalidDirectoryException('Unable to determine real path for directory: ' . $base);
        }
        $this->secureBases[] = $path;
    }

    protected function checkFileLocation(AdapterInterface $file)
    {
        $path = realpath($file->getFile());
        $inSecurePath = false;
        foreach ($this->secureBases as $base) {
            if (strpos($path, $base) === 0) {
                $inSecurePath = true;
                break;
            }
        }

        if (!$inSecurePath) {
            throw new InvalidConfigurationLocationException($path . ' is not in one of the designated secure configuration paths.');
        }
    }

    /**
     * Retrieves a list of secure base directories
     *
     * @return array
     */

    public function getSecureBases()
    {
        return $this->secureBases;
    }

    public function current()
    {
        $current =  current($this->files);
        $this->checkFileLocation($current);
        return $current;
    }

    public function next()
    {
        $next = next($this->files);
        if (!is_bool($next)) {
            $this->checkFileLocation($next);
        }
        return $next;
    }

    public function key()
    {
        return key($this->files);
    }

    public function valid()
    {
        $key = $this->key();
        $var = ($key !== NULL && $key !== FALSE);
        return $var;
    }

    public function rewind()
    {
        return reset($this->files);
    }

    public function offsetExists($offset)
    {
        return isset($this->files[$offset]);
    }

    public function offsetGet($offset)
    {
        $get = $this->files[$offset];
        $this->checkFileLocation($get);
        return $get;
    }

    public function offsetSet($offset, $value)
    {
        $this->registerConfigurationFile($value);
    }

    public function offsetUnset($offset)
    {
        unset($this->files[$offset]);
    }

}


1			<?php
2
3			namespace Magium\Configuration\File\Configuration;
4
5			use Magium\Configuration\Config\InvalidConfigurationLocationException;
6			use Magium\Configuration\Config\InvalidDirectoryException;
7			use Magium\Configuration\File\AdapterInterface;
8			use Magium\Configuration\File\InvalidFileException;
9
10			class ConfigurationFileRepository implements \ArrayAccess, \Iterator, \Countable
11			{
12			protected $files = [];
13			protected $secureBases = [];
14
15			public function __construct(array $secureBases = [], array $configurationFiles = [])
16			{
17			foreach ($secureBases as $base) {
18			$this->addSecureBase($base);
19			}
20
21			$supportedTypes = [];
22			if (!empty($configurationFiles)) {
23			$checkSupportedTypes = glob(__DIR__ . '/*File.php');
24			foreach ($checkSupportedTypes as $file) {
25			$file = basename($file);
26			if ($file != 'AbstractConfigurationFile.php') {
27			$match = null;
28			if (preg_match('/^([a-zA-Z]+)File.php$/', $file, $match)) {
29			$supportedTypes[] = strtolower($match[1]);
30			}
31			}
32			}
33			}
34
35			foreach ($configurationFiles as $file) {
36			$fileName = basename($file);
37			$typeFound = false;
38			foreach ($supportedTypes as $type) {
39			if (strpos($fileName, '.' . $type) !== false) {
40			$class = 'Magium\Configuration\File\Configuration\\' . ucfirst($type) . 'File';
41			$configurationFile = new $class($file);
42			$this->registerConfigurationFile($configurationFile);
43			$typeFound = true;
44			}
45			}
46			if (!$typeFound) {
47			throw new UnsupportedFileTypeException(
48			sprintf(
49			'File %s does not have a supported file extension: %s',
50			$file,
51			implode(',', $supportedTypes)
52			))
53			;
54			}
55			}
56			}
57
58			public function count()
59			{
60			return count($this->files);
61			}
62
63			public function registerConfigurationFile(AdapterInterface $file)
64			{
65			if (isset($this->files[$file->getFile()])) {
66			throw new InvalidFileException('The file has been added already: ' . $file->getFile());
67			}
68			$this->files[$file->getFile()] = $file;
69			}
70
71			public function addSecureBase($base)
72			{
73			$path = realpath($base);
74			if (!is_dir($path)) {
75			throw new InvalidDirectoryException('Unable to determine real path for directory: ' . $base);
76			}
77			$this->secureBases[] = $path;
78			}
79
80			protected function checkFileLocation(AdapterInterface $file)
81			{
82			$path = realpath($file->getFile());
83			$inSecurePath = false;
84			foreach ($this->secureBases as $base) {
85			if (strpos($path, $base) === 0) {
86			$inSecurePath = true;
87			break;
88			}
89			}
90
91			if (!$inSecurePath) {
92			throw new InvalidConfigurationLocationException($path . ' is not in one of the designated secure configuration paths.');
93			}
94			}
95
96			/**
97			* Retrieves a list of secure base directories
98			*
99			* @return array
100			*/
101
102			public function getSecureBases()
103			{
104			return $this->secureBases;
105			}
106
107			public function current()
108			{
109			$current = current($this->files);
110			$this->checkFileLocation($current);
111			return $current;
112			}
113
114			public function next()
115			{
116			$next = next($this->files);
117			if (!is_bool($next)) {
118			$this->checkFileLocation($next);
119			}
120			return $next;
121			}
122
123			public function key()
124			{
125			return key($this->files);
126			}
127
128			public function valid()
129			{
130			$key = $this->key();
131			$var = ($key !== NULL && $key !== FALSE);
132			return $var;
133			}
134
135			public function rewind()
136			{
137			return reset($this->files);
138			}
139
140			public function offsetExists($offset)
141			{
142			return isset($this->files[$offset]);
143			}
144
145			public function offsetGet($offset)
146			{
147			$get = $this->files[$offset];
148			$this->checkFileLocation($get);
149			return $get;
150			}
151
152			public function offsetSet($offset, $value)
153			{
154			$this->registerConfigurationFile($value);
155			}
156
157			public function offsetUnset($offset)
158			{
159			unset($this->files[$offset]);
160			}
161
162			}
163

magium / configuration-manager

Pull Request — develop (#18)

ConfigurationFileRepository::__construct() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like