magium / MagiumMagento

lib/Magento/Actions/Admin/Configuration/SettingModifier.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Magium\Magento\Actions\Admin\Configuration;
 
-use Facebook\WebDriver\WebDriverElement;
-use Facebook\WebDriver\WebDriverSelect;
 use Magium\Magento\AbstractMagentoTestCase;
 use Magium\Magento\Navigators\Admin\SystemConfiguration;
 use Magium\Magento\Themes\Admin\ThemeConfiguration;

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
             $xpath = '';
             if (count($xpath) === 2) {
                 $nav = explode('/', $parts[0]);
-                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]) . '/descendant::';
+                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]).'/descendant::';
             }
             $xpath .= $this->themeConfiguration->getSystemConfigSettingLabelXpath($matches[1]);
             $labelElement = $this->webDriver->byXpath($xpath);

lib/Magento/Actions/Checkout/CustomerCheckout.php

Unused Use Statements -2 removed lines

@@ -6,8 +6,6 @@
 use Magium\Magento\Actions\Checkout\Steps\LogInCustomer;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
 use Magium\Magento\Extractors\Checkout\CartSummary;

lib/Magento/Actions/Checkout/GuestCheckout.php

Unused Use Statements -2 removed lines

@@ -5,7 +5,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\BillingAddress;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
 use Magium\Magento\Actions\Checkout\Steps\SelectGuestCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -14,7 +13,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class GuestCheckout extends AbstractCheckout
 {

lib/Magento/Actions/Checkout/RegisterNewCustomerCheckout.php

Unused Use Statements -3 removed lines

@@ -6,8 +6,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\NewCustomerPassword;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\SelectRegisterNewCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -16,7 +14,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class RegisterNewCustomerCheckout extends AbstractCheckout
 {

lib/Magento/Extractors/Catalog/LayeredNavigation/FilterTypes/SwatchFilter.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Magium\Magento\Extractors\Catalog\LayeredNavigation\FilterTypes;
 
-use Facebook\WebDriver\WebDriverBy;
-use Facebook\WebDriver\WebDriverElement;
 use Magium\Magento\Extractors\Catalog\LayeredNavigation\FilterValue;
 use Magium\Magento\Extractors\Catalog\LayeredNavigation\UnparseableValueException;
 

Spacing +2 added lines, -2 removed lines

@@ -44,8 +44,8 @@
         /* @var $elements \DOMElement[] */
         $returnElements = [];
         foreach ($elements as $element) {
-            $elementDocument  = new \DOMDocument();
-            $html  =$element->C14N();
+            $elementDocument = new \DOMDocument();
+            $html = $element->C14N();
             $elementDocument->loadXML($html);
             $elementXpath = new \DOMXPath($elementDocument);
             $titleElements = $elementXpath->query(sprintf('//*[@%s]', $this->theme->getLayeredNavigationSwatchTitleAttribute()));

lib/Magento/Themes/MagentoEE114/Customer/ThemeConfiguration.php

Spacing +9 added lines, -9 removed lines

@@ -7,26 +7,26 @@ 
 class ThemeConfiguration extends AbstractThemeConfiguration
 {
 
-    public $accountNavigationXpath   = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
+    public $accountNavigationXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
     public $accountSectionHeaderXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," col-main ")]/descendant::h1[.="%s"]';
 
-    public $orderPageName     = '{{My Orders}}';
+    public $orderPageName = '{{My Orders}}';
 
     public $viewOrderLinkXpath = '//td[@class="number" and .="%s"]/../td/descendant::a[.="{{View Order}}"]';
 
-    public $orderPageTitleContainsText    = '{{Order}} #';
+    public $orderPageTitleContainsText = '{{Order}} #';
 
     /**
      * @var string Xpath for the customer email form element
      */
 
-    public $loginUsernameField           = '//input[@type="email" and @id="email"]';
+    public $loginUsernameField = '//input[@type="email" and @id="email"]';
 
     /**
      * @var string Xpath for the customer password form element
      */
 
-    public $loginPasswordField           = '//input[@type="password" and @id="pass"]';
+    public $loginPasswordField = '//input[@type="password" and @id="pass"]';
 
 
     /**
@@ -41,19 +41,19 @@ 
     public $orderShippingMethod = '//h2[.="{{Shipping Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
     public $orderPaymentMethod = '//h2[.="{{Payment Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
 
-    public $orderItemNameXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
+    public $orderItemNameXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
     public $orderItemSkuXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="SKU"]';
-    public $orderItemPriceXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Price"]/descendant::span[@class="price"]';
+    public $orderItemPriceXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Price"]/descendant::span[@class="price"]';
     public $orderItemQtyXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Qty"]';
 
     public $orderItemQtyOrderedRegex = '/{{Ordered}}:\s+(\d+)/';
     public $orderItemQtyShippedRegex = '/{{Shipped}}:\s+(\d+)/';
 
-    public $orderItemSubtotalXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Subtotal"]/descendant::span[@class="price"]';
+    public $orderItemSubtotalXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Subtotal"]/descendant::span[@class="price"]';
 
     public $orderSubtotalXpath             = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," subtotal ")]/td[2]/span[@class="price"]';
     public $orderShippingAndHandlingXpath  = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," shipping ")]/td[2]/span[@class="price"]';
-    public $orderTaxXpath                 = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
+    public $orderTaxXpath = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
     public $orderGrandTotalXpath         = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," grand_total ")]/td[2]/descendant::span[@class="price"]';
 
     public $orderDateXpath               = '//p[@class="order-date"]';

lib/Magento/Themes/MagentoEE113/Customer/ThemeConfiguration.php

Spacing +11 added lines, -11 removed lines

@@ -8,20 +8,20 @@ 
 class ThemeConfiguration extends AbstractThemeConfiguration
 {
 
-    public $accountNavigationXpath   = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
+    public $accountNavigationXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
     public $accountSectionHeaderXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," col-main ")]/descendant::h1[.="%s"]';
 
-    public $orderPageName     = '{{My Orders}}';
+    public $orderPageName = '{{My Orders}}';
 
     public $viewOrderLinkXpath = '//td[.="%s"]/../td/descendant::a[.="{{View Order}}"]';
 
-    public $orderPageTitleContainsText    = '{{Order}} #';
+    public $orderPageTitleContainsText = '{{Order}} #';
 
     /**
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
      */
 
-    public $registrationNavigationInstructions         = [
+    public $registrationNavigationInstructions = [
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Register"]']
     ];
@@ -30,7 +30,7 @@ 
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
      */
 
-    public $logoutNavigationInstructions         = [
+    public $logoutNavigationInstructions = [
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Log Out"]']
     ];
@@ -49,13 +49,13 @@ 
      * @var string Xpath for the customer email form element
      */
 
-    public $loginUsernameField           = '//input[@type="text" and @id="email"]';
+    public $loginUsernameField = '//input[@type="text" and @id="email"]';
 
     /**
      * @var string Xpath for the customer password form element
      */
 
-    public $loginPasswordField           = '//input[@type="password" and @id="pass"]';
+    public $loginPasswordField = '//input[@type="password" and @id="pass"]';
 
 
     /**
@@ -70,19 +70,19 @@ 
     public $orderShippingMethod = '//h2[.="{{Shipping Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
     public $orderPaymentMethod = '//h2[.="{{Payment Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
 
-    public $orderItemNameXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
+    public $orderItemNameXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
     public $orderItemSkuXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[2]';
-    public $orderItemPriceXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
+    public $orderItemPriceXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
     public $orderItemQtyXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[4]';
 
     public $orderItemQtyOrderedRegex = '/{{Ordered}}:\s+(\d+)/';
     public $orderItemQtyShippedRegex = '/{{Shipped}}:\s+(\d+)/';
 
-    public $orderItemSubtotalXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
+    public $orderItemSubtotalXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
 
     public $orderSubtotalXpath             = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," subtotal ")]/td[2]/span[@class="price"]';
     public $orderShippingAndHandlingXpath  = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," shipping ")]/td[2]/span[@class="price"]';
-    public $orderTaxXpath                 = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
+    public $orderTaxXpath = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
     public $orderGrandTotalXpath         = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," grand_total ")]/td[2]/descendant::span[@class="price"]';
 
     public $orderDateXpath               = '//p[@class="order-date"]';

lib/Magento/Themes/Admin/ThemeConfiguration.php

Spacing +14 added lines, -14 removed lines

@@ -23,16 +23,16 @@ 
 //    public $navigationChildXPathSelector1         = 'li/descendant::span[.="{{%s}}"]';
     public $navigationChildXPathSelector         = 'a[concat(" ",normalize-space(.)," ") = " {{%s}} "]/..';
 
-    public $adminPopupMessageContainerXpath         = '//*[@id="message-popup-window"]';
-    public $adminPopupMessageCloseButtonXpath        = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
+    public $adminPopupMessageContainerXpath = '//*[@id="message-popup-window"]';
+    public $adminPopupMessageCloseButtonXpath = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
 
-    public $systemConfigTabsXpath                = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
-    public $systemConfigSectionToggleXpath             = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
-    public $systemConfigSectionDisplayCheckXpath            = '//legend[.="{{%s}}"]/ancestor::fieldset';
-    public $systemConfigToggleEnableXpath            = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
+    public $systemConfigTabsXpath = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
+    public $systemConfigSectionToggleXpath = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
+    public $systemConfigSectionDisplayCheckXpath = '//legend[.="{{%s}}"]/ancestor::fieldset';
+    public $systemConfigToggleEnableXpath = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
 
-    public $xTreeRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
-    public $xTreeNamedRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
+    public $xTreeRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
+    public $xTreeNamedRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
     public $xTreeChildXpath                          = 'ul/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a/span[contains(concat("---",normalize-space(.)), "---{{%s}} (")]/..';
     public $xTreeChildNodePrefixXpath                = '/../..';
     public $xTreeChildNodeExpandPrefixXpath          = '/../img[contains(concat(" ",normalize-space(@class)," ")," x-tree-ec-icon ")]';
@@ -41,12 +41,12 @@ 
 
     public $systemConfigSaveSuccessfulXpath          = '//li[@class="success-msg"]/descendant::span[.="{{The configuration has been saved}}."]';
 
-    public $testLoggedInAtBaseUrl                     = '//a[@class="active"]/span[.="{{Dashboard}}"]';
+    public $testLoggedInAtBaseUrl = '//a[@class="active"]/span[.="{{Dashboard}}"]';
 
     public $tableButtonXpath                         = '//table[@class="actions"]/descendant::span[.="{{%s}}"]';
 
     public $selectOrderXpath                         = '//table[@id="sales_order_grid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{View}}"]';
-    public $selectCustomerXpath                         = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
+    public $selectCustomerXpath = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
 
     public $systemConfigSettingLabelXpath            = '//td[@class="label"]/label[.=" {{%s}}"]';
 
@@ -57,12 +57,12 @@ 
 
     public $guaranteedPageLoadedElementDisplayedXpath = '//div[@class="footer"]';
 
-    public $successfulActionXpath                    = '//li[@class="success-msg"]';
+    public $successfulActionXpath = '//li[@class="success-msg"]';
     public $errorActionXpath                    = '//li[@class="error-msg"]';
 
     public $shippingCarrierXpath                = '//select[@name="tracking[%d][carrier_code]"]';
-    public $shippingTitleXpath                = '//input[@name="tracking[%d][title]"]';
-    public $shippingTrackingNumberXpath                = '//input[@name="tracking[%d][number]"]';
+    public $shippingTitleXpath = '//input[@name="tracking[%d][title]"]';
+    public $shippingTrackingNumberXpath = '//input[@name="tracking[%d][number]"]';
 
     public $formButtonXpath = '//div[@class="content-header"]/p[@class="form-buttons"]/descendant::span[.="{{%s}}"]';
 
@@ -243,7 +243,7 @@ 
      * @var string
      */
 
-    public $searchButtonText                         = '{{Search}}';
+    public $searchButtonText = '{{Search}}';
 
     /**
      * @return Translator

lib/Magento/Themes/OnePageCheckout/AbstractThemeConfiguration.php

Spacing +5 added lines, -5 removed lines

@@ -569,7 +569,7 @@ 
      */
     public function getBillingAddressXpath()
     {
-        return$this->translatePlaceholders( $this->billingAddressXpath);
+        return$this->translatePlaceholders($this->billingAddressXpath);
     }
 
     /**
@@ -677,7 +677,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopPriceXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -686,7 +686,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopNameXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -695,7 +695,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopQtyXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -704,7 +704,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopSubtotalXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 
 use Magium\AbstractConfigurableElement;
-use Magium\Themes\ThemeConfigurationInterface;
 
 abstract class AbstractThemeConfiguration extends AbstractConfigurableElement
 {