GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Push — master ( cdf5e4...5833cb )
by Kevin
10:35 queued 08:21
created
lib/Magento/Actions/Admin/Configuration/SettingModifier.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
      * * Tab/Section::name=Text Of Setting (will ensure that the correct section is navigated to, uses setting name (exact), not ID)
58 58
      * * name=Text Of Setting (will not navigate, uses setting name (exact) not ID)
59 59
      *
60
-     * @param $identifier
60
+     * @param string $identifier
61 61
      * @param $value
62 62
      * @throws \Magium\InvalidInstructionException
63 63
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
             $xpath = '';
78 78
             if (count($xpath) === 2) {
79 79
                 $nav = explode('/', $parts[0]);
80
-                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]) . '/descendant::';
80
+                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]).'/descendant::';
81 81
             }
82 82
             $xpath .= $this->themeConfiguration->getSystemConfigSettingLabelXpath($matches[1]);
83 83
             $labelElement = $this->webDriver->byXpath($xpath);
Please login to merge, or discard this patch.
lib/Magento/Extractors/Admin/Login/Messages.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@
 block discarded – undo
43 43
         return $this->messages;
44 44
     }
45 45
 
46
+    /**
47
+     * @param string $message
48
+     */
46 49
     public function addMessage($message)
47 50
     {
48 51
         $this->messages[] = $message;
Please login to merge, or discard this patch.
lib/Magento/Extractors/Admin/Xtree/CategoryTreeNode.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
     /**
29 29
      * @param $nodePath
30
-     * @return WebDriverElement
30
+     * @return null|\Facebook\WebDriver\Remote\RemoteWebElement
31 31
      */
32 32
 
33 33
     public function getNode($nodePath)
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
         $previousExpandXpath = '';
59 59
         $element = null;
60 60
         foreach ($parts as $part) {
61
-            $xpath .= '/' . $this->theme->getXTreeChildXpath($part);
62
-            if(!$this->webDriver->elementExists($xpath, WebDriver::BY_XPATH)) {
61
+            $xpath .= '/'.$this->theme->getXTreeChildXpath($part);
62
+            if (!$this->webDriver->elementExists($xpath, WebDriver::BY_XPATH)) {
63 63
                 if ($previousExpandXpath) {
64 64
                     $this->testCase->assertElementExists($previousExpandXpath, WebDriver::BY_XPATH);
65 65
                     $this->webDriver->byXpath($previousExpandXpath)->click();
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
             $this->testCase->assertElementExists($xpath, WebDriver::BY_XPATH);
71 71
             $element = $this->webDriver->byXpath($xpath);
72 72
             if (!$element->isDisplayed()) {
73
-                throw new ElementNotVisibleException('Node element is not visible and cannot be made visible: ' . $part);
73
+                throw new ElementNotVisibleException('Node element is not visible and cannot be made visible: '.$part);
74 74
             }
75
-            $previousExpandXpath = $xpath . $this->theme->getXTreeChildNodeExpandPrefixXpath();
75
+            $previousExpandXpath = $xpath.$this->theme->getXTreeChildNodeExpandPrefixXpath();
76 76
             $xpath .= $this->theme->getXTreeChildNodePrefixXpath();
77 77
         }
78 78
         $this->node = $element;
Please login to merge, or discard this patch.
lib/Magento/Extractors/Catalog/LayeredNavigation/LayeredNavigation.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -80,6 +80,9 @@
 block discarded – undo
80 80
     }
81 81
 
82 82
 
83
+    /**
84
+     * @param string $type
85
+     */
83 86
     public function addFilterType($type)
84 87
     {
85 88
         $type = $this->filterTypeName($type);
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -55,11 +55,11 @@  discard block
 block discarded – undo
55 55
     {
56 56
         $returnType = $type;
57 57
         if (strpos($type, '\\') === false) {
58
-            $returnType = $this->baseNamespace . '\\' . $type;
58
+            $returnType = $this->baseNamespace.'\\'.$type;
59 59
             if (!class_exists($returnType)) {
60 60
                 $returnType = $type;
61 61
                 if (!class_exists($returnType)) {
62
-                    throw new InvalidFilterException('Filter type must exist: ' . $returnType);
62
+                    throw new InvalidFilterException('Filter type must exist: '.$returnType);
63 63
                 }
64 64
             }
65 65
         }
@@ -69,12 +69,12 @@  discard block
 block discarded – undo
69 69
 
70 70
     protected function validateFilterType($returnType)
71 71
     {
72
-        if ($returnType == $this->baseNamespace . '\AbstractFilterType') {
72
+        if ($returnType == $this->baseNamespace.'\AbstractFilterType') {
73 73
             return true;
74 74
         }
75 75
         $reflection = new \ReflectionClass($returnType);
76
-        if (!$reflection->isSubclassOf($this->baseNamespace . '\AbstractFilterType')) {
77
-            throw new InvalidFilterException('Filter type must extend AbstractFilterType: ' . $returnType);
76
+        if (!$reflection->isSubclassOf($this->baseNamespace.'\AbstractFilterType')) {
77
+            throw new InvalidFilterException('Filter type must extend AbstractFilterType: '.$returnType);
78 78
         }
79 79
         return true;
80 80
     }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
             return $this->filterValues[$filterKey];
132 132
         }
133 133
 
134
-        throw new MissingFilterException('Could not find the filter: ' . $filter);
134
+        throw new MissingFilterException('Could not find the filter: '.$filter);
135 135
     }
136 136
 
137 137
     public function extract()
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                         break;
168 168
                     }
169 169
                 } else {
170
-                    throw new InvalidFilterException('Filter type does not extend AbstractFilterType: ' . $type);
170
+                    throw new InvalidFilterException('Filter type does not extend AbstractFilterType: '.$type);
171 171
                 }
172 172
             }
173 173
         }
Please login to merge, or discard this patch.
lib/Magento/Extractors/Catalog/Products/AbstractProductCollection.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -25,6 +25,10 @@
 block discarded – undo
25 25
         return $this->products;
26 26
     }
27 27
 
28
+    /**
29
+     * @param integer $count
30
+     * @param string $attribute
31
+     */
28 32
     protected function getByXpath($type, $count, $attribute = null, $getElement = false)
29 33
     {
30 34
         $xpath = $this->getElementXpath($type, $count);
Please login to merge, or discard this patch.
lib/Magento/Themes/MagentoEE114/Customer/ThemeConfiguration.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -7,26 +7,26 @@  discard block
 block discarded – undo
7 7
 class ThemeConfiguration extends AbstractThemeConfiguration
8 8
 {
9 9
 
10
-    public $accountNavigationXpath   = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
10
+    public $accountNavigationXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
11 11
     public $accountSectionHeaderXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," col-main ")]/descendant::h1[.="%s"]';
12 12
 
13
-    public $orderPageName     = '{{My Orders}}';
13
+    public $orderPageName = '{{My Orders}}';
14 14
 
15 15
     public $viewOrderLinkXpath = '//td[@class="number" and .="%s"]/../td/descendant::a[.="{{View Order}}"]';
16 16
 
17
-    public $orderPageTitleContainsText    = '{{Order}} #';
17
+    public $orderPageTitleContainsText = '{{Order}} #';
18 18
 
19 19
     /**
20 20
      * @var string Xpath for the customer email form element
21 21
      */
22 22
 
23
-    public $loginUsernameField           = '//input[@type="email" and @id="email"]';
23
+    public $loginUsernameField = '//input[@type="email" and @id="email"]';
24 24
 
25 25
     /**
26 26
      * @var string Xpath for the customer password form element
27 27
      */
28 28
 
29
-    public $loginPasswordField           = '//input[@type="password" and @id="pass"]';
29
+    public $loginPasswordField = '//input[@type="password" and @id="pass"]';
30 30
 
31 31
 
32 32
     /**
@@ -41,19 +41,19 @@  discard block
 block discarded – undo
41 41
     public $orderShippingMethod = '//h2[.="{{Shipping Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
42 42
     public $orderPaymentMethod = '//h2[.="{{Payment Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
43 43
 
44
-    public $orderItemNameXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
44
+    public $orderItemNameXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
45 45
     public $orderItemSkuXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="SKU"]';
46
-    public $orderItemPriceXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Price"]/descendant::span[@class="price"]';
46
+    public $orderItemPriceXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Price"]/descendant::span[@class="price"]';
47 47
     public $orderItemQtyXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Qty"]';
48 48
 
49 49
     public $orderItemQtyOrderedRegex = '/{{Ordered}}:\s+(\d+)/';
50 50
     public $orderItemQtyShippedRegex = '/{{Shipped}}:\s+(\d+)/';
51 51
 
52
-    public $orderItemSubtotalXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Subtotal"]/descendant::span[@class="price"]';
52
+    public $orderItemSubtotalXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[@data-rwd-label="Subtotal"]/descendant::span[@class="price"]';
53 53
 
54 54
     public $orderSubtotalXpath             = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," subtotal ")]/td[2]/span[@class="price"]';
55 55
     public $orderShippingAndHandlingXpath  = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," shipping ")]/td[2]/span[@class="price"]';
56
-    public $orderTaxXpath                 = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
56
+    public $orderTaxXpath = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
57 57
     public $orderGrandTotalXpath         = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," grand_total ")]/td[2]/descendant::span[@class="price"]';
58 58
 
59 59
     public $orderDateXpath               = '//p[@class="order-date"]';
Please login to merge, or discard this patch.
lib/Magento/Themes/MagentoEE113/Customer/ThemeConfiguration.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -8,20 +8,20 @@  discard block
 block discarded – undo
8 8
 class ThemeConfiguration extends AbstractThemeConfiguration
9 9
 {
10 10
 
11
-    public $accountNavigationXpath   = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
11
+    public $accountNavigationXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
12 12
     public $accountSectionHeaderXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," col-main ")]/descendant::h1[.="%s"]';
13 13
 
14
-    public $orderPageName     = '{{My Orders}}';
14
+    public $orderPageName = '{{My Orders}}';
15 15
 
16 16
     public $viewOrderLinkXpath = '//td[.="%s"]/../td/descendant::a[.="{{View Order}}"]';
17 17
 
18
-    public $orderPageTitleContainsText    = '{{Order}} #';
18
+    public $orderPageTitleContainsText = '{{Order}} #';
19 19
 
20 20
     /**
21 21
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
22 22
      */
23 23
 
24
-    public $registrationNavigationInstructions         = [
24
+    public $registrationNavigationInstructions = [
25 25
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
26 26
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Register"]']
27 27
     ];
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
31 31
      */
32 32
 
33
-    public $logoutNavigationInstructions         = [
33
+    public $logoutNavigationInstructions = [
34 34
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
35 35
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Log Out"]']
36 36
     ];
@@ -49,13 +49,13 @@  discard block
 block discarded – undo
49 49
      * @var string Xpath for the customer email form element
50 50
      */
51 51
 
52
-    public $loginUsernameField           = '//input[@type="text" and @id="email"]';
52
+    public $loginUsernameField = '//input[@type="text" and @id="email"]';
53 53
 
54 54
     /**
55 55
      * @var string Xpath for the customer password form element
56 56
      */
57 57
 
58
-    public $loginPasswordField           = '//input[@type="password" and @id="pass"]';
58
+    public $loginPasswordField = '//input[@type="password" and @id="pass"]';
59 59
 
60 60
 
61 61
     /**
@@ -70,19 +70,19 @@  discard block
 block discarded – undo
70 70
     public $orderShippingMethod = '//h2[.="{{Shipping Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
71 71
     public $orderPaymentMethod = '//h2[.="{{Payment Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
72 72
 
73
-    public $orderItemNameXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
73
+    public $orderItemNameXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
74 74
     public $orderItemSkuXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[2]';
75
-    public $orderItemPriceXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
75
+    public $orderItemPriceXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
76 76
     public $orderItemQtyXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[4]';
77 77
 
78 78
     public $orderItemQtyOrderedRegex = '/{{Ordered}}:\s+(\d+)/';
79 79
     public $orderItemQtyShippedRegex = '/{{Shipped}}:\s+(\d+)/';
80 80
 
81
-    public $orderItemSubtotalXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
81
+    public $orderItemSubtotalXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
82 82
 
83 83
     public $orderSubtotalXpath             = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," subtotal ")]/td[2]/span[@class="price"]';
84 84
     public $orderShippingAndHandlingXpath  = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," shipping ")]/td[2]/span[@class="price"]';
85
-    public $orderTaxXpath                 = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
85
+    public $orderTaxXpath = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
86 86
     public $orderGrandTotalXpath         = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," grand_total ")]/td[2]/descendant::span[@class="price"]';
87 87
 
88 88
     public $orderDateXpath               = '//p[@class="order-date"]';
Please login to merge, or discard this patch.
lib/Magento/Themes/Admin/ThemeConfiguration.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -23,16 +23,16 @@  discard block
 block discarded – undo
23 23
 //    public $navigationChildXPathSelector1         = 'li/descendant::span[.="{{%s}}"]';
24 24
     public $navigationChildXPathSelector         = 'a[concat(" ",normalize-space(.)," ") = " {{%s}} "]/..';
25 25
 
26
-    public $adminPopupMessageContainerXpath         = '//*[@id="message-popup-window"]';
27
-    public $adminPopupMessageCloseButtonXpath        = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
26
+    public $adminPopupMessageContainerXpath = '//*[@id="message-popup-window"]';
27
+    public $adminPopupMessageCloseButtonXpath = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
28 28
 
29
-    public $systemConfigTabsXpath                = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
30
-    public $systemConfigSectionToggleXpath             = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
31
-    public $systemConfigSectionDisplayCheckXpath            = '//legend[.="{{%s}}"]/ancestor::fieldset';
32
-    public $systemConfigToggleEnableXpath            = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
29
+    public $systemConfigTabsXpath = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
30
+    public $systemConfigSectionToggleXpath = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
31
+    public $systemConfigSectionDisplayCheckXpath = '//legend[.="{{%s}}"]/ancestor::fieldset';
32
+    public $systemConfigToggleEnableXpath = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
33 33
 
34
-    public $xTreeRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
35
-    public $xTreeNamedRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
34
+    public $xTreeRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
35
+    public $xTreeNamedRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
36 36
     public $xTreeChildXpath                          = 'ul/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a/span[contains(concat("---",normalize-space(.)), "---{{%s}} (")]/..';
37 37
     public $xTreeChildNodePrefixXpath                = '/../..';
38 38
     public $xTreeChildNodeExpandPrefixXpath          = '/../img[contains(concat(" ",normalize-space(@class)," ")," x-tree-ec-icon ")]';
@@ -41,12 +41,12 @@  discard block
 block discarded – undo
41 41
 
42 42
     public $systemConfigSaveSuccessfulXpath          = '//li[@class="success-msg"]/descendant::span[.="{{The configuration has been saved}}."]';
43 43
 
44
-    public $testLoggedInAtBaseUrl                     = '//a[@class="active"]/span[.="{{Dashboard}}"]';
44
+    public $testLoggedInAtBaseUrl = '//a[@class="active"]/span[.="{{Dashboard}}"]';
45 45
 
46 46
     public $tableButtonXpath                         = '//table[@class="actions"]/descendant::span[.="{{%s}}"]';
47 47
 
48 48
     public $selectOrderXpath                         = '//table[@id="sales_order_grid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{View}}"]';
49
-    public $selectCustomerXpath                         = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
49
+    public $selectCustomerXpath = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
50 50
 
51 51
     public $systemConfigSettingLabelXpath            = '//td[@class="label"]/label[.=" {{%s}}"]';
52 52
 
@@ -57,12 +57,12 @@  discard block
 block discarded – undo
57 57
 
58 58
     public $guaranteedPageLoadedElementDisplayedXpath = '//div[@class="footer"]';
59 59
 
60
-    public $successfulActionXpath                    = '//li[@class="success-msg"]';
60
+    public $successfulActionXpath = '//li[@class="success-msg"]';
61 61
     public $errorActionXpath                    = '//li[@class="error-msg"]';
62 62
 
63 63
     public $shippingCarrierXpath                = '//select[@name="tracking[%d][carrier_code]"]';
64
-    public $shippingTitleXpath                = '//input[@name="tracking[%d][title]"]';
65
-    public $shippingTrackingNumberXpath                = '//input[@name="tracking[%d][number]"]';
64
+    public $shippingTitleXpath = '//input[@name="tracking[%d][title]"]';
65
+    public $shippingTrackingNumberXpath = '//input[@name="tracking[%d][number]"]';
66 66
 
67 67
     public $formButtonXpath = '//div[@class="content-header"]/p[@class="form-buttons"]/descendant::span[.="{{%s}}"]';
68 68
 
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
      * @var string
244 244
      */
245 245
 
246
-    public $searchButtonText                         = '{{Search}}';
246
+    public $searchButtonText = '{{Search}}';
247 247
 
248 248
     /**
249 249
      * @return Translator
Please login to merge, or discard this patch.
lib/Magento/Themes/OnePageCheckout/AbstractThemeConfiguration.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
      */
570 570
     public function getBillingAddressXpath()
571 571
     {
572
-        return$this->translatePlaceholders( $this->billingAddressXpath);
572
+        return$this->translatePlaceholders($this->billingAddressXpath);
573 573
     }
574 574
 
575 575
     /**
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
      */
678 678
     public function getCartSummaryCheckoutProductLoopPriceXpath($itemCount)
679 679
     {
680
-        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath , $itemCount);
680
+        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath, $itemCount);
681 681
         return $this->translatePlaceholders($return);
682 682
     }
683 683
 
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
      */
687 687
     public function getCartSummaryCheckoutProductLoopNameXpath($itemCount)
688 688
     {
689
-        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath , $itemCount);
689
+        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath, $itemCount);
690 690
         return $this->translatePlaceholders($return);
691 691
     }
692 692
 
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
      */
696 696
     public function getCartSummaryCheckoutProductLoopQtyXpath($itemCount)
697 697
     {
698
-        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath , $itemCount);
698
+        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath, $itemCount);
699 699
         return $this->translatePlaceholders($return);
700 700
     }
701 701
 
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
      */
705 705
     public function getCartSummaryCheckoutProductLoopSubtotalXpath($itemCount)
706 706
     {
707
-        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath , $itemCount);
707
+        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath, $itemCount);
708 708
         return $this->translatePlaceholders($return);
709 709
     }
710 710
 
Please login to merge, or discard this patch.
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     }
139 139
 
140 140
     /**
141
-     * @return mixed
141
+     * @return string
142 142
      */
143 143
     public function getTermsAndConditionsSelectorXpath($term)
144 144
     {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
     }
330 330
 
331 331
     /**
332
-     * @param string $shippinFirstNameXpath
332
+     * @param string $shippingFirstNameXpath
333 333
      */
334 334
     public function setShippingFirstNameXpath($shippingFirstNameXpath)
335 335
     {
@@ -433,6 +433,7 @@  discard block
 block discarded – undo
433 433
     }
434 434
 
435 435
     /**
436
+     * @param string $region
436 437
      * @return string
437 438
      */
438 439
     public function getShippingRegionIdXpath($region)
@@ -466,6 +467,7 @@  discard block
 block discarded – undo
466 467
     }
467 468
 
468 469
     /**
470
+     * @param string $country
469 471
      * @return string
470 472
      */
471 473
     public function getShippingCountryIdXpath($country)
@@ -546,6 +548,9 @@  discard block
 block discarded – undo
546 548
         $this->shippingContinueCompletedXpath = $shippingContinueCompletedXpath;
547 549
     }
548 550
 
551
+    /**
552
+     * @return string
553
+     */
549 554
     public function getBillingContinueCompletedXpath()
550 555
     {
551 556
         return $this->translatePlaceholders($this->billingContinueCompletedXpath);
@@ -618,6 +623,7 @@  discard block
 block discarded – undo
618 623
     }
619 624
 
620 625
     /**
626
+     * @param string $region
621 627
      * @return string
622 628
      */
623 629
     public function getBillingRegionIdXpath($region)
@@ -635,6 +641,7 @@  discard block
 block discarded – undo
635 641
     }
636 642
 
637 643
     /**
644
+     * @param string $country
638 645
      * @return string
639 646
      */
640 647
     public function getBillingCountryIdXpath($country)
@@ -702,6 +709,7 @@  discard block
 block discarded – undo
702 709
 
703 710
 
704 711
     /**
712
+     * @param integer $itemCount
705 713
      * @return string
706 714
      */
707 715
     public function getCartSummaryCheckoutProductLoopPriceXpath($itemCount)
@@ -711,6 +719,7 @@  discard block
 block discarded – undo
711 719
     }
712 720
 
713 721
     /**
722
+     * @param integer $itemCount
714 723
      * @return string
715 724
      */
716 725
     public function getCartSummaryCheckoutProductLoopNameXpath($itemCount)
@@ -720,6 +729,7 @@  discard block
 block discarded – undo
720 729
     }
721 730
 
722 731
     /**
732
+     * @param integer $itemCount
723 733
      * @return string
724 734
      */
725 735
     public function getCartSummaryCheckoutProductLoopQtyXpath($itemCount)
@@ -729,6 +739,7 @@  discard block
 block discarded – undo
729 739
     }
730 740
 
731 741
     /**
742
+     * @param integer $itemCount
732 743
      * @return string
733 744
      */
734 745
     public function getCartSummaryCheckoutProductLoopSubtotalXpath($itemCount)
Please login to merge, or discard this patch.