magium / MagiumMagento

lib/Magento/Themes/MagentoEE113/Customer/ThemeConfiguration.php

Spacing +11 added lines, -11 removed lines

@@ -8,20 +8,20 @@ 
 class ThemeConfiguration extends AbstractThemeConfiguration
 {
 
-    public $accountNavigationXpath   = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
+    public $accountNavigationXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," block-account ")]/descendant::a[.="%s"]';
     public $accountSectionHeaderXpath = '//div[contains(concat(" ",normalize-space(@class)," ")," col-main ")]/descendant::h1[.="%s"]';
 
-    public $orderPageName     = '{{My Orders}}';
+    public $orderPageName = '{{My Orders}}';
 
     public $viewOrderLinkXpath = '//td[.="%s"]/../td/descendant::a[.="{{View Order}}"]';
 
-    public $orderPageTitleContainsText    = '{{Order}} #';
+    public $orderPageTitleContainsText = '{{Order}} #';
 
     /**
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
      */
 
-    public $registrationNavigationInstructions         = [
+    public $registrationNavigationInstructions = [
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Register"]']
     ];
@@ -30,7 +30,7 @@ 
      * @var array Instructions in an Xpath array syntax to get to the customer registration page
      */
 
-    public $logoutNavigationInstructions         = [
+    public $logoutNavigationInstructions = [
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@class="account-cart-wrapper"]/descendant::span[.="Account"]'],
         [\Magium\WebDriver\WebDriver::INSTRUCTION_MOUSE_CLICK, '//div[@id="header-account"]/descendant::a[@title="Log Out"]']
     ];
@@ -49,13 +49,13 @@ 
      * @var string Xpath for the customer email form element
      */
 
-    public $loginUsernameField           = '//input[@type="text" and @id="email"]';
+    public $loginUsernameField = '//input[@type="text" and @id="email"]';
 
     /**
      * @var string Xpath for the customer password form element
      */
 
-    public $loginPasswordField           = '//input[@type="password" and @id="pass"]';
+    public $loginPasswordField = '//input[@type="password" and @id="pass"]';
 
 
     /**
@@ -70,19 +70,19 @@ 
     public $orderShippingMethod = '//h2[.="{{Shipping Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
     public $orderPaymentMethod = '//h2[.="{{Payment Method}}"]/../../descendant::div[contains(concat(" ",normalize-space(@class)," ")," box-content ")]';
 
-    public $orderItemNameXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
+    public $orderItemNameXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::h3[contains(concat(" ",normalize-space(@class)," ")," product-name ")]';
     public $orderItemSkuXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[2]';
-    public $orderItemPriceXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
+    public $orderItemPriceXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[3]/descendant::span[@class="price"]';
     public $orderItemQtyXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[4]';
 
     public $orderItemQtyOrderedRegex = '/{{Ordered}}:\s+(\d+)/';
     public $orderItemQtyShippedRegex = '/{{Shipped}}:\s+(\d+)/';
 
-    public $orderItemSubtotalXpath           = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
+    public $orderItemSubtotalXpath = '//table[@id="my-orders-table"]/tbody/tr[%d]/descendant::td[5]/descendant::span[@class="price"]';
 
     public $orderSubtotalXpath             = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," subtotal ")]/td[2]/span[@class="price"]';
     public $orderShippingAndHandlingXpath  = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," shipping ")]/td[2]/span[@class="price"]';
-    public $orderTaxXpath                 = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
+    public $orderTaxXpath = '//table[@id="my-orders-table"]/descendant::td[concat(" ",normalize-space(.)," ") = " {{Tax}} "]/following-sibling::td[1]/span[@class="price"]';
     public $orderGrandTotalXpath         = '//table[@id="my-orders-table"]/descendant::tr[contains(concat(" ",normalize-space(@class)," ")," grand_total ")]/td[2]/descendant::span[@class="price"]';
 
     public $orderDateXpath               = '//p[@class="order-date"]';

lib/Magento/Themes/Admin/ThemeConfiguration.php

Spacing +14 added lines, -14 removed lines

@@ -23,16 +23,16 @@ 
 //    public $navigationChildXPathSelector1         = 'li/descendant::span[.="{{%s}}"]';
     public $navigationChildXPathSelector         = 'a[concat(" ",normalize-space(.)," ") = " {{%s}} "]/..';
 
-    public $adminPopupMessageContainerXpath         = '//*[@id="message-popup-window"]';
-    public $adminPopupMessageCloseButtonXpath        = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
+    public $adminPopupMessageContainerXpath = '//*[@id="message-popup-window"]';
+    public $adminPopupMessageCloseButtonXpath = '//*[@id="message-popup-window"]/descendant::*[@title="close"]';
 
-    public $systemConfigTabsXpath                = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
-    public $systemConfigSectionToggleXpath             = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
-    public $systemConfigSectionDisplayCheckXpath            = '//legend[.="{{%s}}"]/ancestor::fieldset';
-    public $systemConfigToggleEnableXpath            = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
+    public $systemConfigTabsXpath = '//ul[@id="system_config_tabs"]/descendant::a[concat(" ",normalize-space(.)," ") = " {{%s}} "]';
+    public $systemConfigSectionToggleXpath = '//form[@id="config_edit_form"]/descendant::div[contains(concat(" ",normalize-space(@class)," ")," section-config ")]/descendant::a[.="{{%s}}"]';
+    public $systemConfigSectionDisplayCheckXpath = '//legend[.="{{%s}}"]/ancestor::fieldset';
+    public $systemConfigToggleEnableXpath = '//legend[.="{{%s}}"]/../descendant::td[concat(" ",normalize-space(.)," ") = " {{Enabled}} "]/../td/descendant::select/option[@value="%d"]';
 
-    public $xTreeRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
-    public $xTreeNamedRootXpath                          = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
+    public $xTreeRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a';
+    public $xTreeNamedRootXpath = '//ul[contains(concat(" ",normalize-space(@class)," ")," x-tree-root-ct ")]/div/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a[contains(concat("---",normalize-space(.)), "---{{%s}} (")]';
     public $xTreeChildXpath                          = 'ul/li[contains(concat(" ",normalize-space(@class)," ")," x-tree-node ")]/div/a/span[contains(concat("---",normalize-space(.)), "---{{%s}} (")]/..';
     public $xTreeChildNodePrefixXpath                = '/../..';
     public $xTreeChildNodeExpandPrefixXpath          = '/../img[contains(concat(" ",normalize-space(@class)," ")," x-tree-ec-icon ")]';
@@ -41,12 +41,12 @@ 
 
     public $systemConfigSaveSuccessfulXpath          = '//li[@class="success-msg"]/descendant::span[.="{{The configuration has been saved}}."]';
 
-    public $testLoggedInAtBaseUrl                     = '//a[@class="active"]/span[.="{{Dashboard}}"]';
+    public $testLoggedInAtBaseUrl = '//a[@class="active"]/span[.="{{Dashboard}}"]';
 
     public $tableButtonXpath                         = '//table[@class="actions"]/descendant::span[.="{{%s}}"]';
 
     public $selectOrderXpath                         = '//table[@id="sales_order_grid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{View}}"]';
-    public $selectCustomerXpath                         = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
+    public $selectCustomerXpath = '//table[@id="customerGrid_table"]/descendant::td[concat(" ",normalize-space(.)," ") = " %s "]/../td/a[.="{{Edit}}"]';
 
     public $systemConfigSettingLabelXpath            = '//td[@class="label"]/label[.=" {{%s}}"]';
 
@@ -57,12 +57,12 @@ 
 
     public $guaranteedPageLoadedElementDisplayedXpath = '//div[@class="footer"]';
 
-    public $successfulActionXpath                    = '//li[@class="success-msg"]';
+    public $successfulActionXpath = '//li[@class="success-msg"]';
     public $errorActionXpath                    = '//li[@class="error-msg"]';
 
     public $shippingCarrierXpath                = '//select[@name="tracking[%d][carrier_code]"]';
-    public $shippingTitleXpath                = '//input[@name="tracking[%d][title]"]';
-    public $shippingTrackingNumberXpath                = '//input[@name="tracking[%d][number]"]';
+    public $shippingTitleXpath = '//input[@name="tracking[%d][title]"]';
+    public $shippingTrackingNumberXpath = '//input[@name="tracking[%d][number]"]';
 
     public $formButtonXpath = '//div[@class="content-header"]/p[@class="form-buttons"]/descendant::span[.="{{%s}}"]';
 
@@ -243,7 +243,7 @@ 
      * @var string
      */
 
-    public $searchButtonText                         = '{{Search}}';
+    public $searchButtonText = '{{Search}}';
 
     /**
      * @return Translator

lib/Magento/Themes/OnePageCheckout/AbstractThemeConfiguration.php

Indentation +3 added lines, -3 removed lines

@@ -260,9 +260,9 @@
         return $this->translatePlaceholders($this->shippingMethodContinueButtonXpath);
     }
 
-     /**
-      * @return string
-     */
+        /**
+         * @return string
+         */
     public function getPlaceOrderButtonXpath()
     {
         return $this->translatePlaceholders($this->placeOrderButtonXpath);

Spacing +5 added lines, -5 removed lines

@@ -569,7 +569,7 @@ 
      */
     public function getBillingAddressXpath()
     {
-        return$this->translatePlaceholders( $this->billingAddressXpath);
+        return$this->translatePlaceholders($this->billingAddressXpath);
     }
 
     /**
@@ -677,7 +677,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopPriceXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopPriceXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -686,7 +686,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopNameXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopNameXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -695,7 +695,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopQtyXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopQtyXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 
@@ -704,7 +704,7 @@ 
      */
     public function getCartSummaryCheckoutProductLoopSubtotalXpath($itemCount)
     {
-        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath , $itemCount);
+        $return = sprintf($this->cartSummaryCheckoutProductLoopSubtotalXpath, $itemCount);
         return $this->translatePlaceholders($return);
     }
 

Doc Comments +13 added lines, -2 removed lines

@@ -138,7 +138,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getTermsAndConditionsSelectorXpath($term)
     {
@@ -329,7 +329,7 @@ 
     }
 
     /**
-     * @param string $shippinFirstNameXpath
+     * @param string $shippingFirstNameXpath
      */
     public function setShippingFirstNameXpath($shippingFirstNameXpath)
     {
@@ -433,6 +433,7 @@ 
     }
 
     /**
+     * @param string $region
      * @return string
      */
     public function getShippingRegionIdXpath($region)
@@ -466,6 +467,7 @@ 
     }
 
     /**
+     * @param string $country
      * @return string
      */
     public function getShippingCountryIdXpath($country)
@@ -546,6 +548,9 @@ 
         $this->shippingContinueCompletedXpath = $shippingContinueCompletedXpath;
     }
 
+    /**
+     * @return string
+     */
     public function getBillingContinueCompletedXpath()
     {
         return $this->translatePlaceholders($this->billingContinueCompletedXpath);
@@ -618,6 +623,7 @@ 
     }
 
     /**
+     * @param string $region
      * @return string
      */
     public function getBillingRegionIdXpath($region)
@@ -635,6 +641,7 @@ 
     }
 
     /**
+     * @param string $country
      * @return string
      */
     public function getBillingCountryIdXpath($country)
@@ -702,6 +709,7 @@ 
 
 
     /**
+     * @param integer $itemCount
      * @return string
      */
     public function getCartSummaryCheckoutProductLoopPriceXpath($itemCount)
@@ -711,6 +719,7 @@ 
     }
 
     /**
+     * @param integer $itemCount
      * @return string
      */
     public function getCartSummaryCheckoutProductLoopNameXpath($itemCount)
@@ -720,6 +729,7 @@ 
     }
 
     /**
+     * @param integer $itemCount
      * @return string
      */
     public function getCartSummaryCheckoutProductLoopQtyXpath($itemCount)
@@ -729,6 +739,7 @@ 
     }
 
     /**
+     * @param integer $itemCount
      * @return string
      */
     public function getCartSummaryCheckoutProductLoopSubtotalXpath($itemCount)

lib/Magento/Actions/Cart/AddConfigurableProductToCart.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {
-                    throw new InvalidConfigurableOptionException('Missing the attribute: ' . $attributeName);
+                    throw new InvalidConfigurableOptionException('Missing the attribute: '.$attributeName);
                 }
                 $element = $elementOption->getValue($this->getOption($attributeName));
                 if (!$element instanceof Value) {

Braces +3 added lines, -1 removed lines

@@ -57,7 +57,9 @@
             $attributes = $this->option->getOptionNames();
             foreach ($attributes as $attributeName) {
                 $elementOption = $this->option->getOption($attributeName);
-                if (!$elementOption) continue;
+                if (!$elementOption) {
+                    continue;
+                }
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Magium\Actions\StaticActionInterface;
 use Magium\Magento\Extractors\Catalog\Cart\AddToCart;
 use Magium\Magento\Extractors\Catalog\Product\ConfigurableProductOptions;
-use Magium\Magento\Extractors\Catalog\Product\Swatch;
 use Magium\Magento\Extractors\Catalog\Product\Option;
 use Magium\Magento\Extractors\Catalog\Product\SwatchValue;
 use Magium\Magento\Extractors\Catalog\Product\Value;

lib/Magento/Actions/Cart/AddSimpleProductToCart.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
     {
         if ($this->requireQty || $this->addQty > 1) {
             if (!$this->webDriver->elementExists($this->theme->getSimpleProductQtyXpath(), WebDriver::BY_XPATH)) {
-                throw new NoSuchElementException('Could not find the simple add to cart element with the Xpath: ' . $this->theme->getAddToCartXpath());
+                throw new NoSuchElementException('Could not find the simple add to cart element with the Xpath: '.$this->theme->getAddToCartXpath());
             }
             $element = $this->webDriver->byXpath($this->theme->getSimpleProductQtyXpath());
             $element->clear();
@@ -66,7 +66,7 @@ 
         try {
             $element->click();
         } catch (\Exception $e) {
-            $e2 = $this->webDriver->byXpath($this->theme->getAddToCartXpath() . '/ancestor::li');
+            $e2 = $this->webDriver->byXpath($this->theme->getAddToCartXpath().'/ancestor::li');
             $this->webDriver->getMouse()->mouseMove($e2->getCoordinates());
             $element->click();
         }

lib/Magento/Actions/Cart/AddToCartFailedException.php

Spacing +1 added lines, -1 removed lines

@@ -2,4 +2,4 @@
 
 namespace Magium\Magento\Actions\Cart;
 
-class AddToCartFailedException extends NoSuchElementException  {}
\ No newline at end of file
+class AddToCartFailedException extends NoSuchElementException {}
\ No newline at end of file

lib/Magento/Actions/Misc/SubmitContactForm.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         $this->testCase->assertElementDisplayed($this->theme->getContactUsSubmitXpath(), WebDriver::BY_XPATH);
 
         $this->webDriver->byXpath($this->theme->getContactUsNameXpath())->clear()->sendKeys(
-            $this->customer->getFirstName() . ' ' . $this->customer->getLastName()
+            $this->customer->getFirstName().' '.$this->customer->getLastName()
         );
 
         $this->webDriver->byXpath($this->theme->getContactUsEmailXpath())->clear()->sendKeys(

lib/Magento/Actions/Checkout/AbstractCheckout.php

Braces +6 added lines, -2 removed lines

@@ -44,10 +44,14 @@
         foreach ($this->steps as $step) {
             if ($step instanceof StepInterface) {
                 $continue = $step->execute();
-                if (!$continue) return;
+                if (!$continue) {
+                    return;
+                }
 
                 $continue = $step->nextAction();
-                if (!$continue) return;
+                if (!$continue) {
+                    return;
+                }
             }
         }
     }

lib/Magento/Actions/Checkout/PaymentInformation/AuthorizeNet.php

Indentation +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         self::TYPE_VISA                => '4007000000027',
         self::TYPE_AMERICAN_EXPRESS    => '370000000000002',
         self::TYPE_DISCOVER            => '6011000000000012',
- 	    self::TYPE_MASTERCARD          => '5424000000000015',
+            self::TYPE_MASTERCARD          => '5424000000000015',
         self::TYPE_UNKNOWN             => '0000000000000000'
     ];
 

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     protected function configureType($type)
     {
         if (!isset($this->ccNums[$type])) {
-            throw new InvalidPaymentInformationException('Unknown payment type: ' . $type);
+            throw new InvalidPaymentInformationException('Unknown payment type: '.$type);
         }
         $this->setCreditCardNumber($this->ccNums[$type]);
         $this->setType($type);