CheckMoneyOrder::__construct() - Code Metrics - Inspection of "Added check payment method" - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#104)

by Kevin

created 2017-08-02 20:55 UTC

CheckMoneyOrder::__construct() A

↳ Parent: CheckMoneyOrder

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	7
loc	7
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	5
nc	1
nop	2

<?php

namespace Magium\Magento\Actions\Checkout\PaymentMethods;

use Magium\Magento\AbstractMagentoTestCase;
use Magium\WebDriver\WebDriver;

class CheckMoneyOrder implements PaymentMethodInterface

{

    const ACTION = 'Checkout\PaymentMethods\CheckMoneyOrder';

    protected $webDriver;
    protected $testCase;

    public function __construct(
        WebDriver                   $webDriver,
        AbstractMagentoTestCase     $testCase
    ) {
        $this->webDriver    = $webDriver;
        $this->testCase     = $testCase;
    }

    public function getId()
    {
        return 'p_method_checkmo';
    }

    /**
     * Fills in the payment form, selecting it, if necessary
     *
     * @param $requirePayment
     */

    public function pay($requirePayment)
    {
        if ($requirePayment) {
            $this->testCase->assertElementExists($this->getId());
        }

        if ($this->webDriver->elementDisplayed($this->getId())) {
            $element = $this->webDriver->byId($this->getId());
            $this->webDriver->getMouse()->click($element->getCoordinates());
        }
    }
}


1		<?php
2
3		namespace Magium\Magento\Actions\Checkout\PaymentMethods;
4
5		use Magium\Magento\AbstractMagentoTestCase;
6		use Magium\WebDriver\WebDriver;
7
8	View Code Duplication	class CheckMoneyOrder implements PaymentMethodInterface
		0 ignored issues – show Duplication introduced 2017-08-02 21:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10
11		const ACTION = 'Checkout\PaymentMethods\CheckMoneyOrder';
12
13		protected $webDriver;
14		protected $testCase;
15
16		public function __construct(
17		WebDriver $webDriver,
18		AbstractMagentoTestCase $testCase
19		) {
20		$this->webDriver = $webDriver;
21		$this->testCase = $testCase;
22		}
23
24		public function getId()
25		{
26		return 'p_method_checkmo';
27		}
28
29		/**
30		* Fills in the payment form, selecting it, if necessary
31		*
32		* @param $requirePayment
33		*/
34
35		public function pay($requirePayment)
36		{
37		if ($requirePayment) {
38		$this->testCase->assertElementExists($this->getId());
39		}
40
41		if ($this->webDriver->elementDisplayed($this->getId())) {
42		$element = $this->webDriver->byId($this->getId());
43		$this->webDriver->getMouse()->click($element->getCoordinates());
44		}
45		}
46		}
47

magium / MagiumMagento

GitHub Access Token became invalid

Pull Request — master (#104)

CheckMoneyOrder::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like