NavigateToOrder::navigateTo() - Code Metrics - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

NavigateToOrder::navigateTo() A
last analyzed 2017-11-09 15:32 UTC

↳ Parent: NavigateToOrder

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1

<?php

namespace Magium\Magento\Navigators\Customer;

use Magium\Actions\WaitForPageLoaded;
use Magium\Magento\Themes\Customer\AbstractThemeConfiguration;
use Magium\Navigators\ConfigurableNavigatorInterface;
use Magium\WebDriver\ExpectedCondition;
use Magium\WebDriver\WebDriver;

class NavigateToOrder implements ConfigurableNavigatorInterface
{
    const NAVIGATOR = 'Customer\NavigateToOrder';
    protected $webDriver;
    protected $accountNavigator;
    protected $themeConfiguration;
    protected $loaded;

    public function __construct(
        WebDriver               $webDriver,
        Account                 $accountNavigator,
        AbstractThemeConfiguration      $themeConfiguration,
        WaitForPageLoaded $loaded
    )
    {
        $this->webDriver            = $webDriver;
        $this->accountNavigator     = $accountNavigator;
        $this->themeConfiguration   = $themeConfiguration;
        $this->loaded               = $loaded;
    }

    public function navigateTo($orderId)
    {
        $xpath = $this->themeConfiguration->getAccountNavigationXpath($this->themeConfiguration->getOrderPageName());
        $element = $this->webDriver->byXpath($xpath);
        $element->click();
        $this->loaded->execute($element);

        $xpath = $this->themeConfiguration->getViewOrderLinkXpath($orderId);
        $element = $this->webDriver->byXpath($xpath);
        $element->click();
        $this->loaded->execute($element);

        $this->webDriver->wait()->until(ExpectedCondition::titleContains($this->themeConfiguration->getOrderPageTitleContainsText()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    }

}

1			<?php
2
3			namespace Magium\Magento\Navigators\Customer;
4
5			use Magium\Actions\WaitForPageLoaded;
6			use Magium\Magento\Themes\Customer\AbstractThemeConfiguration;
7			use Magium\Navigators\ConfigurableNavigatorInterface;
8			use Magium\WebDriver\ExpectedCondition;
9			use Magium\WebDriver\WebDriver;
10
11			class NavigateToOrder implements ConfigurableNavigatorInterface
12			{
13			const NAVIGATOR = 'Customer\NavigateToOrder';
14			protected $webDriver;
15			protected $accountNavigator;
16			protected $themeConfiguration;
17			protected $loaded;
18
19			public function __construct(
20			WebDriver $webDriver,
21			Account $accountNavigator,
22			AbstractThemeConfiguration $themeConfiguration,
23			WaitForPageLoaded $loaded
24			)
25			{
26			$this->webDriver = $webDriver;
27			$this->accountNavigator = $accountNavigator;
28			$this->themeConfiguration = $themeConfiguration;
29			$this->loaded = $loaded;
30			}
31
32			public function navigateTo($orderId)
33			{
34			$xpath = $this->themeConfiguration->getAccountNavigationXpath($this->themeConfiguration->getOrderPageName());
35			$element = $this->webDriver->byXpath($xpath);
36			$element->click();
37			$this->loaded->execute($element);
38
39			$xpath = $this->themeConfiguration->getViewOrderLinkXpath($orderId);
40			$element = $this->webDriver->byXpath($xpath);
41			$element->click();
42			$this->loaded->execute($element);
43
44			$this->webDriver->wait()->until(ExpectedCondition::titleContains($this->themeConfiguration->getOrderPageTitleContainsText()));
			0 ignored issues – show Documentation introduced 2017-02-17 18:01 UTC by Report Bug Copy Issue Report `\Magium\WebDriver\Expect...ageTitleContainsText())` is of type `object<Magium\WebDriver\ExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45
46			}
47
48			}

magium / MagiumMagento

GitHub Access Token became invalid

NavigateToOrder::navigateTo() A last analyzed 2017-11-09 15:32 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NavigateToOrder::navigateTo() A
last analyzed 2017-11-09 15:32 UTC