ProductGrid::getElementXpath() - Code Metrics - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

ProductGrid::getElementXpath() D
last analyzed 2017-11-09 15:32 UTC

↳ Parent: ProductGrid

Complexity

Conditions	10
Paths	10

Size

Total Lines	32
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	29
nc	10
nop	2

How to fix Complexity

<?php

namespace Magium\Magento\Extractors\Catalog\Products;


class ProductGrid extends AbstractProductCollection
{

    const EXTRACTOR = 'Catalog\Products\ProductGrid';

    public function getElementXpath($type, $count)
    {
        switch ($type) {
            case ProductSummary::DESCRIPTION:
                return $this->theme->getProductGridDescriptionXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::TITLE:
                return $this->theme->getProductGridTitleXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::COMPARE_LINK:
                return $this->theme->getProductGridCompareLinkXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::IMAGE:
                return $this->theme->getProductGridImageXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::LINK:
                return $this->theme->getProductGridLinkXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::ORIGINAL_PRICE:
                return $this->theme->getProductGridOriginalPriceXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::PRICE:
                return $this->theme->getProductGridPriceXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::WISHLIST_LINK:
                return $this->theme->getProductGridWishlistLinkXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ProductSummary::ADD_TO_CART_LINK:
                return $this->theme->getProductGridAddToCartLinkXpath($count);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }


}

1			<?php
2
3			namespace Magium\Magento\Extractors\Catalog\Products;
4
5
6			class ProductGrid extends AbstractProductCollection
7			{
8
9			const EXTRACTOR = 'Catalog\Products\ProductGrid';
10
11			public function getElementXpath($type, $count)
12			{
13			switch ($type) {
14			case ProductSummary::DESCRIPTION:
15			return $this->theme->getProductGridDescriptionXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridDescriptionXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
16			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
17			case ProductSummary::TITLE:
18			return $this->theme->getProductGridTitleXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridTitleXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
19			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
20			case ProductSummary::COMPARE_LINK:
21			return $this->theme->getProductGridCompareLinkXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridCompareLinkXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
22			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
23			case ProductSummary::IMAGE:
24			return $this->theme->getProductGridImageXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridImageXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
25			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
26			case ProductSummary::LINK:
27			return $this->theme->getProductGridLinkXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridLinkXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
28			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
29			case ProductSummary::ORIGINAL_PRICE:
30			return $this->theme->getProductGridOriginalPriceXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridOriginalPriceXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
32			case ProductSummary::PRICE:
33			return $this->theme->getProductGridPriceXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridPriceXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
35			case ProductSummary::WISHLIST_LINK:
36			return $this->theme->getProductGridWishlistLinkXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridWishlistLinkXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
38			case ProductSummary::ADD_TO_CART_LINK:
39			return $this->theme->getProductGridAddToCartLinkXpath($count);
			0 ignored issues – show Bug introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Magium\Themes\ThemeConfigurationInterface` as the method `getProductGridAddToCartLinkXpath()` does only exist in the following implementations of said interface: `Magium\Magento\Themes\AbstractThemeConfiguration`, `Magium\Magento\Themes\Magento18\ThemeConfiguration`, `Magium\Magento\Themes\Magento19\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E112\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E113\ThemeConfiguration`, `Magium\Magento\Themes\Ma...E114\ThemeConfiguration`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
40			break;
			0 ignored issues – show Unused Code introduced 2016-03-18 13:22 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
41			}
42			}
43
44
45			}

GitHub Access Token became invalid

ProductGrid::getElementXpath() D
last analyzed 2017-11-09 15:32 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

magium / MagiumMagento

GitHub Access Token became invalid

ProductGrid::getElementXpath() D last analyzed 2017-11-09 15:32 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ProductGrid::getElementXpath() D
last analyzed 2017-11-09 15:32 UTC