ExtractNavigationXpathTest::testExecute() - Code Metrics - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

ExtractNavigationXpathTest::testExecute() A
last analyzed 2017-11-09 15:32 UTC

↳ Parent: ExtractNavigationXpathTest

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	3
eloc	9
nc	2
nop	0

<?php

namespace Magium\Magento\Cli\Command\Test;

use Magium\Extractors\Navigation\Menu;
use Magium\Magento\AbstractMagentoTestCase;

class ExtractNavigationXpathTest extends AbstractMagentoTestCase
{

    protected $baseXpath;
    protected $childXpath;

    protected $url;
    protected $category;

    /**
     * @param mixed $url
     */
    public function setUrl($url)
    {
        $this->url = $url;
    }

    /**
     * @param mixed $category
     */
    public function setCategory($category)
    {
        $this->category = $category;
    }

    /**
     * @return mixed
     */
    public function getBaseXpath()
    {
        return $this->baseXpath;
    }

    /**
     * @return mixed
     */
    public function getChildXpath()
    {
        return $this->childXpath;
    }



    public function testExecute()
    {
        if (!$this->category || !$this->url) {
            throw new MissingConfigurationException('Both the category and the url must be provided');
        }
        $this->commandOpen($this->url);

        $extractor = $this->getExtractor(Menu::EXTRACTOR);
        /* @var $extractor Menu */
        $extractor->setPath($this->category);
        $extractor->extract();
        $this->baseXpath = $extractor->getBaseXpath();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->childXpath = $extractor->getChildXpath();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }

}

1			<?php
2
3			namespace Magium\Magento\Cli\Command\Test;
4
5			use Magium\Extractors\Navigation\Menu;
6			use Magium\Magento\AbstractMagentoTestCase;
7
8			class ExtractNavigationXpathTest extends AbstractMagentoTestCase
9			{
10
11			protected $baseXpath;
12			protected $childXpath;
13
14			protected $url;
15			protected $category;
16
17			/**
18			* @param mixed $url
19			*/
20			public function setUrl($url)
21			{
22			$this->url = $url;
23			}
24
25			/**
26			* @param mixed $category
27			*/
28			public function setCategory($category)
29			{
30			$this->category = $category;
31			}
32
33			/**
34			* @return mixed
35			*/
36			public function getBaseXpath()
37			{
38			return $this->baseXpath;
39			}
40
41			/**
42			* @return mixed
43			*/
44			public function getChildXpath()
45			{
46			return $this->childXpath;
47			}
48
49
50
51			public function testExecute()
52			{
53			if (!$this->category \|\| !$this->url) {
54			throw new MissingConfigurationException('Both the category and the url must be provided');
55			}
56			$this->commandOpen($this->url);
57
58			$extractor = $this->getExtractor(Menu::EXTRACTOR);
59			/* @var $extractor Menu */
60			$extractor->setPath($this->category);
61			$extractor->extract();
62			$this->baseXpath = $extractor->getBaseXpath();
			0 ignored issues – show Bug introduced 2016-04-05 13:59 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->baseXpath` is correct as `$extractor->getBaseXpath()` (which targets `Magium\Extractors\Navigation\Menu::getBaseXpath()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
63			$this->childXpath = $extractor->getChildXpath();
			0 ignored issues – show Bug introduced 2016-04-05 13:59 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->childXpath` is correct as `$extractor->getChildXpath()` (which targets `Magium\Extractors\Navigation\Menu::getChildXpath()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
64			}
65
66			}

magium / MagiumMagento

GitHub Access Token became invalid

ExtractNavigationXpathTest::testExecute() A last analyzed 2017-11-09 15:32 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ExtractNavigationXpathTest::testExecute() A
last analyzed 2017-11-09 15:32 UTC