ShippingMethod - Code Metrics - magium/MagiumMagento - Measure and Improve Code Quality continuously with Scrutinizer

ShippingMethod A
last analyzed 2017-11-09 15:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	28.3 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	1
cbo	7
dl	15
loc	53
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	requireShipping()	0	4	1
A	execute()	0	8	1
A	nextAction()	15	15	1

How to fix Duplicated Code

<?php

namespace Magium\Magento\Actions\Checkout\Steps;

use Facebook\WebDriver\WebDriverExpectedCondition;
use Magium\Magento\AbstractMagentoTestCase;
use Magium\Magento\Actions\Checkout\ShippingMethods\ShippingMethodInterface;
use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
use Magium\WebDriver\ExpectedCondition;
use Magium\WebDriver\WebDriver;

class ShippingMethod implements StepInterface
{
    const ACTION = 'Checkout\Steps\ShippingMethod';
    protected $webdriver;
    protected $theme;
    protected $testCase;
    protected $shipping;

    protected $requireShipping = false;

    public function __construct(
        WebDriver                   $webdriver,
        AbstractThemeConfiguration          $theme,
        AbstractMagentoTestCase     $testCase,
        ShippingMethodInterface     $shippingMethod
    ) {
        $this->webdriver        = $webdriver;
        $this->theme            = $theme;
        $this->testCase         = $testCase;
        $this->shipping         = $shippingMethod;

    }

    public function requireShipping($require = true)
    {
        $this->requireShipping = $require;
    }
    
    public function execute()
    {
        $this->webdriver->wait()->until(ExpectedCondition::elementExists($this->theme->getShippingMethodContinueButtonXpath(), WebDriver::BY_XPATH));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->webdriver->wait()->until(ExpectedCondition::visibilityOf($this->webdriver->byXpath($this->theme->getShippingMethodContinueButtonXpath())));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->shipping->choose($this->requireShipping);

        return true; // continue to next step
    }

    public function nextAction()

    {

        $this->webdriver->byXpath($this->theme->getShippingMethodContinueButtonXpath())->click();
        $this->webdriver->wait()->until(
            WebDriverExpectedCondition::not(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                WebDriverExpectedCondition::visibilityOf(
                    $this->webdriver->byXpath(
                        $this->theme->getShippingMethodContinueCompletedXpath()
                    )
                )
            )
        );
        return true;
    }
}

1		<?php
2
3		namespace Magium\Magento\Actions\Checkout\Steps;
4
5		use Facebook\WebDriver\WebDriverExpectedCondition;
6		use Magium\Magento\AbstractMagentoTestCase;
7		use Magium\Magento\Actions\Checkout\ShippingMethods\ShippingMethodInterface;
8		use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
9		use Magium\WebDriver\ExpectedCondition;
10		use Magium\WebDriver\WebDriver;
11
12		class ShippingMethod implements StepInterface
13		{
14		const ACTION = 'Checkout\Steps\ShippingMethod';
15		protected $webdriver;
16		protected $theme;
17		protected $testCase;
18		protected $shipping;
19
20		protected $requireShipping = false;
21
22		public function __construct(
23		WebDriver $webdriver,
24		AbstractThemeConfiguration $theme,
25		AbstractMagentoTestCase $testCase,
26		ShippingMethodInterface $shippingMethod
27		) {
28		$this->webdriver = $webdriver;
29		$this->theme = $theme;
30		$this->testCase = $testCase;
31		$this->shipping = $shippingMethod;
32
33		}
34
35		public function requireShipping($require = true)
36		{
37		$this->requireShipping = $require;
38		}
39
40		public function execute()
41		{
42		$this->webdriver->wait()->until(ExpectedCondition::elementExists($this->theme->getShippingMethodContinueButtonXpath(), WebDriver::BY_XPATH));
		0 ignored issues – show Documentation introduced 2017-02-17 18:01 UTC by Report Bug Copy Issue Report `\Magium\WebDriver\Expect...er\WebDriver::BY_XPATH)` is of type `object<Facebook\WebDrive...riverExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43		$this->webdriver->wait()->until(ExpectedCondition::visibilityOf($this->webdriver->byXpath($this->theme->getShippingMethodContinueButtonXpath())));
		0 ignored issues – show Documentation introduced 2017-02-17 18:01 UTC by Report Bug Copy Issue Report `\Magium\WebDriver\Expect...ContinueButtonXpath()))` is of type `object<Magium\WebDriver\ExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		$this->shipping->choose($this->requireShipping);
45
46		return true; // continue to next step
47		}
48
49	View Code Duplication	public function nextAction()
		0 ignored issues – show Duplication introduced 2017-08-02 21:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51
52		$this->webdriver->byXpath($this->theme->getShippingMethodContinueButtonXpath())->click();
53		$this->webdriver->wait()->until(
54		WebDriverExpectedCondition::not(
		0 ignored issues – show Documentation introduced 2017-02-17 18:01 UTC by Report Bug Copy Issue Report `\Facebook\WebDriver\WebD...inueCompletedXpath())))` is of type `object<Facebook\WebDrive...riverExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55		WebDriverExpectedCondition::visibilityOf(
56		$this->webdriver->byXpath(
57		$this->theme->getShippingMethodContinueCompletedXpath()
58		)
59		)
60		)
61		);
62		return true;
63		}
64		}

magium / MagiumMagento

GitHub Access Token became invalid

ShippingMethod A last analyzed 2017-11-09 15:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ShippingMethod A
last analyzed 2017-11-09 15:32 UTC